OFBiz
  1. OFBiz
  2. OFBIZ-4851

Error on View Facility Inventory Items Details Page

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: Trunk
    • Component/s: product
    • Labels:
      None

      Description

      Error on https://demo-trunk.ofbiz.apache.org:8443/facility/control/ViewFacilityInventoryItemsDetails Page, when you select Report Type - "By Inventory Item" or "By Product" its throwing error.

      org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen component://common/widget/CommonScreens.xml#GlobalDecorator: java.lang.IllegalArgumentException: Return value from use-when condition eval was not a Boolean: null [null] on the field inventoryItemId of form ListFacilityInventoryItemsDetailsByItem (Return value from use-when condition eval was not a Boolean: null [null] on the field inventoryItemId of form ListFacilityInventoryItemsDetailsByItem)

      1. OFBIZ-4851.patch
        2 kB
        Ankit Jain
      2. OFBIZ-4851ProductForms.patch
        1 kB
        Tom Burns

        Activity

        Hide
        Jacques Le Roux added a comment -

        Thanks Tom,

        I found some other similar cases and fixed them as well in
        trunk r1399539
        R12.04 r1399540

        I did not backport further, R11.04 does not suffer from the same

        Show
        Jacques Le Roux added a comment - Thanks Tom, I found some other similar cases and fixed them as well in trunk r1399539 R12.04 r1399540 I did not backport further, R11.04 does not suffer from the same
        Hide
        Tom Burns added a comment -

        To reproduce:
        1. In Catalog Manager select the Products menu
        2. Click find
        3. Click product id GZ-1006-1
        4. Click Locations tab
        5. In Add Facility Location screenlet select Web Store Warehouse from the Facility Id drop-down list
        6. In the Location Seq Id pop up window select Facility Id Web Store Warehouse click find.
        7. Select a Location Id
        8. In Add Facility Location click Add

        Expected: Add location to product record
        Actual:
        org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen component://common/widget/CommonScreens.xml#GlobalDecorator: java.lang.IllegalArgumentException: Return value from use-when condition eval was not a Boolean: null [null] on the field facilityName of form UpdateProductFacilityLocations (Return value from use-when condition eval was not a Boolean: null [null] on the field facilityName of form UpdateProductFacilityLocations)

        Show
        Tom Burns added a comment - To reproduce: 1. In Catalog Manager select the Products menu 2. Click find 3. Click product id GZ-1006-1 4. Click Locations tab 5. In Add Facility Location screenlet select Web Store Warehouse from the Facility Id drop-down list 6. In the Location Seq Id pop up window select Facility Id Web Store Warehouse click find. 7. Select a Location Id 8. In Add Facility Location click Add Expected: Add location to product record Actual: org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen component://common/widget/CommonScreens.xml#GlobalDecorator : java.lang.IllegalArgumentException: Return value from use-when condition eval was not a Boolean: null [null] on the field facilityName of form UpdateProductFacilityLocations (Return value from use-when condition eval was not a Boolean: null [null] on the field facilityName of form UpdateProductFacilityLocations)
        Hide
        Tom Burns added a comment -

        Jacques,

        Ran into this problem in applications/product/widget/catalog/ProductForms.xml
        Here is a patch for the trunk that seems to work.

        Tom

        Show
        Tom Burns added a comment - Jacques, Ran into this problem in applications/product/widget/catalog/ProductForms.xml Here is a patch for the trunk that seems to work. Tom
        Hide
        Jacques Le Roux added a comment -

        Backported in R12.04 at r1334338

        Show
        Jacques Le Roux added a comment - Backported in R12.04 at r1334338
        Hide
        Ankit Jain added a comment -

        Thanks Jacques.

        Show
        Ankit Jain added a comment - Thanks Jacques.
        Hide
        Jacques Le Roux added a comment - - edited

        ======== EDIT: used

        { noformat }

        for special chars =========
        Thanks Ankit,

        Your (slightly modified) patch is in trunk at r1334201

         
        Sligth changes from your patch: I simply used real ' instead of " and reformatted to make things more legible. 
        I tried also to replace & by & but Xerces complained, not sure what the logic is here...
        

        I supposed it was related to recent changes on scripts language, but was not sure. So I searched for ${bsh:* type="Boolean"/> and found some others of the same kind: in UpdateProductFacilityLocations, FindProject, sprintBacklogListItems forms and more in scrumForms.xml. I tried with UpdateProductFacilityLocations & FindProject but surprisingly did not reproduce the problem. At this stage I gave up...

        Show
        Jacques Le Roux added a comment - - edited ======== EDIT: used { noformat } for special chars ========= Thanks Ankit, Your (slightly modified) patch is in trunk at r1334201 Sligth changes from your patch: I simply used real ' instead of " and reformatted to make things more legible. I tried also to replace & by & but Xerces complained, not sure what the logic is here... I supposed it was related to recent changes on scripts language, but was not sure. So I searched for ${bsh:* type="Boolean"/> and found some others of the same kind: in UpdateProductFacilityLocations, FindProject, sprintBacklogListItems forms and more in scrumForms.xml. I tried with UpdateProductFacilityLocations & FindProject but surprisingly did not reproduce the problem. At this stage I gave up...
        Hide
        Ankit Jain added a comment -

        Attached patch fix the issue.

        Show
        Ankit Jain added a comment - Attached patch fix the issue.

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Ankit Jain
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development