OFBiz
  1. OFBiz
  2. OFBIZ-482

Invoice generation from order fails if there is a percent item adjustment

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: None
    • Component/s: accounting
    • Labels:
      None

      Description

      Invoice generation from an order checks whether the current invoiced amount for an adjustment exceeds the adjustment, but only works if the adjustment is a flat amount - it fails if the adjustment is a percentage.

      The attached patch addresses this issue.

      1. invoice.pdf
        11 kB
        Deepak Dixit
      2. InvoiceServices.patch
        2 kB
        Iain Fogg

        Activity

        Iain Fogg created issue -
        Iain Fogg made changes -
        Field Original Value New Value
        Attachment InvoiceServices.patch [ 12345351 ]
        Si Chen made changes -
        Assignee Si Chen [ sichen ]
        Hide
        Jacopo Cappellato added a comment -

        Si,

        did you already review/commit this patch? Can we close the issue?

        Show
        Jacopo Cappellato added a comment - Si, did you already review/commit this patch? Can we close the issue?
        Hide
        Si Chen added a comment -

        No, I don't think I looked at this yet.

        Show
        Si Chen added a comment - No, I don't think I looked at this yet.
        Marco Risaliti made changes -
        Fix Version/s SVN trunk [ 12311928 ]
        Component/s accounting [ 12311146 ]
        Affects Version/s SVN trunk [ 12311928 ]
        Jacopo Cappellato made changes -
        Assignee Si Chen [ sichen ] Jacopo Cappellato [ jacopoc ]
        Gavin made changes -
        Workflow jira [ 12389955 ] OFbiz Workflow [ 12504328 ]
        Jacopo Cappellato made changes -
        Assignee Jacopo Cappellato [ jacopoc ]
        Jacopo Cappellato made changes -
        Fix Version/s Trunk [ 12311928 ]
        Hide
        Deepak Dixit added a comment -

        IMO We can close this task. Invoice generating properly for percent item adjustment as well.
        I created an order for product GZ-1005 ( Promotion 20% off any one item, either GZ-1005 (.NIT Gizmo) or GZ-1006 (Open Gizmo) with a limit of 1 per order ) and invoice generated properly.

        Show
        Deepak Dixit added a comment - IMO We can close this task. Invoice generating properly for percent item adjustment as well. I created an order for product GZ-1005 ( Promotion 20% off any one item, either GZ-1005 (.NIT Gizmo) or GZ-1006 (Open Gizmo) with a limit of 1 per order ) and invoice generated properly.
        Deepak Dixit made changes -
        Attachment invoice.pdf [ 12688496 ]
        Hide
        Deepak Dixit added a comment -

        I think this has been fixed at r#814130.

        Show
        Deepak Dixit added a comment - I think this has been fixed at r#814130.
        Ashish Vijaywargiya made changes -
        Assignee Ashish Vijaywargiya [ toashishvijay ]
        Hide
        Ashish Vijaywargiya added a comment -

        Based on Deepak's recent comment we can safely close this issue.

        Show
        Ashish Vijaywargiya added a comment - Based on Deepak's recent comment we can safely close this issue.
        Ashish Vijaywargiya made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        2951d 15h 5m 1 Ashish Vijaywargiya 20/Dec/14 05:30

          People

          • Assignee:
            Ashish Vijaywargiya
            Reporter:
            Iain Fogg
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development