OFBiz
  1. OFBiz
  2. OFBIZ-4813

ajax autocomplete and dialog during session timeout

    Details

      Description

      1. autocomplete feature shows the message "no records found" during a session timeout. This could be misleading for the user.
      2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout. Should show a more detailed message.
      3. All ajax dialogs are on the left of browser window.

      A number of fixes have been implemented for this issue.

      1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
      2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
      3. A large round spinner is shown when the ajax dialog is loading. This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free. Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
      4. Now all ajax dialogs are centered.
      5. Change session timeout message to something more detailed.
      6. Server response to ajax request now contain html tags.

      1. spinner.gif
        3 kB
        Wai
      2. OFBIZ-4813-trunk.patch
        0.8 kB
        Amardeep Singh Jhajj
      3. OFBIZ-4813-R11.04.patch
        20 kB
        yashwant dhakad
      4. OFBIZ-4813-R11.04.patch
        0.8 kB
        Amardeep Singh Jhajj
      5. ofbiz-4813-additional.patch
        4 kB
        Wai
      6. ofbiz-4813.patch
        23 kB
        Wai
      7. ofbiz-4813.patch
        17 kB
        Wai
      8. ofbiz-4813.patch
        20 kB
        Wai

        Activity

        Hide
        Wai added a comment - - edited

        Instruction(s):
        1. Apply patch
        2. Replace /ofbiz/framework/images/webapp/images/spinner.gif with this new file.

        Show
        Wai added a comment - - edited Instruction(s): 1. Apply patch 2. Replace /ofbiz/framework/images/webapp/images/spinner.gif with this new file.
        Hide
        Jacques Le Roux added a comment -

        Wai,

        About the point 4: I purposely decided to put the layered Ajax box at top left because it allows an easier "maximisation". When centered, if you want to increase the surface you have 1st to move it to top left, then increase. When in top left one dragging gesture et voilà.

        I don't know what others think about that

             <property key="CommonSessionTimeoutPleaseLogIn">
        -        <value xml:lang="de">Sie sind nicht mehr angemeldet. Bitte melden Sie sich erneut an.</value>
        -        <value xml:lang="en">You are not logged in. Please login again.</value>
        -        <value xml:lang="es">No está conectado. Por favor, vuelva a conectarse.</value>
        -        <value xml:lang="vi">Bạn chưa đăng nhập. Vui lòng đăng nhập lại.</value>
        +        <value xml:lang="en">Your session has expired.  A login is required.  You can refresh the page or save your data to login.</value>
        

        Why did you replace this (I don't say it's wrong, just to understand what was wrong)

        -    }    
        -    requestUrl = getViewNameWithSeparator(requestUrl) + "presentation=" + presentation;
        +    }
        
        +            var queryArgs = "presentation=" + presentation;
                     if (typeof args == "object" && jQuery.isArray(args)) {
                         for (var i = 0; i < args.length; i++) {
        -                    requestUrlAndArgs += "&parm" + i + "=" + jQuery(args[i]).val();
        +                    queryArgs += "&parm" + i + "=" + jQuery(args[i]).val();
        

        If you introduce a timeout, it should be configurable (property)

        +            jQuery.ajax({
        +                type: "post",
        +                url: requestUrl,
        +                data: queryArgs,
        +                timeout: 5000,
        

        Thanks

        Show
        Jacques Le Roux added a comment - Wai, About the point 4: I purposely decided to put the layered Ajax box at top left because it allows an easier "maximisation". When centered, if you want to increase the surface you have 1st to move it to top left, then increase. When in top left one dragging gesture et voilà. I don't know what others think about that <property key= "CommonSessionTimeoutPleaseLogIn" > - <value xml:lang= "de" >Sie sind nicht mehr angemeldet. Bitte melden Sie sich erneut an.</value> - <value xml:lang= "en" >You are not logged in. Please login again.</value> - <value xml:lang= "es" >No está conectado. Por favor, vuelva a conectarse.</value> - <value xml:lang= "vi" >Bạn chÆ°a đăng nhập. Vui lòng đăng nhập lại.</value> + <value xml:lang= "en" >Your session has expired. A login is required. You can refresh the page or save your data to login.</value> Why did you replace this (I don't say it's wrong, just to understand what was wrong) - } - requestUrl = getViewNameWithSeparator(requestUrl) + "presentation=" + presentation; + } + var queryArgs = "presentation=" + presentation; if (typeof args == "object" && jQuery.isArray(args)) { for ( var i = 0; i < args.length; i++) { - requestUrlAndArgs += "&parm" + i + "=" + jQuery(args[i]).val(); + queryArgs += "&parm" + i + "=" + jQuery(args[i]).val(); If you introduce a timeout, it should be configurable (property) + jQuery.ajax({ + type: "post" , + url: requestUrl, + data: queryArgs, + timeout: 5000, Thanks
        Hide
        Wai added a comment -

        Regarding point#4(centering of dialog):

        I centered it as it looked unusual. Usually dialogs are at the center of the screen. The modification was for esthetical reasons. I was not aware it was like that by design given your explanation. I can change it back.

        Regarding the change to label CommonSessionTimeoutPleaseLogIn:

        The modification was made for the situation where a user has spent time filling up a form and them through using the autocompleter realizes that a session timeout has occurred. This normally would cause a mild panic. Hence the message "Your session has expired. A login is required. You can refresh the page or save your data to login.", lets the user know that there are 2 ways to refresh the session. 1) refresh the page. Hence lose all changes. 2) save as usually and expect to encounter a login screen during the process.

        Regarding removal of code ""requestUrl = getViewNameWithSeparator(requestUrl) + ...:

        The original code uses jQuery(...).load(...) to initiate an ajax request. The new code uses jQuery.ajax(...). Hence, the code in question became unnecessary as jQuery.ajax() requires specification of path and querystring separately.

        Regarding the hardcoded timeout:

        I should have defined a global variable to specify the value. I can corrected it once all the points have been addressed.

        Wai

        Show
        Wai added a comment - Regarding point#4(centering of dialog): I centered it as it looked unusual. Usually dialogs are at the center of the screen. The modification was for esthetical reasons. I was not aware it was like that by design given your explanation. I can change it back. Regarding the change to label CommonSessionTimeoutPleaseLogIn: The modification was made for the situation where a user has spent time filling up a form and them through using the autocompleter realizes that a session timeout has occurred. This normally would cause a mild panic. Hence the message "Your session has expired. A login is required. You can refresh the page or save your data to login.", lets the user know that there are 2 ways to refresh the session. 1) refresh the page. Hence lose all changes. 2) save as usually and expect to encounter a login screen during the process. Regarding removal of code ""requestUrl = getViewNameWithSeparator(requestUrl) + ...: The original code uses jQuery(...).load(...) to initiate an ajax request. The new code uses jQuery.ajax(...). Hence, the code in question became unnecessary as jQuery.ajax() requires specification of path and querystring separately. Regarding the hardcoded timeout: I should have defined a global variable to specify the value. I can corrected it once all the points have been addressed. Wai
        Hide
        Jacques Le Roux added a comment -

        Hi Wai,

        Agreed on CommonSessionTimeoutPleaseLogIn change. Better having it only in English than keeping confusing/worrying previous even if we lose some translation.

        Agreed on removal of code ""requestUrl = getViewNameWithSeparator(requestUrl) + ...:

        I let you provide a new patch to apply soon.

        Thanks

        Show
        Jacques Le Roux added a comment - Hi Wai, Agreed on CommonSessionTimeoutPleaseLogIn change. Better having it only in English than keeping confusing/worrying previous even if we lose some translation. Agreed on removal of code ""requestUrl = getViewNameWithSeparator(requestUrl) + ...: I let you provide a new patch to apply soon. Thanks
        Hide
        Wai added a comment -

        Here's the updated patch.

        Show
        Wai added a comment - Here's the updated patch.
        Hide
        Wai added a comment -

        Please disregard previous patch.

        Show
        Wai added a comment - Please disregard previous patch.
        Hide
        Jacques Le Roux added a comment -

        Sounds good,I will wait a timeout to check before committing. I wonder if we should not also replace the Tomahawk spinner?

        Show
        Jacques Le Roux added a comment - Sounds good,I will wait a timeout to check before committing. I wonder if we should not also replace the Tomahawk spinner?
        Hide
        Jacques Le Roux added a comment -

        Thanks Wai,

        Your modified patch is in trunk r1327502

        What I adapted:

        • Added <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> in htmlheader-for-ajax.ftl
        • Replaced also spinner.gif in Tomahawk (better be consistent)
        • Added a French label an kept those existing but English (improved now)
        • Removed the ajaxErrorText style in ajaxNotLoggedIn screen

        For ajaxErrorText, maybe you forgot to provide it?

        I did not backport to release (would be only R11.04) because it's not really a bug but more an improvement.

        Show
        Jacques Le Roux added a comment - Thanks Wai, Your modified patch is in trunk r1327502 What I adapted: Added <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> in htmlheader-for-ajax.ftl Replaced also spinner.gif in Tomahawk (better be consistent) Added a French label an kept those existing but English (improved now) Removed the ajaxErrorText style in ajaxNotLoggedIn screen For ajaxErrorText, maybe you forgot to provide it? I did not backport to release (would be only R11.04) because it's not really a bug but more an improvement.
        Hide
        Wai added a comment -

        Jacques,

        I did a quick check of the commit for this issue and discovered the following problems:

        1. When ajaxErrorText style was removed, it uncovered a flaw in the regex pattern AJAX_SERVER_REPLY_MSG_REGEXPATTERN in selectall.js. As a result, the proper alert was not showing. It is now fixed.
        2. I noticed that changes in the relevant css files were not made. As a result the spinner is showing a horizontal repeat. This has been corrected.
        3. Tomahawk themes/tomahawk/webapp/tomahawk/images/spinner.gif is now removed framework/images/webapp/images.spinner.gif will be used by all themes in order for the same consistent spinner image to be used.

        The supplied patch fixes these problems.

        Thanks,
        Wai

        Show
        Wai added a comment - Jacques, I did a quick check of the commit for this issue and discovered the following problems: 1. When ajaxErrorText style was removed, it uncovered a flaw in the regex pattern AJAX_SERVER_REPLY_MSG_REGEXPATTERN in selectall.js. As a result, the proper alert was not showing. It is now fixed. 2. I noticed that changes in the relevant css files were not made. As a result the spinner is showing a horizontal repeat. This has been corrected. 3. Tomahawk themes/tomahawk/webapp/tomahawk/images/spinner.gif is now removed framework/images/webapp/images.spinner.gif will be used by all themes in order for the same consistent spinner image to be used. The supplied patch fixes these problems. Thanks, Wai
        Hide
        Wai added a comment -

        This is a supplementary patch to be applied to the trunk to fix the issues observed after the commit.

        Note: please delete themes/tomahawk/webapp/tomahawk/images/spinner.gif

        Thanks,
        Wai

        Show
        Wai added a comment - This is a supplementary patch to be applied to the trunk to fix the issues observed after the commit. Note: please delete themes/tomahawk/webapp/tomahawk/images/spinner.gif Thanks, Wai
        Hide
        Jacques Le Roux added a comment -

        Wai,

        Are you sure that removing the spinner in Tomahawk works? Here it does not it seems...

        Also I did not see any spinner repeated before. Is there a specific use case to reproduce?

        Show
        Jacques Le Roux added a comment - Wai, Are you sure that removing the spinner in Tomahawk works? Here it does not it seems... Also I did not see any spinner repeated before. Is there a specific use case to reproduce?
        Hide
        Jacques Le Roux added a comment -

        I guess for the spinner in Tomahawk you need to check the Theme setting (path to images). But then it gets maybe more complicated and it's easier to keep the duplicated gif.

        About AJAX_SERVER_REPLY_MSG_REGEXPATTERN. I'd prefer to keep the message in the layered popup instead of in an alert box, except if you want to resolve the i18n issue: just try with French to see what I mean...

        Show
        Jacques Le Roux added a comment - I guess for the spinner in Tomahawk you need to check the Theme setting (path to images). But then it gets maybe more complicated and it's easier to keep the duplicated gif. About AJAX_SERVER_REPLY_MSG_REGEXPATTERN. I'd prefer to keep the message in the layered popup instead of in an alert box, except if you want to resolve the i18n issue: just try with French to see what I mean...
        Hide
        Wai added a comment - - edited

        Jacques,

        Point#1:

        Regarding Tomahawk spinner image. You need to modify themes/tomahawk/webapp/tomahawk/css/style.css with the following changes specified in the patch "ofbiz-4813-additional.patch". If not, the spinner.gif inside the themes subdirectory would be used. That's why the #wait-spinner-image style specifies /images/spinner.gif as the target image to use and not /tomahawk/images/spinner.gif. To be consistent, all themes use /images/spinner.gif as the spinner image.

        #wait-spinner-image {
        height:45px;
        width:45px;
        background-repeat: no-repeat;
        background-image:url(/images/spinner.gif);
        }
        

        Note: The previous patch "ofbiz-4813patch" already contained the changes to the css files. I do not know why it was not committed with the rest of the code changes? "ofbiz-4813-additional.patch" was provided to address that.

        Point#2:

        Regarding i18n issue for the popup alert. The alert has no problem showing the french message. The problem is on the server side. It is sending english regardless of what the user's currently selected locale is. I can create a jira report on that and find some time to fix it. In my opinion, an alert is more appropriate as it is a session wide phenomena that needs to be handled immediately. Hence a modal alert, front and center, seem more appropriate. Nevertheless, whatever you decide is good.

        Point#3:

        Regarding the double spinner image, you can see it in https://demo-trunk.ofbiz.apache.org:8443/catalog/control/EditProduct?productId=GZ-1000 and click on the appropriate button to see the double spinner image.

        Again, "ofbiz-4813patch" already contained this change but was not committed. "ofbiz-4813-additional.patch" was provided to address that.

        Thanks,
        Wai

        Show
        Wai added a comment - - edited Jacques, Point#1: Regarding Tomahawk spinner image. You need to modify themes/tomahawk/webapp/tomahawk/css/style.css with the following changes specified in the patch "ofbiz-4813-additional.patch". If not, the spinner.gif inside the themes subdirectory would be used. That's why the #wait-spinner-image style specifies /images/spinner.gif as the target image to use and not /tomahawk/images/spinner.gif. To be consistent, all themes use /images/spinner.gif as the spinner image. #wait-spinner-image { height:45px; width:45px; background-repeat: no-repeat; background-image:url(/images/spinner.gif); } Note: The previous patch "ofbiz-4813patch" already contained the changes to the css files. I do not know why it was not committed with the rest of the code changes? "ofbiz-4813-additional.patch" was provided to address that. Point#2: Regarding i18n issue for the popup alert. The alert has no problem showing the french message. The problem is on the server side. It is sending english regardless of what the user's currently selected locale is. I can create a jira report on that and find some time to fix it. In my opinion, an alert is more appropriate as it is a session wide phenomena that needs to be handled immediately. Hence a modal alert, front and center, seem more appropriate. Nevertheless, whatever you decide is good. Point#3: Regarding the double spinner image, you can see it in https://demo-trunk.ofbiz.apache.org:8443/catalog/control/EditProduct?productId=GZ-1000 and click on the appropriate button to see the double spinner image. Again, "ofbiz-4813patch" already contained this change but was not committed. "ofbiz-4813-additional.patch" was provided to address that. Thanks, Wai
        Hide
        Wai added a comment -

        One more thing. To see the double spinner image, you need to select any theme other than tomahawk. At least until the patch as been committed.
        Thanks,
        Wai

        Show
        Wai added a comment - One more thing. To see the double spinner image, you need to select any theme other than tomahawk. At least until the patch as been committed. Thanks, Wai
        Hide
        Jacques Le Roux added a comment -

        Wai,

        Of course this was after applying the additional patch

        1. So I have this change in the css, else I'd not speak about it as an issue
        2. It's clearly showing the French message and accents are not handled. I quickly tried some workaounds and gave up. Accents are handled when the message is shown in the layered popup, that's why I did not want to waste too much time on it. In the popup is ok with me, not need for an alert box
        3. Seems that it depends on theme, I did not see it with Tomahawk but yes with others it shows
        Show
        Jacques Le Roux added a comment - Wai, Of course this was after applying the additional patch So I have this change in the css, else I'd not speak about it as an issue It's clearly showing the French message and accents are not handled. I quickly tried some workaounds and gave up. Accents are handled when the message is shown in the layered popup, that's why I did not want to waste too much time on it. In the popup is ok with me, not need for an alert box Seems that it depends on theme, I did not see it with Tomahawk but yes with others it shows
        Hide
        Jacques Le Roux added a comment -

        Of course, for the point 1, I removed the spinner from Tomahawk and it does not show, at least here...

        Show
        Jacques Le Roux added a comment - Of course, for the point 1, I removed the spinner from Tomahawk and it does not show, at least here...
        Hide
        Jacques Le Roux added a comment -

        Oops, sorry I checked you are right for the Tomahawk spinner. I got conflict with your additional patch (certainly some hunk where already in) somehow I did not spot I had still

        background-image:url(/tomahawk/images/spinner.gif);

        One worry less

        Show
        Jacques Le Roux added a comment - Oops, sorry I checked you are right for the Tomahawk spinner. I got conflict with your additional patch (certainly some hunk where already in) somehow I did not spot I had still background-image:url(/tomahawk/images/spinner.gif); One worry less
        Hide
        Jacques Le Roux added a comment -

        Hi Wai,

        At r1328738, I have applied your patch in trunk but commented out the lines

        //default ajax request timeout in milliseconds
        var AJAX_REQUEST_TIMEOUT = 5000;
        ...
        
                                //search for <span style="message...> returned from server
                                var matchFound = data.toString().match(AJAX_SERVER_REPLY_MSG_REGEXPATTERN);
                                if (matchFound != null) {
                                    alert(matchFound[1].trim());
                                    response(null);
                                    return;
                                }
        

        This because:

        1. I don't see any reasons to show the error message in an alert box rather than in the layered popup
        2. In the alert box the special characters (French accents for instance) were not handled
        Show
        Jacques Le Roux added a comment - Hi Wai, At r1328738, I have applied your patch in trunk but commented out the lines // default ajax request timeout in milliseconds var AJAX_REQUEST_TIMEOUT = 5000; ... //search for <span style="message...> returned from server var matchFound = data.toString().match(AJAX_SERVER_REPLY_MSG_REGEXPATTERN); if (matchFound != null ) { alert(matchFound[1].trim()); response( null ); return ; } This because: I don't see any reasons to show the error message in an alert box rather than in the layered popup In the alert box the special characters (French accents for instance) were not handled
        Hide
        Jacques Le Roux added a comment -

        Missed a part in fieldlookup.js at r1328738, committed at r1328743

        Show
        Jacques Le Roux added a comment - Missed a part in fieldlookup.js at r1328738, committed at r1328743
        Hide
        Wai added a comment -

        Jacques,

        I did a quick check and discovered that even when I set the active locale to French ("fr") and waited for a session timeout, the error message was still in English. Could you kindly verify whether this is the case at your end?

        Thanks,
        Wai

        Show
        Wai added a comment - Jacques, I did a quick check and discovered that even when I set the active locale to French ("fr") and waited for a session timeout, the error message was still in English. Could you kindly verify whether this is the case at your end? Thanks, Wai
        Hide
        Jacques Le Roux added a comment -

        Wai,

        It works correctly here, I mean I see the French message. I guess it's then not related for this message to the choice in OFBiz, but the default locale. Not sure why though, because it's done from a screen, so should behave like the rest...

        Show
        Jacques Le Roux added a comment - Wai, It works correctly here, I mean I see the French message. I guess it's then not related for this message to the choice in OFBiz, but the default locale. Not sure why though, because it's done from a screen, so should behave like the rest...
        Hide
        yashwant dhakad added a comment -

        Jacques,
        I think this should be backported in Release 11.04 as it is a bug.

        Show
        yashwant dhakad added a comment - Jacques, I think this should be backported in Release 11.04 as it is a bug.
        Hide
        Jacques Le Roux added a comment -

        Hi Yashwant,

        See my comment above:

        I did not backport to release (would be only R11.04) because it's not really a bug but more an improvement.

        I will though retry, and see if I should...

        Show
        Jacques Le Roux added a comment - Hi Yashwant, See my comment above: I did not backport to release (would be only R11.04) because it's not really a bug but more an improvement. I will though retry, and see if I should...
        Hide
        Deepak Dixit added a comment -

        Jqcques,

        This is related to OFBIZ-4753, If we back-ported this then issue reported at OFBIZ-4753 should be resolved.

        Show
        Deepak Dixit added a comment - Jqcques, This is related to OFBIZ-4753 , If we back-ported this then issue reported at OFBIZ-4753 should be resolved.
        Hide
        Jacques Le Roux added a comment -

        Thanks Deepak,

        I will have a closer look...

        Show
        Jacques Le Roux added a comment - Thanks Deepak, I will have a closer look...
        Hide
        yashwant dhakad added a comment -

        Here is the path for release 11.04 branch, ofbiz-4813.patch was not applied on release branch.

        Show
        yashwant dhakad added a comment - Here is the path for release 11.04 branch, ofbiz-4813.patch was not applied on release branch.
        Hide
        Jacques Le Roux added a comment -

        Mmm, there are conflicts, will see later...

        Show
        Jacques Le Roux added a comment - Mmm, there are conflicts, will see later...
        Hide
        Jacques Le Roux added a comment -

        Ha sorry Yashwant, missed your patch (actually I saw it 1st time and did not find it afterward so tried to backport)

        Show
        Jacques Le Roux added a comment - Ha sorry Yashwant, missed your patch (actually I saw it 1st time and did not find it afterward so tried to backport)
        Hide
        Jacques Le Roux added a comment - - edited

        Thanks Yashwant,

        ==== EDIT : forgot the revision number ===========
        Your A modified patch is in R11.04 at r1332358

        What I changed:

        • Added <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> in htmlheader-for-ajax.ftl
        • Added a French label an kept those existing but English (improved now)
        • Removed some added parts in patch of fieldlookup.js and selectall.js (like I did in trunk, those related to AJAX_SERVER_REPLY_MSG_REGEXPATTERN, because of not handled UTF8 chars in alert box)
        • Added the new spinner.gif and replaced /tomahawk/images/spinner.gif to /images/spinner.gif in tomahawk/css/style.css

        I just found another weird behaviour/bug (also in trunk) and I guess specifically related to these changes. If just after using the layered lookup you disconnect by opening another browser tab and change the languague on the tab you just clicked (it's still possible either on this tab or on the new one with the login screen), then you get a blank page with only the CommonSessionTimeoutPleaseLogIn on screen and you are stuck unless you use the browser back button. I guess since the back button allows you to get out of this dead end situation it's ok, but still weird...

        Show
        Jacques Le Roux added a comment - - edited Thanks Yashwant, ==== EDIT : forgot the revision number =========== Your A modified patch is in R11.04 at r1332358 What I changed: Added <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> in htmlheader-for-ajax.ftl Added a French label an kept those existing but English (improved now) Removed some added parts in patch of fieldlookup.js and selectall.js (like I did in trunk, those related to AJAX_SERVER_REPLY_MSG_REGEXPATTERN, because of not handled UTF8 chars in alert box) Added the new spinner.gif and replaced /tomahawk/images/spinner.gif to /images/spinner.gif in tomahawk/css/style.css I just found another weird behaviour/bug (also in trunk) and I guess specifically related to these changes. If just after using the layered lookup you disconnect by opening another browser tab and change the languague on the tab you just clicked (it's still possible either on this tab or on the new one with the login screen), then you get a blank page with only the CommonSessionTimeoutPleaseLogIn on screen and you are stuck unless you use the browser back button. I guess since the back button allows you to get out of this dead end situation it's ok, but still weird...
        Hide
        yashwant dhakad added a comment -

        Thanks Jacques.

        Show
        yashwant dhakad added a comment - Thanks Jacques.
        Hide
        Amardeep Singh Jhajj added a comment -

        Jacques,

        I found the small bug that when ajax request is aborted in autocompleter, the alert box is opened with message - An error occurred while communicating with the server:

        reason=abort

        exception=abort.

        Hence, I have added a check to handle ajax abort exception in such case. I have attached the patch for R11.04 and trunk(same can be applied to R12.04).

        Show
        Amardeep Singh Jhajj added a comment - Jacques, I found the small bug that when ajax request is aborted in autocompleter, the alert box is opened with message - An error occurred while communicating with the server: reason=abort exception=abort. Hence, I have added a check to handle ajax abort exception in such case. I have attached the patch for R11.04 and trunk(same can be applied to R12.04).
        Hide
        Jacques Le Roux added a comment -

        Thanks Amardeep,

        Your patch is in
        trunk r1338065
        R12.04 r1338071
        R11.04 r1338072

        I actually created another Jira issue for that OFBIZ-4867, not a problem I will close it now.
        Also most of the time, especially with small bug fixes, no needs to provide a patch for each realease branches, the tools/mergefromtrunk scripts allow us to apply them automatically

        Show
        Jacques Le Roux added a comment - Thanks Amardeep, Your patch is in trunk r1338065 R12.04 r1338071 R11.04 r1338072 I actually created another Jira issue for that OFBIZ-4867 , not a problem I will close it now. Also most of the time, especially with small bug fixes, no needs to provide a patch for each realease branches, the tools/mergefromtrunk scripts allow us to apply them automatically
        Hide
        Jacques Le Roux added a comment -

        Amardeep's patch was completed in
        trunk r1338101
        R12.04 r1338109
        R11.04 r1338110

        Show
        Jacques Le Roux added a comment - Amardeep's patch was completed in trunk r1338101 R12.04 r1338109 R11.04 r1338110
        Hide
        Amardeep Singh Jhajj added a comment -

        Thanks Jacques.

        Show
        Amardeep Singh Jhajj added a comment - Thanks Jacques.

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Wai
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development