Details

      Description

      The idea is to create an ant task which uses YUICompressor to dynamically minify our own (or custom for users) js and css files (most of the bigest external ones are already compressed)

        Activity

        Hide
        Jacques Le Roux added a comment -

        We commit only bug fixes in releases

        Show
        Jacques Le Roux added a comment - We commit only bug fixes in releases
        Hide
        Jacques Le Roux added a comment -

        You are missing a point Mandeep.

        OFBiz is already compressing text files. This is done through the embedded Tomcat. See in ofbiz-containers.xml

        <property name="compressableMimeType" value="text/html,text/xml,text/plain"/>
        <property name="compression" value="on"/>
        

        Reference: http://tomcat.apache.org/tomcat-7.0-doc/config/http.html

        So my proposition was only to add an yui-compressor-ant-task to compress those files as described here http://developer.yahoo.com/yui/compressor/

        Show
        Jacques Le Roux added a comment - You are missing a point Mandeep. OFBiz is already compressing text files. This is done through the embedded Tomcat. See in ofbiz-containers.xml <property name= "compressableMimeType" value= "text/html,text/xml,text/plain" /> <property name= "compression" value= "on" /> Reference: http://tomcat.apache.org/tomcat-7.0-doc/config/http.html So my proposition was only to add an yui-compressor-ant-task to compress those files as described here http://developer.yahoo.com/yui/compressor/
        Hide
        Jacques Le Roux added a comment -

        Note that for bigest files we already use compressed versions (ending by min.js, see framework/common/widget/CommonScreens.xml)

        Show
        Jacques Le Roux added a comment - Note that for bigest files we already use compressed versions (ending by min.js, see framework/common/widget/CommonScreens.xml)
        Hide
        Jacques Le Roux added a comment -

        and specialpurpose/ecommerce/widget/CommonScreens.xml

        Show
        Jacques Le Roux added a comment - and specialpurpose/ecommerce/widget/CommonScreens.xml
        Hide
        Jacques Le Roux added a comment -

        I changed the description and removed the estimate

        Show
        Jacques Le Roux added a comment - I changed the description and removed the estimate
        Hide
        Jacques Le Roux added a comment -

        Fixes typos in description

        Show
        Jacques Le Roux added a comment - Fixes typos in description
        Hide
        Jacques Le Roux added a comment -

        Changes description to refer to http://developer.yahoo.com/yui/compressor/ directly rather

        Show
        Jacques Le Roux added a comment - Changes description to refer to http://developer.yahoo.com/yui/compressor/ directly rather
        Hide
        Jacques Le Roux added a comment -

        Commited initial work at revision: 1310983

        Show
        Jacques Le Roux added a comment - Commited initial work at revision: 1310983
        Hide
        Mandeep Sidhu added a comment -

        my bad, I am just being ignorant here, I was looking at the response header, my bad, it's working perfectly fine.
        apologies

        Show
        Mandeep Sidhu added a comment - my bad, I am just being ignorant here, I was looking at the response header, my bad, it's working perfectly fine. apologies
        Hide
        Jacques Le Roux added a comment -

        I think it's enough OOTB. Now users will have to care in production...

        Show
        Jacques Le Roux added a comment - I think it's enough OOTB. Now users will have to care in production...
        Hide
        Jacques Le Roux added a comment -

        I reopen it for 2 reasons:

        • I missed to put in LICENSE and NOTICE
        • It's an issue for Birt, see OFBIZ-5070
        Show
        Jacques Le Roux added a comment - I reopen it for 2 reasons: I missed to put in LICENSE and NOTICE It's an issue for Birt, see OFBIZ-5070
        Hide
        Jacques Le Roux added a comment -

        Reverted at revision: 1416358

        Show
        Jacques Le Roux added a comment - Reverted at revision: 1416358

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Mandeep Sidhu
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development