OFBiz
  1. OFBiz
  2. OFBIZ-4784

storeIncomingEmail assumes variable is not null when it might be

    Details

      Description

      In storeIncomingEmail in CommunicationEventServices.java, the code to assemble the aboutThisEmail debugging message assumes addressesFrom and addressesTo are not null. But the methods that return values for those variables might return null if they encounter an exception.

      I have also removed uses of UtilValidate.isEmpty, which should only be used for collections and sequences (see OFBIZ-4427).

        Activity

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to https://fisheye6.atlassian.com/ failed: Error in remote call to 'FishEye 0 (https://fisheye6.atlassian.com/)' (https://fisheye6.atlassian.com) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=OFBIZ-4784, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Failed to parse FishEye response: Error on line 11 of document : An invalid XML character (Unicode: 0x1a) was found in the element content of the document. Nested exception: An invalid XML character (Unicode: 0x1a) was found in the element content of the document.
        Jacques Le Roux made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Jacques Le Roux [ jacques.le.roux ]
        Fix Version/s Release Branch 10.04 [ 12314832 ]
        Fix Version/s Release Branch 11.04 [ 12316420 ]
        Fix Version/s SVN trunk [ 12311928 ]
        Resolution Fixed [ 1 ]
        Hide
        Jacques Le Roux added a comment -

        Thanks Paul,

        Your patch is in
        trunk r1309715
        R11.04 r1309717
        R10.04 r1309718

        Show
        Jacques Le Roux added a comment - Thanks Paul, Your patch is in trunk r1309715 R11.04 r1309717 R10.04 r1309718
        Paul Foxworthy made changes -
        Field Original Value New Value
        Attachment OFBIZ-4784_CommunicationEventServices.patch [ 12521470 ]
        Paul Foxworthy created issue -

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Paul Foxworthy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development