Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: themes
    • Labels:
      None

      Description

      Improvement to flatgrey theme.

      1. ofbiz-style2.patch
        66 kB
        Wai
      2. ofbiz-style2.patch
        16 kB
        Wai
      3. ofbiz-style1.patch
        66 kB
        Wai
      4. ofbiz-style1.patch
        16 kB
        Wai
      5. ofbiz-4768.patch
        69 kB
        Wai
      6. ofbiz-4768.patch
        69 kB
        Wai
      7. flatgray-images.tar.gz
        0.8 kB
        Wai
      8. before-sample-webtools.png
        170 kB
        Wai
      9. before-sample-partymgr.png
        202 kB
        Wai
      10. before-sample-catalogmgr2.png
        203 kB
        Wai
      11. before-sample-catalogmgr1.png
        199 kB
        Wai
      12. after-sample-webtools.png
        217 kB
        Wai
      13. after-sample-webtools.png
        196 kB
        Wai
      14. after-sample-partymgr.png
        198 kB
        Wai
      15. after-sample-partymgr.png
        212 kB
        Wai
      16. after-sample-catalogmgr2.png
        198 kB
        Wai
      17. after-sample-catalogmgr2.png
        193 kB
        Wai
      18. after-sample-catalogmgr1.png
        204 kB
        Wai
      19. after-sample-catalogmgr1.png
        222 kB
        Wai

        Activity

        Hide
        Wai added a comment -

        Instruction:
        o. apply the patch.
        o. unarchive flatgray-images.tar.gz and copy the image files to /ofbizdir/themes/flatgrey/webapp/flatgrey/images
        o. remove /ofbizdir/themes/flatgrey/webapp/flatgrey/images/bhead.gif

        Show
        Wai added a comment - Instruction: o. apply the patch. o. unarchive flatgray-images.tar.gz and copy the image files to /ofbizdir/themes/flatgrey/webapp/flatgrey/images o. remove /ofbizdir/themes/flatgrey/webapp/flatgrey/images/bhead.gif
        Hide
        Erwan de FERRIERES added a comment -

        Wai,

        could you be more specific on what your patch is doing, so without applying we know where to look ?

        Thanks

        Show
        Erwan de FERRIERES added a comment - Wai, could you be more specific on what your patch is doing, so without applying we know where to look ? Thanks
        Hide
        Wai added a comment -

        The patch is a general makeover for the flatgray theme to make it more modern-like and professional. It's pretty difficult to describe. Just apply the patch according to the instructions and take a look.

        Changes include:
        1. style and color adjustments to the menus and screenlet panels.

        Show
        Wai added a comment - The patch is a general makeover for the flatgray theme to make it more modern-like and professional. It's pretty difficult to describe. Just apply the patch according to the instructions and take a look. Changes include: 1. style and color adjustments to the menus and screenlet panels.
        Hide
        Pierre Smits added a comment -

        Wai,

        Could you try to provide some before and after screenshots regarding this patch, so it is easier to assess whether this is an enhancement. It seems that every component has been touched.

        Regards,

        Pierre

        Show
        Pierre Smits added a comment - Wai, Could you try to provide some before and after screenshots regarding this patch, so it is easier to assess whether this is an enhancement. It seems that every component has been touched. Regards, Pierre
        Hide
        Wai added a comment -

        These are some sample before/after shots of the CSS stylesheet change.

        Please take note that this is only a stylesheet change and affects the look of screens. It does not affect the functionality of ofbiz in any way.

        Thanks

        Show
        Wai added a comment - These are some sample before/after shots of the CSS stylesheet change. Please take note that this is only a stylesheet change and affects the look of screens. It does not affect the functionality of ofbiz in any way. Thanks
        Hide
        Pierre Smits added a comment -

        Looking at the before and after shots of partymanager it seems to me that this patch makes it harder on the eyes.
        The menu's within the applications look more condensed and where the current trunk version is softer regarding contrasting between menubars and other regions the patch delivers more (thus harder) contrasting.

        Show
        Pierre Smits added a comment - Looking at the before and after shots of partymanager it seems to me that this patch makes it harder on the eyes. The menu's within the applications look more condensed and where the current trunk version is softer regarding contrasting between menubars and other regions the patch delivers more (thus harder) contrasting.
        Hide
        Erwan de FERRIERES added a comment -

        Hi Wai,

        this sure needs a discussion before integration.

        Show
        Erwan de FERRIERES added a comment - Hi Wai, this sure needs a discussion before integration.
        Hide
        Jacques Le Roux added a comment -

        I will try to have a look...

        Show
        Jacques Le Roux added a comment - I will try to have a look...
        Hide
        Wai added a comment -

        This new patch integrates Pierre Smits' critique about the layout being too condensed and straining on the eyes.

        The changes include:
        1. The menus are more spread out
        2. contrast of text and background is increased on screenlets title bar
        3. title bar thickened
        4. some buttons enlarged

        It should be noted that the previous screenshots were taken with firefox zooming out by 3 steps to try to show as much of the page as possible. This could have accentuated the condensed looked of the page.

        The current screenshots are in normal size.

        Show
        Wai added a comment - This new patch integrates Pierre Smits' critique about the layout being too condensed and straining on the eyes. The changes include: 1. The menus are more spread out 2. contrast of text and background is increased on screenlets title bar 3. title bar thickened 4. some buttons enlarged It should be noted that the previous screenshots were taken with firefox zooming out by 3 steps to try to show as much of the page as possible. This could have accentuated the condensed looked of the page. The current screenshots are in normal size.
        Hide
        Adrian Crum added a comment -

        Visual theme "improvements" can be very subjective - everyone has their own opinion of what looks "good".

        One theme improvement that I would like to see (that is easily quantified) is adding a collapsible masthead - where clicking a collapse button hides the main navigation bar.

        Show
        Adrian Crum added a comment - Visual theme "improvements" can be very subjective - everyone has their own opinion of what looks "good". One theme improvement that I would like to see (that is easily quantified) is adding a collapsible masthead - where clicking a collapse button hides the main navigation bar.
        Hide
        Jacques Le Roux added a comment -

        One thing I prefer in other themes is their dropdown menus (I already argued about it: why papernews have columns). But I must say that with the OFBiz slim down it will be at least easier to search for an Application (notably because OOTB they are only alphabetically ordered in English)

        Show
        Jacques Le Roux added a comment - One thing I prefer in other themes is their dropdown menus (I already argued about it: why papernews have columns). But I must say that with the OFBiz slim down it will be at least easier to search for an Application (notably because OOTB they are only alphabetically ordered in English)
        Hide
        Pierre Smits added a comment -

        I agree with you all in that the appeal of a theme is subject to taste. And every backend theme has its pros and cons.

        I would rather see that the theme in eCommerce would be enhanced. So that it not only can be a showcase for it's functionalities but also regarding 'look and feel'.

        Show
        Pierre Smits added a comment - I agree with you all in that the appeal of a theme is subject to taste. And every backend theme has its pros and cons. I would rather see that the theme in eCommerce would be enhanced. So that it not only can be a showcase for it's functionalities but also regarding 'look and feel'.
        Hide
        Wai added a comment -

        I agree with Adrian that the visual presentation is highly subjective. The intent of this enhancement was to create a direct swap-in stylesheet that changes the "look" of the flatgray theme without changes to any code. This way, the css stylesheet can replace the existing one with confidence that no ofbiz functionality be put at risk. This would also give committers confidence that nothing will break by adding this to the repository.

        I'm assuming that people choose to use flatgray for its simplicity. Hence, I purposely choose not to add any functionality that was not already present in the flatgray theme.

        If more client side enhancements are required, I would suggest creating another theme altogether.

        Show
        Wai added a comment - I agree with Adrian that the visual presentation is highly subjective. The intent of this enhancement was to create a direct swap-in stylesheet that changes the "look" of the flatgray theme without changes to any code. This way, the css stylesheet can replace the existing one with confidence that no ofbiz functionality be put at risk. This would also give committers confidence that nothing will break by adding this to the repository. I'm assuming that people choose to use flatgray for its simplicity. Hence, I purposely choose not to add any functionality that was not already present in the flatgray theme. If more client side enhancements are required, I would suggest creating another theme altogether.
        Hide
        Jacques Le Roux added a comment -

        From screenshots, I'm not quite sure I prefer the new version. I find it a bit more legible but this could be due to the way screenshots were taken. I will apply and see by myself...

        Show
        Jacques Le Roux added a comment - From screenshots, I'm not quite sure I prefer the new version. I find it a bit more legible but this could be due to the way screenshots were taken. I will apply and see by myself...
        Hide
        Jacques Le Roux added a comment -

        I must admit it's really a matter of taste because the variations are very slight. For instance I prefer the button in the menu bar in Wai's proposition but not the font used for the text in normal buttons.

        Also an advantage of Wai's proposition is it's very condensed. So you see more of a screen but on the other hand I feel a little stress in the eyes.

        I suggest to keep the current theme and to add this new version under Extras when the themes will be moved there...

        Show
        Jacques Le Roux added a comment - I must admit it's really a matter of taste because the variations are very slight. For instance I prefer the button in the menu bar in Wai's proposition but not the font used for the text in normal buttons. Also an advantage of Wai's proposition is it's very condensed. So you see more of a screen but on the other hand I feel a little stress in the eyes. I suggest to keep the current theme and to add this new version under Extras when the themes will be moved there...
        Hide
        Wai added a comment -

        The 2 patches represent the 2 styles that had be uploaded previously. The only difference is that it has no dependency on additional image files.

        Note that bhead.gif still needs to be removed as it serves no purpose.

        Show
        Wai added a comment - The 2 patches represent the 2 styles that had be uploaded previously. The only difference is that it has no dependency on additional image files. Note that bhead.gif still needs to be removed as it serves no purpose.
        Hide
        Wai added a comment -

        Hello Committers,

        Is this enhancement going into the repository?

        Thanks,
        Wai

        Show
        Wai added a comment - Hello Committers, Is this enhancement going into the repository? Thanks, Wai
        Hide
        Jacques Le Roux added a comment -

        I'd recommned Extra as a complete Flat Grey theme variation rather

        Show
        Jacques Le Roux added a comment - I'd recommned Extra as a complete Flat Grey theme variation rather
        Hide
        Pierre Smits added a comment -

        Wai,

        Unfortunately I see no added value in implementing these changes to the trunk version of the Flatgrey theme. I agree with Jacques that it is something for Extra as there is a marketspace for every niche product. And out there, there definitely will be persons who appreciate your vision.

        My advice to you: make it a complete theme (not just the modifications), document well and post the total package on Extra.

        Regards,

        Pierre

        Show
        Pierre Smits added a comment - Wai, Unfortunately I see no added value in implementing these changes to the trunk version of the Flatgrey theme. I agree with Jacques that it is something for Extra as there is a marketspace for every niche product. And out there, there definitely will be persons who appreciate your vision. My advice to you: make it a complete theme (not just the modifications), document well and post the total package on Extra. Regards, Pierre
        Hide
        Wai added a comment -

        Hello Committer(s),

        As of the recent previous comments. I'm left with an assumption that either the improvement offers absolutely no value to the project or that the risk of integrating the change compared to the benefit obtained would be too great.

        If my understanding that the change offers no value because the styling is disagreeable. I'll abide by the committer's decision and I'll close this issue.

        If the reason for the decision is based on previous patches containing too many changes such that it rendered using 'diff' incomprehensible. It was a shortsightedness on my part due to formatting the files. I have thus included the 2 patches without the file formatting and I hope that the committer(s) can see the actual changes to the original file and would reconsider.

        Either way, I'll abide by your final decision.

        Thanks for your consideration.
        Wai

        Show
        Wai added a comment - Hello Committer(s), As of the recent previous comments. I'm left with an assumption that either the improvement offers absolutely no value to the project or that the risk of integrating the change compared to the benefit obtained would be too great. If my understanding that the change offers no value because the styling is disagreeable. I'll abide by the committer's decision and I'll close this issue. If the reason for the decision is based on previous patches containing too many changes such that it rendered using 'diff' incomprehensible. It was a shortsightedness on my part due to formatting the files. I have thus included the 2 patches without the file formatting and I hope that the committer(s) can see the actual changes to the original file and would reconsider. Either way, I'll abide by your final decision. Thanks for your consideration. Wai
        Hide
        Pierre Smits added a comment -

        Wai,

        Worry not. Acceptance of changes in themes (unless it are bug fixes) is highly determined by the likability or wow factor and personal taste. That your changes didn't make it into the trunk has to do with that. Not with the amount of iterations it went through to get it right. We all have been through that when we started with submitting patches. It is the latest patch provided that is important, right...

        Just communicate your patch on the user ML and see if people adopt it.

        Regards,

        Pierre

        Show
        Pierre Smits added a comment - Wai, Worry not. Acceptance of changes in themes (unless it are bug fixes) is highly determined by the likability or wow factor and personal taste. That your changes didn't make it into the trunk has to do with that. Not with the amount of iterations it went through to get it right. We all have been through that when we started with submitting patches. It is the latest patch provided that is important, right... Just communicate your patch on the user ML and see if people adopt it. Regards, Pierre
        Hide
        Olivier Heintz added a comment -

        Wai,

        I have used this Jira and its patch to create two addon on ofbizextra-addons-dev

        • flatgrey-update2variation : apply your patch to the flatgrey theme
        • theme-flatgreyvariation : add a new theme "flatgreyvariation" which is the flatgrey theme with your patch applied.

        regards,
        Olivier

        Show
        Olivier Heintz added a comment - Wai, I have used this Jira and its patch to create two addon on ofbizextra-addons-dev flatgrey-update2variation : apply your patch to the flatgrey theme theme-flatgreyvariation : add a new theme "flatgreyvariation" which is the flatgrey theme with your patch applied. regards, Olivier

          People

          • Assignee:
            Unassigned
            Reporter:
            Wai
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development