[OFBIZ-4766] PriceRule applies action to wrong priceType

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: Release Branch 10.04, Release Branch 11.04, Trunk
• Component/s: product
• Labels: PRICE_POD ProductPriceAction ProductPriceRule
• Assignee: Jacques Le Roux
• Reporter: Sebastian Leitner
• Created: 28/Mar/12 16:09
• Updated: 01/Apr/12 10:37
• Resolved: 01/Apr/12 10:37

Description

If you create a PriceRule and add an action of type "PRICE_POD" (Percent of default price) I read this as:
"take the default price and give an amount of x% to that"

These rules are applied within the service "calculateProductPrice" (specifically in PriceServices.calcPriceResultFromRules). It calculates the amount of discount using the default price (as specified by the action of the rule). But then it adds this discount to the listPrice instead of the defaultPrice.

An example:
listPrice = 100,
defaultPrice = 10,
rule says you give 10% of defaultPrice,
modifyAmount = -1 (this is the correct discount amount)
result would be 100-1 = 99.

I consider this to be a bug, not some sort of easter-egg feature
I will attach a patch for this.