[OFBIZ-4720] getAdjustmentPromoIndex(String productPromoId) in ShoppingCart.java

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: Release Branch 11.04, Trunk
• Assignee: Jacques Le Roux
• Reporter: Shi Jinghai
• Created: 27/Feb/12 13:13
• Updated: 04/Mar/12 21:15
• Resolved: 04/Mar/12 21:15

Description

Currently this method throws an out of range index exception.

Original:
public int getAdjustmentPromoIndex(String productPromoId) {
int index = adjustments.size();
while (index > 0) {
if (adjustments.get(index).getString("productPromoId").equals(productPromoId))

{ return(index); }
index++;
}
return -1;
}

Change to:
public int getAdjustmentPromoIndex(String productPromoId) {
int index = adjustments.size();
while (index > 0) {
index--;
if (adjustments.get(index).getString("productPromoId").equals(productPromoId)) { return(index); }

}
return -1;
}