OFBiz
  1. OFBiz
  2. OFBIZ-4690

If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: Release 10.04, Release Branch 11.04, SVN trunk
    • Fix Version/s: SVN trunk
    • Component/s: None
    • Labels:
      None

      Description

      If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

        Activity

        Ankit Jain created issue -
        Ankit Jain made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Ankit Jain added a comment -

        The attached patch will fix this issue.

        Show
        Ankit Jain added a comment - The attached patch will fix this issue.
        Ankit Jain made changes -
        Attachment OFBIZ-4690.patch [ 12514339 ]
        Jacques Le Roux made changes -
        Assignee Jacques Le Roux [ jacques.le.roux ]
        Hide
        Jacques Le Roux added a comment -

        Hi Ankit,

        I was wondering because OOTB the only place where a picklist is cancelled is in checkPicklistBinItemStatuses and it's done the reversed way you proposed (ie only cancel the picklist if all picklist items are cancelled). So, at least OOTB, this new ECA should never be fired. Do you think about some other processes you crossed?

        Show
        Jacques Le Roux added a comment - Hi Ankit, I was wondering because OOTB the only place where a picklist is cancelled is in checkPicklistBinItemStatuses and it's done the reversed way you proposed (ie only cancel the picklist if all picklist items are cancelled). So, at least OOTB, this new ECA should never be fired. Do you think about some other processes you crossed?
        Hide
        Ankit Jain added a comment -

        Hi Jacques,

        Thanks to look into it.

        If we cancel a picklist from Manage Picklist screen then this ECA will fire and cancel all the PicklistItem.

        Show
        Ankit Jain added a comment - Hi Jacques, Thanks to look into it. If we cancel a picklist from Manage Picklist screen then this ECA will fire and cancel all the PicklistItem.
        Jan le Roux committed 1290890 (3 files)
        Reviews: none

        A patch from Ankit Jain "If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel." https://issues.apache.org/jira/browse/OFBIZ-4690

        If we cancel a picklist from Manage Picklist screen then this ECA will fire and cancel all the PicklistItem.

        Hide
        Jacques Le Roux added a comment -

        Thanks Ankit,

        As this is an improvement, I did not backport in releases.

        Your patch is in trunk at revision: 1290890

        Show
        Jacques Le Roux added a comment - Thanks Ankit, As this is an improvement, I did not backport in releases. Your patch is in trunk at revision: 1290890
        Jacques Le Roux made changes -
        Status Patch Available [ 10002 ] Closed [ 6 ]
        Fix Version/s Release Branch 10.04 [ 12314832 ]
        Fix Version/s Release Branch 11.04 [ 12316420 ]
        Resolution Fixed [ 1 ]
        Hide
        Ankit Jain added a comment -

        Thanks Jacques.

        Show
        Ankit Jain added a comment - Thanks Jacques.

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Ankit Jain
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development