Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-4690

If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: Release 10.04, Release Branch 11.04, Trunk
        • Fix Version/s: Trunk
        • Component/s: None
        • Labels:
          None

          Description

          If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            ankit.jain Ankit Jain added a comment -

            The attached patch will fix this issue.

            Show
            ankit.jain Ankit Jain added a comment - The attached patch will fix this issue.
            Hide
            Permalink
            jacques.le.roux Jacques Le Roux added a comment -

            Hi Ankit,

            I was wondering because OOTB the only place where a picklist is cancelled is in checkPicklistBinItemStatuses and it's done the reversed way you proposed (ie only cancel the picklist if all picklist items are cancelled). So, at least OOTB, this new ECA should never be fired. Do you think about some other processes you crossed?

            Show
            jacques.le.roux Jacques Le Roux added a comment - Hi Ankit, I was wondering because OOTB the only place where a picklist is cancelled is in checkPicklistBinItemStatuses and it's done the reversed way you proposed (ie only cancel the picklist if all picklist items are cancelled). So, at least OOTB, this new ECA should never be fired. Do you think about some other processes you crossed?
            Hide
            Permalink
            ankit.jain Ankit Jain added a comment -

            Hi Jacques,

            Thanks to look into it.

            If we cancel a picklist from Manage Picklist screen then this ECA will fire and cancel all the PicklistItem.

            Show
            ankit.jain Ankit Jain added a comment - Hi Jacques, Thanks to look into it. If we cancel a picklist from Manage Picklist screen then this ECA will fire and cancel all the PicklistItem.
            Hide
            Permalink
            jacques.le.roux Jacques Le Roux added a comment -

            Thanks Ankit,

            As this is an improvement, I did not backport in releases.

            Your patch is in trunk at revision: 1290890

            Show
            jacques.le.roux Jacques Le Roux added a comment - Thanks Ankit, As this is an improvement, I did not backport in releases. Your patch is in trunk at revision: 1290890
            Hide
            Permalink
            ankit.jain Ankit Jain added a comment -

            Thanks Jacques.

            Show
            ankit.jain Ankit Jain added a comment - Thanks Jacques.

              People

              • Assignee:
                jacques.le.roux Jacques Le Roux
                Reporter:
                ankit.jain Ankit Jain
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development