[OFBIZ-4657] ArrayIndexOutOfBoundsException in OrderServices.xml:updateOrderItemShipGroup

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: Trunk
• Component/s: order
• Assignee: Jacques Le Roux
• Reporter: Alexander Reelsen
• Created: 12/Jan/12 16:13
• Updated: 16/May/12 23:35
• Resolved: 15/Apr/12 12:37

Description

When changing the billing or shipping address of a sales order in the ordermgr, a bsh exception is logged - with absolutely no trace where it is coming from. And the change of the adress is successful as well.

The exception occurs here in OrderServices.xml in updateOrderItemShipGroup() in the BSH script

<call-bsh><![CDATA[
shipmentMethod = parameters.get("shipmentMethod");
if (shipmentMethod != null)

{ arr = shipmentMethod.split( "@" ); parameters.put("shipmentMethodTypeId", arr[0]); parameters.put("carrierPartyId", arr[1]); parameters.put("carrierRoleTypeId", arr[2]); }

]]></call-bsh>

Splitting for not existing chars and assuming the array was split successfully leads to the exception. The fix could work liks this, but as I do not have a clue at all, why it is split by the at-sign anyway I dont know if this fix does what it should. For us it does, because we do not care for sales order ship groups.

<call-bsh><![CDATA[
shipmentMethod = parameters.get("shipmentMethod");
if (shipmentMethod != null) {
arr = shipmentMethod.split( "@" );
if (arr.length >= 3)

{ parameters.put("shipmentMethodTypeId", arr[0]); parameters.put("carrierPartyId", arr[1]); parameters.put("carrierRoleTypeId", arr[2]); }

}
]]></call-bsh>

Issue Links

• duplicates: OFBIZ-4865 Exception there when trying to update order's "Shipping Destination Address"