OFBiz
  1. OFBiz
  2. OFBIZ-4629

The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.

    Details

      Description

      Whenever a order is verified picked the status of Picklistitem never changes to "PICKITEM_COMPLETED", even if the order is completed the status always remain as "PICKITEM_PENDING". I think when a PiclistItem is verified the status should change to "PICKITEM_COMPLETED".

      1. Updated-Ofbiz-4629.patch
        0.8 kB
        Ankit Jain
      2. OFBIZ-4629.patch
        2 kB
        Ankit Jain

        Activity

        Hide
        Ankit Jain added a comment -

        Attached patch fix the issue.

        Show
        Ankit Jain added a comment - Attached patch fix the issue.
        Hide
        Jacques Le Roux added a comment -

        Hi Ankit,

        It seems to me that this is already done in methods PackingSessionLine.issueItemToShipment, and VerifyPickSessionRow.issueItemToShipment, which makes sense to me, thought I did only a 5 mins review, so I could be wrong, could you please check?

        Show
        Jacques Le Roux added a comment - Hi Ankit, It seems to me that this is already done in methods PackingSessionLine.issueItemToShipment, and VerifyPickSessionRow.issueItemToShipment, which makes sense to me, thought I did only a 5 mins review, so I could be wrong, could you please check?
        Hide
        Ankit Jain added a comment -

        Thanks Jacques, for reviewing it.

        Yes I found the method VerifyPickSessionRow.issueItemToShipment which is doing the same thing.

        But I found a bug too and also the reason for it, actually when you verify an order by passing "PicklistBinId" then it updates the status of picklistitems, but if we verify an order by passing a orderId then the status of the picklistitem never changes to Complete.

        The reason is that when we pass orderId the "picklistBinId" is not get set in the verifyPickSession so its not available at the time "issueItemToShipment" is called so its not changing the status to complete.

        So I created a patch will will fix this issue.

        Show
        Ankit Jain added a comment - Thanks Jacques, for reviewing it. Yes I found the method VerifyPickSessionRow.issueItemToShipment which is doing the same thing. But I found a bug too and also the reason for it, actually when you verify an order by passing "PicklistBinId" then it updates the status of picklistitems, but if we verify an order by passing a orderId then the status of the picklistitem never changes to Complete. The reason is that when we pass orderId the "picklistBinId" is not get set in the verifyPickSession so its not available at the time "issueItemToShipment" is called so its not changing the status to complete. So I created a patch will will fix this issue.
        Hide
        Jacques Le Roux added a comment -

        Thanks Ankit,

        I will be away until Wednesday, I will then review your patches again

        Show
        Jacques Le Roux added a comment - Thanks Ankit, I will be away until Wednesday, I will then review your patches again
        Hide
        Jacques Le Roux added a comment -

        Thanks Ankit,

        Your patches are in
        trunk r1231444+1231445
        R11.04 r1231447+r1231450
        R10.04 r1231448+r1231451
        R09.04 r1231449 (the VerifyPickSession.java had too much conflicts)

        Show
        Jacques Le Roux added a comment - Thanks Ankit, Your patches are in trunk r1231444+1231445 R11.04 r1231447+r1231450 R10.04 r1231448+r1231451 R09.04 r1231449 (the VerifyPickSession.java had too much conflicts)
        Hide
        Jacques Le Roux added a comment -

        After a discussion with Ankit this morning, revert the 1st patch of https://issues.apache.org/jira/browse/OFBIZ-4629 "The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED."

        We agreed the change in VerifyPickSession.complete method was useless since it exists also in PackingSessionLine.issueItemToShipment and VerifyPickSessionRow.issueItemToShipment methods

        Reverted in revisions
        trunk 1231649
        R11.04 1231651
        R10.04 1231650

        Show
        Jacques Le Roux added a comment - After a discussion with Ankit this morning, revert the 1st patch of https://issues.apache.org/jira/browse/OFBIZ-4629 "The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED." We agreed the change in VerifyPickSession.complete method was useless since it exists also in PackingSessionLine.issueItemToShipment and VerifyPickSessionRow.issueItemToShipment methods Reverted in revisions trunk 1231649 R11.04 1231651 R10.04 1231650
        Hide
        Ankit Jain added a comment -

        Thanks Jacques.

        Show
        Ankit Jain added a comment - Thanks Jacques.

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Ankit Jain
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development