OFBiz
  1. OFBiz
  2. OFBIZ-4592

Try to see if we can integrate Commons-dbcp-jmx tool to monitor DBCP connections with JMX+JConsole

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Later
    • Affects Version/s: Trunk
    • Fix Version/s: None
    • Component/s: framework

      Activity

      Hide
      Jacques Le Roux added a comment -

      I prefer "later" status in such cases...

      Show
      Jacques Le Roux added a comment - I prefer "later" status in such cases...
      Hide
      Jacopo Cappellato added a comment -

      If you don't plan to do more work on this I would suggest to resolve this as "won't fix"; the code will still be here for anyone interested.

      Show
      Jacopo Cappellato added a comment - If you don't plan to do more work on this I would suggest to resolve this as "won't fix"; the code will still be here for anyone interested.
      Hide
      Jacques Le Roux added a comment -

      A non related change had slipped in previous patch

      Show
      Jacques Le Roux added a comment - A non related change had slipped in previous patch
      Hide
      Jacques Le Roux added a comment -

      Hi Markus,

      I had a quick look. It misses this imports

      import org.weakref.jmx.MBeanExporter;
      import org.weakref.jmx.Managed;

      I looked into the zip of https://github.com/nicoulaj/commons-dbcp-jmx and gave up. Here is attach an upated patch

      Anyway, I think I will more focus on bug fixes for a while...To be continued...

      Thanks for you effort!

      Show
      Jacques Le Roux added a comment - Hi Markus, I had a quick look. It misses this imports import org.weakref.jmx.MBeanExporter; import org.weakref.jmx.Managed; I looked into the zip of https://github.com/nicoulaj/commons-dbcp-jmx and gave up. Here is attach an upated patch Anyway, I think I will more focus on bug fixes for a while...To be continued... Thanks for you effort!
      Hide
      Markus M. May added a comment -

      Provide additional information on the MBean, like username and uri.

      Show
      Markus M. May added a comment - Provide additional information on the MBean, like username and uri.
      Hide
      Jacques Le Roux added a comment -

      Thanks Markus,

      I did not get a chance to look at it this week, but will hopefully do later...

      Show
      Jacques Le Roux added a comment - Thanks Markus, I did not get a chance to look at it this week, but will hopefully do later...
      Hide
      Markus M. May added a comment -

      Provide an initial patch for the integration of the JMX Reporting of DBCP.

      I hope that the format of the patch is now alright

      The patch adds a new target "download-commons-dbcp-jmx" to the build.xml to download the corresponding jars via ivy (ivy.xml is adopted to this as well).

      This is just an initial draft and it is working, but I guess there should be a slightly different implementation. The current implementation does not rely on the commons-dbcp-jmx stuff, but only on a couple of dependencies of this project.

      To gain more information about the connection, the JMX MBean should be able to gather also information about the connection because right now the information in the JConsole is pretty useless without knowing the connection url.

      Show
      Markus M. May added a comment - Provide an initial patch for the integration of the JMX Reporting of DBCP. I hope that the format of the patch is now alright The patch adds a new target "download-commons-dbcp-jmx" to the build.xml to download the corresponding jars via ivy (ivy.xml is adopted to this as well). This is just an initial draft and it is working, but I guess there should be a slightly different implementation. The current implementation does not rely on the commons-dbcp-jmx stuff, but only on a couple of dependencies of this project. To gain more information about the connection, the JMX MBean should be able to gather also information about the connection because right now the information in the JConsole is pretty useless without knowing the connection url.

        People

        • Assignee:
          Jacques Le Roux
          Reporter:
          Jacques Le Roux
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development