OFBiz
  1. OFBiz
  2. OFBIZ-4591

TLD is not loaded from CLASSPATH using Tomcat 7

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: SVN trunk
    • Fix Version/s: None
    • Component/s: framework
    • Labels:
    • Environment:

      Ubntu

      Description

      Hi community.
      I have a problem when I render a JSP page which is defined a taglib, for example:

      <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"%>

      The problem is TLD definition files are not loaded from CLASSPATH using Tomcat 7.
      To solve this problem we need to delete this line from CatalinaContainer.java file:

      standardJarScanner.setScanClassPath(false);

      because the standard jar scanner is set the default value as "true"

      After we have done above, we will get these problems.

      =========================================================
      1. JAR files are conflicted by different webapp contexts
      =========================================================

      The ScheduledExecutorService that submit all webapp contexts does not run them respectively. For example:

      Context(1)
      Context(2)
      Context(3)

      A particular context will read all JAR files from CLASSPATH. The problem is, for example, the Context(2) will start to read all JAR files even though the Context(1) does not finish its task yet. So the Context (2) will not be able to read some JAR file that the Context(1) is reading and causes an error.

      ===========================================================
      2. WebslingerAccessLogValve class does not support Tomcat 7
      ===========================================================

      If the jar scanner scan jar files from CLASSPATH, it will find WebslingerAccessLogValve class which does not support Tomcat 7

      =======================================================
      3. groovy.jmx.builder.package-info class cannot be loaded
      =======================================================

      groovy.jmx.builder.package-info class cannot be loaded because its name is incorrect. If I remove this class from framework/base/lib/scripting/groovy-all-1.7.7.jar file, this line in macros.xml will cause an error:

      <taskdef name="groovyc" classname="org.codehaus.groovy.ant.Groovyc" classpathref="groovy.class.path"/>

      ============================
      4. Starting time will slower
      ============================

      A particular webapp context will spend more time to parse JAR file from CLASSPATH to find TLD definition files.

      However I can avoid the TLD problem by copying JAR files that contain TLD definition files into /WEB-INF/lib directory of a particular webapp

      Lastly, I am not sure if we need this feature in the trunk but I think it is useful. If so, please help me to solve the problems.

      Regards,
      Chatree Srichart

      1. EnableJarScanner.patch
        0.8 kB
        Chatree Srichart

        Activity

        Hide
        Jacques Le Roux added a comment -

        Doest this pb still exist?

        Show
        Jacques Le Roux added a comment - Doest this pb still exist?
        Hide
        Chatree Srichart added a comment -

        Yes, it does. I attach a patch file to enable JAR Scanner for a webapp context. Unfortunately, when I applied this patch I still get an error. For example:

        SEVERE: Error processing TLD files for context with name [/myportal]
        java.lang.IllegalStateException: zip file closed
        at java.util.zip.ZipFile.ensureOpen(ZipFile.java:632)
        at java.util.zip.ZipFile.access$200(ZipFile.java:56)
        at java.util.zip.ZipFile$1.nextElement(ZipFile.java:491)
        at java.util.zip.ZipFile$1.nextElement(ZipFile.java:481)
        at java.util.jar.JarFile$1.nextElement(JarFile.java:242)
        at java.util.jar.JarFile$1.nextElement(JarFile.java:237)
        at org.apache.tomcat.util.scan.FileUrlJar.nextEntry(FileUrlJar.java:76)

        Show
        Chatree Srichart added a comment - Yes, it does. I attach a patch file to enable JAR Scanner for a webapp context. Unfortunately, when I applied this patch I still get an error. For example: SEVERE: Error processing TLD files for context with name [/myportal] java.lang.IllegalStateException: zip file closed at java.util.zip.ZipFile.ensureOpen(ZipFile.java:632) at java.util.zip.ZipFile.access$200(ZipFile.java:56) at java.util.zip.ZipFile$1.nextElement(ZipFile.java:491) at java.util.zip.ZipFile$1.nextElement(ZipFile.java:481) at java.util.jar.JarFile$1.nextElement(JarFile.java:242) at java.util.jar.JarFile$1.nextElement(JarFile.java:237) at org.apache.tomcat.util.scan.FileUrlJar.nextEntry(FileUrlJar.java:76)
        Hide
        Adrian Crum added a comment -

        The webslinger component has been removed from the trunk, so that issue has been resolved.

        The multi-threaded component loader was the result of a conversation I had with Adam Heath about SEDA and a multi-threaded consumer-provider design pattern. I had proposed speeding up the loading process by making it multi-threaded: One thread parses the XML files, while another thread does something with the parsed results. It appears the implementation mentioned in this issue doesn't follow that pattern (I can't be sure because I haven't looked at the code, but the behavior seems to indicate this). I would recommend keeping the multi-threading aspect, but change the roles/tasks of the threads - so the webapps will get loaded consecutively.

        Show
        Adrian Crum added a comment - The webslinger component has been removed from the trunk, so that issue has been resolved. The multi-threaded component loader was the result of a conversation I had with Adam Heath about SEDA and a multi-threaded consumer-provider design pattern. I had proposed speeding up the loading process by making it multi-threaded: One thread parses the XML files, while another thread does something with the parsed results. It appears the implementation mentioned in this issue doesn't follow that pattern (I can't be sure because I haven't looked at the code, but the behavior seems to indicate this). I would recommend keeping the multi-threading aspect, but change the roles/tasks of the threads - so the webapps will get loaded consecutively.
        Hide
        Jacques Le Roux added a comment -

        Hi Adrian, then should we not close?

        Show
        Jacques Le Roux added a comment - Hi Adrian, then should we not close?
        Hide
        Adrian Crum added a comment -

        According to the reporter, this is still an issue - so it should stay open.

        Show
        Adrian Crum added a comment - According to the reporter, this is still an issue - so it should stay open.

          People

          • Assignee:
            Unassigned
            Reporter:
            Chatree Srichart
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 168h
              168h
              Remaining:
              Remaining Estimate - 168h
              168h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development