Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: Trunk
    • Component/s: framework
    • Labels:
    • Environment:

      Ubuntu

      Description

      Hi community.
      I need to upgrade Tomcat version in OFBiz up to 7, currently is 7.0.22.
      I see some changes in API, especially the Embedded class is deprecated and the Tomcat class has been suggested. But the Tomcat class does not have functions like the Embedded class.
      It also use mbean descriptors which provide a number of beans and their attributes.
      Furthermore, The JSSEFactory class has been removed. I have tried to use a new class called JSSEImplementation I hope it will work in the same way.
      Lastly, I am stuck in a ofbizssl.jks path problem when I start the Tomcat instance.

      Could you please give me your hand to get OFBiz work with Tomcat version 7 ?

      Regards,
      Chatree Srichart

      1. tomcat7.patch
        36 kB
        Chatree Srichart
      2. test-results.tar.gz
        30 kB
        Erwan de FERRIERES
      3. lib.zip
        5.28 MB
        Chatree Srichart

        Activity

        Hide
        Chatree Srichart added a comment -

        I have already got OFBiz work with Tomcat 7.0.22. I changed following:

        • use a Tomcat class instead of an Embedded class as an embedded server.
        • remove the enable-request-dump property in the engine level in the catalina container (ofbiz-containers.xml file) but add the enable request dump as a webapp filter
        • remove these libraries:
        • framework/catalina/lib/ecj-3.3.1.jar
        • framework/base/lib/j2eespecs/tomcat-6.0.33.annotations-api.jar
        • framework/base/lib/j2eespecs/tomcat-6.0.33.el-api.jar
        • framework/base/lib/j2eespecs/tomcat-6.0.33.jsp-api.jar
        • framework/base/lib/j2eespecs/tomcat-6.0.33.servlet-api.jar
        • framework/catalina/lib/tomcat-6.0.33-tomcat-juli-adapters.jar
        • framework/catalina/lib/tomcat-6.0.33-tomcat-juli.jar
        • framework/catalina/lib/tomcat-6.0.33.catalina-ant.jar
        • framework/catalina/lib/tomcat-6.0.33.catalina-ha.jar
        • framework/catalina/lib/tomcat-6.0.33.catalina-tribes.jar
        • framework/catalina/lib/tomcat-6.0.33.catalina.jar
        • framework/catalina/lib/tomcat-6.0.33.jasper-el.jar
        • framework/catalina/lib/tomcat-6.0.33.jasper.jar
        • framework/catalina/lib/tomcat-6.0.33.tomcat-coyote.jar
        • framework/catalina/lib/tomcat-6.0.33.tomcat-dbcp.jar
        • framework/catalina/lib/tomcat-6.0.33.tomcat-i18n-es.jar
        • framework/catalina/lib/tomcat-6.0.33.tomcat-i18n-fr.jar
        • framework/catalina/lib/tomcat-6.0.33.tomcat-i18n-ja.jar
        • add these libraries:
        • framework/catalina/lib/ecj-3.7.jar
        • framework/base/lib/j2eespecs/tomcat-7.0.22.annotations-api.jar
        • framework/base/lib/j2eespecs/tomcat-7.0.22.el-api.jar
        • framework/base/lib/j2eespecs/tomcat-7.0.22.jsp-api.jar
        • framework/base/lib/j2eespecs/tomcat-7.0.22.servlet-api.jar
        • framework/catalina/lib/tomcat-7.0.22-tomcat-juli-adapters.jar
        • framework/catalina/lib/tomcat-7.0.22-tomcat-juli.jar
        • framework/catalina/lib/tomcat-7.0.22.catalina-ant.jar
        • framework/catalina/lib/tomcat-7.0.22.catalina-ha.jar
        • framework/catalina/lib/tomcat-7.0.22.catalina-tribes.jar
        • framework/catalina/lib/tomcat-7.0.22.catalina.jar
        • framework/catalina/lib/tomcat-7.0.22.jasper-el.jar
        • framework/catalina/lib/tomcat-7.0.22.jasper.jar
        • framework/catalina/lib/tomcat-7.0.22.tomcat-coyote.jar
        • framework/catalina/lib/tomcat-7.0.22.tomcat-dbcp.jar
        • framework/catalina/lib/tomcat-7.0.22.tomcat-api.jar
        • framework/catalina/lib/tomcat-7.0.22.tomcat-util.jar
        • framework/catalina/lib/tomcat-7.0.22.tomcat-i18n-es.jar
        • framework/catalina/lib/tomcat-7.0.22.tomcat-i18n-fr.jar
        • framework/catalina/lib/tomcat-7.0.22.tomcat-i18n-ja.jar

        I also attach a patch file and required libraries, so you can test it by applying the patch and replace the old version of Tomcat's libraries (Tomcat 6) with the attached libraries (Tomcat 7).

        If there is not any objection, please commit it to the trunk.

        Regards,
        Chatree Srichart

        Show
        Chatree Srichart added a comment - I have already got OFBiz work with Tomcat 7.0.22. I changed following: use a Tomcat class instead of an Embedded class as an embedded server. remove the enable-request-dump property in the engine level in the catalina container (ofbiz-containers.xml file) but add the enable request dump as a webapp filter remove these libraries: framework/catalina/lib/ecj-3.3.1.jar framework/base/lib/j2eespecs/tomcat-6.0.33.annotations-api.jar framework/base/lib/j2eespecs/tomcat-6.0.33.el-api.jar framework/base/lib/j2eespecs/tomcat-6.0.33.jsp-api.jar framework/base/lib/j2eespecs/tomcat-6.0.33.servlet-api.jar framework/catalina/lib/tomcat-6.0.33-tomcat-juli-adapters.jar framework/catalina/lib/tomcat-6.0.33-tomcat-juli.jar framework/catalina/lib/tomcat-6.0.33.catalina-ant.jar framework/catalina/lib/tomcat-6.0.33.catalina-ha.jar framework/catalina/lib/tomcat-6.0.33.catalina-tribes.jar framework/catalina/lib/tomcat-6.0.33.catalina.jar framework/catalina/lib/tomcat-6.0.33.jasper-el.jar framework/catalina/lib/tomcat-6.0.33.jasper.jar framework/catalina/lib/tomcat-6.0.33.tomcat-coyote.jar framework/catalina/lib/tomcat-6.0.33.tomcat-dbcp.jar framework/catalina/lib/tomcat-6.0.33.tomcat-i18n-es.jar framework/catalina/lib/tomcat-6.0.33.tomcat-i18n-fr.jar framework/catalina/lib/tomcat-6.0.33.tomcat-i18n-ja.jar add these libraries: framework/catalina/lib/ecj-3.7.jar framework/base/lib/j2eespecs/tomcat-7.0.22.annotations-api.jar framework/base/lib/j2eespecs/tomcat-7.0.22.el-api.jar framework/base/lib/j2eespecs/tomcat-7.0.22.jsp-api.jar framework/base/lib/j2eespecs/tomcat-7.0.22.servlet-api.jar framework/catalina/lib/tomcat-7.0.22-tomcat-juli-adapters.jar framework/catalina/lib/tomcat-7.0.22-tomcat-juli.jar framework/catalina/lib/tomcat-7.0.22.catalina-ant.jar framework/catalina/lib/tomcat-7.0.22.catalina-ha.jar framework/catalina/lib/tomcat-7.0.22.catalina-tribes.jar framework/catalina/lib/tomcat-7.0.22.catalina.jar framework/catalina/lib/tomcat-7.0.22.jasper-el.jar framework/catalina/lib/tomcat-7.0.22.jasper.jar framework/catalina/lib/tomcat-7.0.22.tomcat-coyote.jar framework/catalina/lib/tomcat-7.0.22.tomcat-dbcp.jar framework/catalina/lib/tomcat-7.0.22.tomcat-api.jar framework/catalina/lib/tomcat-7.0.22.tomcat-util.jar framework/catalina/lib/tomcat-7.0.22.tomcat-i18n-es.jar framework/catalina/lib/tomcat-7.0.22.tomcat-i18n-fr.jar framework/catalina/lib/tomcat-7.0.22.tomcat-i18n-ja.jar I also attach a patch file and required libraries, so you can test it by applying the patch and replace the old version of Tomcat's libraries (Tomcat 6) with the attached libraries (Tomcat 7). If there is not any objection, please commit it to the trunk. Regards, Chatree Srichart
        Hide
        Chatree Srichart added a comment -

        attach a patch file and required Tomcat 7.0.22 libraries

        Show
        Chatree Srichart added a comment - attach a patch file and required Tomcat 7.0.22 libraries
        Hide
        Sam Hamilton added a comment -

        Testing using the applications as an end user - works for me.

        Thanks
        Sam

        Show
        Sam Hamilton added a comment - Testing using the applications as an end user - works for me. Thanks Sam
        Hide
        Sascha Rodekamp added a comment -

        I like the idea of upgrading Tomcat, the current version have a few interesting changes, espacilly the new security features.

        If anybody is fine with it, should we first create a branch for this upgrade?

        Show
        Sascha Rodekamp added a comment - I like the idea of upgrading Tomcat, the current version have a few interesting changes, espacilly the new security features. If anybody is fine with it, should we first create a branch for this upgrade?
        Hide
        Adrian Crum added a comment -

        We have not required a branch in the past. If there are issues after the commit, then we can fix them or revert.

        It would be helpful to know how the tests run with v7.

        Show
        Adrian Crum added a comment - We have not required a branch in the past. If there are issues after the commit, then we can fix them or revert. It would be helpful to know how the tests run with v7.
        Hide
        Erwan de FERRIERES added a comment -

        I just ran the tests on my machine, build is successfull

        Show
        Erwan de FERRIERES added a comment - I just ran the tests on my machine, build is successfull
        Hide
        Erwan de FERRIERES added a comment -

        test results

        Show
        Erwan de FERRIERES added a comment - test results
        Hide
        Sascha Rodekamp added a comment -

        great that looks like we can do this without problems.

        Show
        Sascha Rodekamp added a comment - great that looks like we can do this without problems.
        Hide
        Hans Bakker added a comment -

        Since no further objection for the inclusion....

        Excellent Job Chattree, thanks for your work.

        Committed revision 1203470

        Show
        Hans Bakker added a comment - Since no further objection for the inclusion.... Excellent Job Chattree, thanks for your work. Committed revision 1203470

          People

          • Assignee:
            Hans Bakker
            Reporter:
            Chatree Srichart
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 48h
              48h
              Remaining:
              Remaining Estimate - 48h
              48h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development