OFBiz
  1. OFBiz
  2. OFBIZ-4558

Verify subscription email requires form submit

    Details

      Description

      ContactListVerifyEmail.ftl used for sending verify subscription email, uses form submit for the confirmation. Instead it should be hyperlink. Form submit from email may not be supported by some email clients. If email clients support it, it would be prompt a warning message. And user may cancel the confirmation.

        Activity

        Kiran Gawde created issue -
        Hide
        Kiran Gawde added a comment -

        OK. I tried changing it to url but it gives following error. Does anyone have better idea?

        Request updateContactListPartyNoUserLogin caused an error with the following message: Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [contactListId] passed to secure (https) request-map with uri [updateContactListPartyNoUserLogin] with an event that calls service [updateContactListPartyNoUserLogin]; this is not allowed for security reasons! The data should be encrypted by making it part of the request body (a form field) instead of the request URL. Moreover it would be kind if you could create a Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task for this error does not exist). If you are not sure how to create a Jira issue please have a look before at http://cwiki.apache.org/confluence/x/JIB2 Thank you in advance for your help.

        Show
        Kiran Gawde added a comment - OK. I tried changing it to url but it gives following error. Does anyone have better idea? Request updateContactListPartyNoUserLogin caused an error with the following message: Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL parameter [contactListId] passed to secure (https) request-map with uri [updateContactListPartyNoUserLogin] with an event that calls service [updateContactListPartyNoUserLogin] ; this is not allowed for security reasons! The data should be encrypted by making it part of the request body (a form field) instead of the request URL. Moreover it would be kind if you could create a Jira sub-task of https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task for this error does not exist). If you are not sure how to create a Jira issue please have a look before at http://cwiki.apache.org/confluence/x/JIB2 Thank you in advance for your help.
        Hide
        Deepak Dixit added a comment -

        Here is the patch for this issue. Added missing separator for the email url "/"

        Show
        Deepak Dixit added a comment - Here is the patch for this issue. Added missing separator for the email url "/"
        Deepak Dixit made changes -
        Field Original Value New Value
        Attachment OFBIZ-4558.patch [ 12688511 ]
        Hide
        Deepak Dixit added a comment -

        Form to url conversion done at r#1150558 by Hans.

        Show
        Deepak Dixit added a comment - Form to url conversion done at r#1150558 by Hans.
        Deepak Dixit made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Ashish Vijaywargiya made changes -
        Assignee Ashish Vijaywargiya [ toashishvijay ]
        Hide
        Ashish Vijaywargiya added a comment -

        Thanks Kiran for creating the issue.
        Thanks Deepak for the contribution, your changes are committed on following revisions:

        – trunk - 1646943
        – R13.07 - 1646945
        – R12.04 - 1646946

        Show
        Ashish Vijaywargiya added a comment - Thanks Kiran for creating the issue. Thanks Deepak for the contribution, your changes are committed on following revisions: – trunk - 1646943 – R13.07 - 1646945 – R12.04 - 1646946
        Ashish Vijaywargiya made changes -
        Status Patch Available [ 10002 ] Closed [ 6 ]
        Fix Version/s Upcoming Branch [ 12327361 ]
        Fix Version/s Release Branch 13.07 [ 12324879 ]
        Fix Version/s Release Branch 12.04 [ 12321265 ]
        Resolution Fixed [ 1 ]
        Hide
        Jacques Le Roux added a comment -

        Please Ashish change the "Fix versions" to unreleased ones.

        Show
        Jacques Le Roux added a comment - Please Ashish change the "Fix versions" to unreleased ones.
        Ashish Vijaywargiya made changes -
        Fix Version/s 12.04.06 [ 12328243 ]
        Fix Version/s 13.07.02 [ 12328788 ]
        Fix Version/s Release Branch 12.04 [ 12321265 ]
        Fix Version/s Release Branch 13.07 [ 12324879 ]

          People

          • Assignee:
            Ashish Vijaywargiya
            Reporter:
            Kiran Gawde
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development