Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-4495

Warnings while approving the purchase order

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Release Branch 11.04, Trunk
    • Fix Version/s: Release Branch 11.04, Trunk
    • Component/s: order
    • Labels:
      None

      Description

      Following warnings were noticed in the log while approving the purchase order that was created automatically for drop ship product.

      [ OrderServices.java:2389:WARN ] Tried to setOrderStatus with the same statusId [ ORDER_APPROVED ] for order with ID
      [ServiceEcaCondition.java:156:WARN ] From Field (orderTypeId) is not found in context for changeOrderStatus, defaulting to null.

      The first warning suggest that there is order status is changed again. Shouldn't have happened. The order header should be updated before updating the order items.
      The second warning happens because some time, changeOrderStatus returns without adding orderTypeId to success result. Since there are secas rules based upon this field, the field should be mandatory and not optional.

      1. OFBIZ-4495-R10.04.patch
        4 kB
        Yashwant Dhakad
      2. OFBIZ-4495-OrderServicesJava.patch
        5 kB
        Kiran Gawde

        Activity

        Hide
        kiran_gawde Kiran Gawde added a comment -

        Added orderTypeId to resultSuccess. Set the status on orderItem after, it is set in orderHeader

        Show
        kiran_gawde Kiran Gawde added a comment - Added orderTypeId to resultSuccess. Set the status on orderItem after, it is set in orderHeader
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Kiran,

        Your patch is in
        trunk r1187933
        R11.04 r1187934.

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Kiran, Your patch is in trunk r1187933 R11.04 r1187934.
        Hide
        yashwant.dhakad Yashwant Dhakad added a comment -

        Here is the patch for R10.04 branch.

        Show
        yashwant.dhakad Yashwant Dhakad added a comment - Here is the patch for R10.04 branch.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Yashwant,

        Your patch is in R10.04 at r1341458

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Yashwant, Your patch is in R10.04 at r1341458
        Hide
        yashwant.dhakad Yashwant Dhakad added a comment -

        Thanks Jacques.

        Show
        yashwant.dhakad Yashwant Dhakad added a comment - Thanks Jacques.

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            kiran_gawde Kiran Gawde
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development