OFBiz
  1. OFBiz
  2. OFBIZ-4458

OnePageCheckout doesn't create purchase order for dropShip product

    Details

      Description

      Select a item from drop ship supplier.
      Perform one page checkout.

      Issue: Purchase order for drop ship supplier is not created

        Activity

        Hide
        Kiran Gawde added a comment -

        Fix: Following line needed to be executed before rendering onepagecheckout.
        shoppingCart.createDropShipGroups(dispatcher);

        Two choices:
        1. Put CheckoutOptions.groovy in OnePageCheckout actions.
        2. Create new groovy file and add above line.

        I am using 2nd option as workaround. Someone with more knowledge about this code need to figure out if CheckoutOptions.groovy can be refactored/reused.

        Show
        Kiran Gawde added a comment - Fix: Following line needed to be executed before rendering onepagecheckout. shoppingCart.createDropShipGroups(dispatcher); Two choices: 1. Put CheckoutOptions.groovy in OnePageCheckout actions. 2. Create new groovy file and add above line. I am using 2nd option as workaround. Someone with more knowledge about this code need to figure out if CheckoutOptions.groovy can be refactored/reused.
        Hide
        Kiran Gawde added a comment -

        Added OnePageCheckoutOptions.groovy. It creates dropship groups

        Show
        Kiran Gawde added a comment - Added OnePageCheckoutOptions.groovy. It creates dropship groups
        Hide
        Erwan de FERRIERES added a comment -

        Kiran,
        you should accept to grant license to ASF for inclusion when uploading your patch, otherwise your code cannot be committed.

        Thanks

        Show
        Erwan de FERRIERES added a comment - Kiran, you should accept to grant license to ASF for inclusion when uploading your patch, otherwise your code cannot be committed. Thanks
        Hide
        Kiran Gawde added a comment - - edited

        Hello Erwan,

        This is the first time, I am learning about the grant license to ASF. Can
        you please tell me how to grant license? Can you please send me the link
        to the instructions? Thanks.

        Regards,
        Kiran Gawde

        Show
        Kiran Gawde added a comment - - edited Hello Erwan, This is the first time, I am learning about the grant license to ASF. Can you please tell me how to grant license? Can you please send me the link to the instructions? Thanks. Regards, Kiran Gawde
        Hide
        Erwan de FERRIERES added a comment -

        when you're attaching a file to the JIRA issue, there an option list

        • Attachment not intended for inclusion
        • Grant license to ASF for inclusion in ASF works (as per the Apache License §5)

        Just select the right option ! And then a small feather will appear next to your patch.

        Cheers,

        Show
        Erwan de FERRIERES added a comment - when you're attaching a file to the JIRA issue, there an option list Attachment not intended for inclusion Grant license to ASF for inclusion in ASF works (as per the Apache License §5) Just select the right option ! And then a small feather will appear next to your patch. Cheers,
        Hide
        Jacques Le Roux added a comment -

        Neat explanation Erwan,

        Could you pleae add it at https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices?
        I did not find anything there (though I just looked for "grant")

        Thanks

        Show
        Jacques Le Roux added a comment - Neat explanation Erwan, Could you pleae add it at https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices? I did not find anything there (though I just looked for "grant") Thanks
        Hide
        Erwan de FERRIERES added a comment -

        I searched the same thing and didn't find it too !
        I was planning on updating the documentation later today.
        Cheers,

        Show
        Erwan de FERRIERES added a comment - I searched the same thing and didn't find it too ! I was planning on updating the documentation later today. Cheers,
        Hide
        Kiran Gawde added a comment -

        Re-uploading the patches with grant license

        Show
        Kiran Gawde added a comment - Re-uploading the patches with grant license
        Hide
        Kiran Gawde added a comment - - edited

        Thanks done. I will do the same for remaining patches.

        Regards,
        Kiran Gawde

        Show
        Kiran Gawde added a comment - - edited Thanks done. I will do the same for remaining patches. Regards, Kiran Gawde
        Hide
        Erwan de FERRIERES added a comment -

        Kiran,

        could you please elaborate your bug descriptions? I need more steps and info, also where to look to validate your patch.

        It's the same for your other issues, I'm missing too much information, and can't validate what you've done.

        Thanks

        Show
        Erwan de FERRIERES added a comment - Kiran, could you please elaborate your bug descriptions? I need more steps and info, also where to look to validate your patch. It's the same for your other issues, I'm missing too much information, and can't validate what you've done. Thanks
        Hide
        Kiran Gawde added a comment - - edited

        Hello Erwan,

        In this case, just pick any item eligible for dropshipment. Add it to
        cart. Use 'OnePageCheckout' option.

        If you would have used other checkout options, you would see a sales order
        and related purchase order. But when you choose the OnePageCheckout it
        doesn't creates only sales order and not the purchase order. Let me know
        if you need more info.

        Let me know which other defect you are looking at and I can try to provide
        more details.

        Cheers
        Kiran

        Show
        Kiran Gawde added a comment - - edited Hello Erwan, In this case, just pick any item eligible for dropshipment. Add it to cart. Use 'OnePageCheckout' option. If you would have used other checkout options, you would see a sales order and related purchase order. But when you choose the OnePageCheckout it doesn't creates only sales order and not the purchase order. Let me know if you need more info. Let me know which other defect you are looking at and I can try to provide more details. Cheers Kiran
        Hide
        Jacques Le Roux added a comment -

        Thanks Kiran,

        Your patch is in
        trunk r1304567
        R11.04 r1304568
        R10.04 r1304571

        I choose your way, adding CheckoutOptions.groovy would have been an overkill, and refactoring risky

        Show
        Jacques Le Roux added a comment - Thanks Kiran, Your patch is in trunk r1304567 R11.04 r1304568 R10.04 r1304571 I choose your way, adding CheckoutOptions.groovy would have been an overkill, and refactoring risky
        Hide
        Kiran Gawde added a comment -

        Thanks!!

        Show
        Kiran Gawde added a comment - Thanks!!
        Hide
        Jacques Le Roux added a comment -

        Hi Kiran,

        More to come, I'm working on your Jiras...

        Show
        Jacques Le Roux added a comment - Hi Kiran, More to come, I'm working on your Jiras...

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Kiran Gawde
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development