Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: order
    • Labels:
      None

      Description

      Productname now comes from the content instead of the entity,

      1. Product.groovy.patch
        0.8 kB
        Christian Fischer

        Activity

        Christian Fischer created issue -
        Christian Fischer made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Christian Fischer made changes -
        Attachment Product.groovy.patch [ 12495032 ]
        Christian Fischer made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Adrian Crum added a comment -

        Why is this change needed? And why is the issue marked as Resolved?

        Show
        Adrian Crum added a comment - Why is this change needed? And why is the issue marked as Resolved?
        Hide
        Christian Fischer added a comment -

        If you take the name frome the entity, you aren't able to take the localized names. This patch is useful, if you have different names for products in different languages.

        To the Resolved-mark: I think, I interpreted it wrong. I thought,Resolved means, that its fixed and ready to be tested. Sorry for that, won't happen again.

        Show
        Christian Fischer added a comment - If you take the name frome the entity, you aren't able to take the localized names. This patch is useful, if you have different names for products in different languages. To the Resolved-mark: I think, I interpreted it wrong. I thought,Resolved means, that its fixed and ready to be tested. Sorry for that, won't happen again.
        Hide
        Adrian Crum added a comment -

        You can localize entity fields by using the UI labels files. There are examples of this in code already.

        Show
        Adrian Crum added a comment - You can localize entity fields by using the UI labels files. There are examples of this in code already.
        Hide
        Christian Fischer added a comment -

        In this Patch we get a productName from Content. I dont think it is usefull to get individual ProductData from EntityLabels.

        Show
        Christian Fischer added a comment - In this Patch we get a productName from Content. I dont think it is usefull to get individual ProductData from EntityLabels.
        Hide
        Jacques Le Roux added a comment - - edited

        Aboutthe Resolved status: if you provide a patch you should rather use "Patch provided" status

        Edit I meaned "Patch available"

        Show
        Jacques Le Roux added a comment - - edited Aboutthe Resolved status: if you provide a patch you should rather use "Patch provided" status Edit I meaned "Patch available"
        Jacques Le Roux made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Jacques Le Roux made changes -
        Status Reopened [ 4 ] Patch Available [ 10002 ]
        Hide
        Jacques Le Roux added a comment -

        Christian,

        Please don't use tabs in your patches.

        I think we should test if there is a value in contentWrapper.get("PRODUCT_NAME") before, like in

        if (contentWrapper.get("PRODUCT_NAME")) keywords.add(contentWrapper.get("PRODUCT_NAME"));
        else keywords.add(product.productName);

        Show
        Jacques Le Roux added a comment - Christian, Please don't use tabs in your patches. I think we should test if there is a value in contentWrapper.get("PRODUCT_NAME") before, like in if (contentWrapper.get("PRODUCT_NAME")) keywords.add(contentWrapper.get("PRODUCT_NAME")); else keywords.add(product.productName);
        Jacopo Cappellato made changes -
        Component/s order [ 12311152 ]
        Hide
        Jacques Le Roux added a comment -

        This has been already implemented with OFBIZ-4208

        Show
        Jacques Le Roux added a comment - This has been already implemented with OFBIZ-4208
        Jacques Le Roux made changes -
        Status Patch Available [ 10002 ] Closed [ 6 ]
        Assignee Jacques Le Roux [ jacques.le.roux ]
        Resolution Duplicate [ 3 ]

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Christian Fischer
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development