OFBiz
  1. OFBiz
  2. OFBIZ-4403

The "Orders" tab in "Catalog > Products" is not working.

    Details

      Description

      The "Orders" tab in "Catalog > Products" is not working. The reason being that the "CommonProductDecorator" has got a condition '<not><if-empty field="product"/></not>' in it, which fails for the "ViewProductOrder" screen.

      1. OFBIZ-4403.patch
        17 kB
        Atul Vani
      2. OFBIZ-4403.patch
        0.8 kB
        Atul Vani
      3. OFBIZ-4403.patch
        0.7 kB
        Atul Vani

        Activity

        Hide
        Atul Vani added a comment -

        Patch added.

        Show
        Atul Vani added a comment - Patch added.
        Hide
        Atul Vani added a comment -

        Better patch added, that fixes highlighting of the 'Orders' tab too.

        Show
        Atul Vani added a comment - Better patch added, that fixes highlighting of the 'Orders' tab too.
        Hide
        Atul Vani added a comment -

        Another patch, fixes more screens from redundant and useless code. Although I've checked all the screens after this one, but another set of eyes will be better.

        While doing this I found that the "Accounts" tab's functionality is not working properly, well not due to my changes, it isn't working on trunk either.

        Show
        Atul Vani added a comment - Another patch, fixes more screens from redundant and useless code. Although I've checked all the screens after this one, but another set of eyes will be better. While doing this I found that the "Accounts" tab's functionality is not working properly, well not due to my changes, it isn't working on trunk either.
        Hide
        Sascha Rodekamp added a comment -

        Hi Atul,
        that looks good at a first glace. I'll have a deeper look this evening.
        Cheers

        Show
        Sascha Rodekamp added a comment - Hi Atul, that looks good at a first glace. I'll have a deeper look this evening. Cheers
        Hide
        Sascha Rodekamp added a comment -

        Hi Atul thanks for your effort.

        Your patch is in trunk and release 11.04.

        Could provide a working patch for release 10.04.

        Show
        Sascha Rodekamp added a comment - Hi Atul thanks for your effort. Your patch is in trunk and release 11.04. Could provide a working patch for release 10.04.
        Hide
        Jacques Le Roux added a comment -

        Backported in R10.04 from r1170469 at r1175161

        Show
        Jacques Le Roux added a comment - Backported in R10.04 from r1170469 at r1175161
        Hide
        Atul Vani added a comment -

        Thanks Jacques, I got consumed with some other stuff so this got delayed. Sorry for the inconvenience.

        Show
        Atul Vani added a comment - Thanks Jacques, I got consumed with some other stuff so this got delayed. Sorry for the inconvenience.
        Hide
        Jacques Le Roux added a comment -

        Hi Atul,

        No worries, it was an easy fix

        Show
        Jacques Le Roux added a comment - Hi Atul, No worries, it was an easy fix
        Hide
        Sascha Rodekamp added a comment -

        Thanks Jacques

        Show
        Sascha Rodekamp added a comment - Thanks Jacques
        Hide
        Jacques Le Roux added a comment - - edited

        ========== EDIT WRONG JIRA REF ====
        Reopen for R10.04

        Actually backporting to R10.04 kills the product supplier tabs see OFBIZ-4551. I reverted at r1199446 since now, at least, it does not show an ugly srceen, still wrong though, no pbs in trunk

        Show
        Jacques Le Roux added a comment - - edited ========== EDIT WRONG JIRA REF ==== Reopen for R10.04 Actually backporting to R10.04 kills the product supplier tabs see OFBIZ-4551 . I reverted at r1199446 since now, at least, it does not show an ugly srceen, still wrong though, no pbs in trunk
        Hide
        Jacques Le Roux added a comment -

        Fixed in R10.04 by Ankit's patch from OFBIZ-4613 at r1212107

        Show
        Jacques Le Roux added a comment - Fixed in R10.04 by Ankit's patch from OFBIZ-4613 at r1212107

          People

          • Assignee:
            Sascha Rodekamp
            Reporter:
            Atul Vani
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development