OFBiz
  1. OFBiz
  2. OFBIZ-4374

Support filtering on non-std date field names in performFind and prepareFind

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Branch
    • Component/s: framework
    • Labels:
      None
    • Environment:

      REV 1152668

      Description

      I had a need to filter by date ranges for entities that didn't follow the standard fromDate and thruDate field-naming pattern. I therefore enhanced prepareFind and performFind services so they could be passed the names of the fields to use in place of fromDate and thruDate when the filterByDate option was chosen. Thought this might be useful to others, even though it isn't currently used in OOTB code.

        Activity

        Anne Jessel created issue -
        Anne Jessel made changes -
        Field Original Value New Value
        Attachment OFBIZ-4374_FilterNonStdDateFieldNames.patch [ 12490762 ]
        Anne Jessel made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Anne Jessel added a comment -

        Replaced git-format patch with svn-format patch, against REV 1160087.

        Show
        Anne Jessel added a comment - Replaced git-format patch with svn-format patch, against REV 1160087.
        Anne Jessel made changes -
        Nicolas Malin made changes -
        Assignee Nicolas Malin [ soledad ]
        Hide
        Nicolas Malin added a comment -

        With some lucky the patch has been applied on trunk without error.

        I commit it on trunk at revision 1655499 with code reformatting and junit test.

        With the difficulty to test, I create a new test-suite performfindtests with five junit :

        • testPerformFindConditionFieldEquals
        • testPerformFindConditionFieldLike
        • testPerformFindConditionDistinct
        • testPerformFindFilterByDate
        • testPerformFindFilterByDateWithDedicateDateField
          I also improve TestNodeMember with two fields extendFromDate and extendThruDate to realize filter on it.

        Thanks Anne for your issue

        Show
        Nicolas Malin added a comment - With some lucky the patch has been applied on trunk without error. I commit it on trunk at revision 1655499 with code reformatting and junit test. With the difficulty to test, I create a new test-suite performfindtests with five junit : testPerformFindConditionFieldEquals testPerformFindConditionFieldLike testPerformFindConditionDistinct testPerformFindFilterByDate testPerformFindFilterByDateWithDedicateDateField I also improve TestNodeMember with two fields extendFromDate and extendThruDate to realize filter on it. Thanks Anne for your issue
        Nicolas Malin made changes -
        Status Patch Available [ 10002 ] Closed [ 6 ]
        Fix Version/s Upcoming Branch [ 12329183 ]
        Resolution Implemented [ 10 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        3m 2s 1 Anne Jessel 18/Aug/11 07:48
        Patch Available Patch Available Closed Closed
        1259d 16h 42m 1 Nicolas Malin 28/Jan/15 23:30

          People

          • Assignee:
            Nicolas Malin
            Reporter:
            Anne Jessel
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development