OFBiz
  1. OFBiz
  2. OFBIZ-4361

Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: Release Branch 11.04, SVN trunk
    • Fix Version/s: None
    • Component/s: framework
    • Labels:
    • Environment:

      Ubuntu and others

      Description

      Currently, any user (via ecommerce "Forget Your Password") has the ability to reset another users password, including "admin" without permission. By simply entering "admin" and clicking "Email Password", the following is displayed.

      The following occurred:
      A new password has been created and sent to you. Please check your Email.

      This now forces the user of the ERP to change their password. It is also possible to generate a dictionary attack against ofbiz because there is no capta code required. This is serious security risk.

      This feature could be reduced to a certain sub-set of users, whose login name is optionally in the format of an email address, and maybe require a capta code to prevent dictionary attacks.

      For example, limit the feature to role "Customer" of type "Person" which was generated via an ecommerce transaction.

        Activity

        mz4wheeler created issue -
        Hide
        Deepak Dixit added a comment -

        We can also ask for the email address for forgot password, If email address matches then only we can send the new password to the user.

        Show
        Deepak Dixit added a comment - We can also ask for the email address for forgot password, If email address matches then only we can send the new password to the user.
        Hide
        Sam Hamilton added a comment -

        I would suggest that the forgot password emails the user a one time url to verify that they want to change their password and only after the link has been clicked are you able to change the password, I wouldn't have it email a password but rather give the user the option to set their own on the server. Its slightly more secure as email is not encrypted and the password could be intercepted and the new password page could be forced to go over SSL.

        I would prefer to keep the forgot password form as simple as possible so either ask for their username or their password but not both. I think that most people using the ecommerce app probably set their users username to their email address anyway.

        Show
        Sam Hamilton added a comment - I would suggest that the forgot password emails the user a one time url to verify that they want to change their password and only after the link has been clicked are you able to change the password, I wouldn't have it email a password but rather give the user the option to set their own on the server. Its slightly more secure as email is not encrypted and the password could be intercepted and the new password page could be forced to go over SSL. I would prefer to keep the forgot password form as simple as possible so either ask for their username or their password but not both. I think that most people using the ecommerce app probably set their users username to their email address anyway.
        Hide
        BJ Freeman added a comment -

        as was addressed in the email thread on the user mailing list, forget password resets the password if passwords are set to be encrypted
        so if someone maliciously puts in a forget password the user is blocked till they fnd the email and complete the process.
        Captcha was suggested
        http://svn.apache.org/viewvc?view=revision&revision=735965
        could be implement but won't stop a person.
        So If I understand Sam, The actual change password should happen on server. then email should have a https: URL to the server with a unique Key to identify the user.
        The Key is good till the user activated it or it times out.
        This way no password is effected till the user goes to the URL..

        Show
        BJ Freeman added a comment - as was addressed in the email thread on the user mailing list, forget password resets the password if passwords are set to be encrypted so if someone maliciously puts in a forget password the user is blocked till they fnd the email and complete the process. Captcha was suggested http://svn.apache.org/viewvc?view=revision&revision=735965 could be implement but won't stop a person. So If I understand Sam, The actual change password should happen on server. then email should have a https: URL to the server with a unique Key to identify the user. The Key is good till the user activated it or it times out. This way no password is effected till the user goes to the URL..
        Hide
        BJ Freeman added a comment -

        as some history

        I have five instances of ofbiz running including one demo.
        I have yet, in 4 years, to have this happen.

        Show
        BJ Freeman added a comment - as some history I have five instances of ofbiz running including one demo. I have yet, in 4 years, to have this happen.

          People

          • Assignee:
            Unassigned
            Reporter:
            mz4wheeler
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Development