OFBiz
  1. OFBiz
  2. OFBIZ-4351

Static text for reports at the ordermanager replaced by labels

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Implemented
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Patch includes
      AccountinguiLabels (one missing translation)
      OrderUiLabels (added missing labels for the reports)
      and of course the edited ReportForms and ReportScreens

      1. ReportScreens.xml.patch
        4 kB
        Christian Fischer
      2. ReportForms.xml.patch
        2 kB
        Christian Fischer
      3. OrderUiLabels.xml.patch
        2 kB
        Christian Fischer
      4. AccountingUiLabels.xml.patch
        0.7 kB
        Christian Fischer

        Activity

        Hide
        Jacques Le Roux added a comment -

        Hi Christian,

        This is great but:

        1. don't put as Resolved status (done for us) rather Provide Patch (waiting review)
        2. AccountingUiLabels.xml.patch and OrderUiLabels.xml.patch are useless (already applied or maybe rather missing your real additions)
        3. So from point2 the Report patches seems good but are missing new labels (maybe not all, but some for sure)

        Could you please check?

        Thanks

        Show
        Jacques Le Roux added a comment - Hi Christian, This is great but: don't put as Resolved status (done for us) rather Provide Patch (waiting review) AccountingUiLabels.xml.patch and OrderUiLabels.xml.patch are useless (already applied or maybe rather missing your real additions) So from point2 the Report patches seems good but are missing new labels (maybe not all, but some for sure) Could you please check? Thanks
        Hide
        Christian Fischer added a comment -

        Hello Jacques

        1. Sorry for that, I was new and thought, that it was the right status. Won't happen again.
        2. They are pretty old and had only minor translations. These translations were necassary for a project and after we finished it, I comitted these changes. Maybe in the last 5 months, someone updated the labels.
        3. I compared the ReportForms/Screens with the revision from 5 months ago and it looks like this is indeed the complete patch. Like I said before, this is a little patch. Also, by the time I created the patch, there wasn't that much static text left.

        I hope this answers your question.

        Regards,

        Christian

        Show
        Christian Fischer added a comment - Hello Jacques 1. Sorry for that, I was new and thought, that it was the right status. Won't happen again. 2. They are pretty old and had only minor translations. These translations were necassary for a project and after we finished it, I comitted these changes. Maybe in the last 5 months, someone updated the labels. 3. I compared the ReportForms/Screens with the revision from 5 months ago and it looks like this is indeed the complete patch. Like I said before, this is a little patch. Also, by the time I created the patch, there wasn't that much static text left. I hope this answers your question. Regards, Christian
        Hide
        Jacques Le Roux added a comment -

        Christian,

        1. No worries
        2. You can forget about those 2 patches, see below
        3. My point is that you use some labels in you patches which are not in OFBiz OOBT, like
          OrderAllReferrer
          OrderSaleChannel
          OrderAllDiscount
          OrderSalesReport
          OrderNetBeforeOverheadReport
          OrderProductDemandReport
          OrderSaleOrdersByReferrerReport
          ....
          So if you want these 2 patches to be applied, we need the corresponding labels (check your patches for the complete list)
        4. Also you should remove comments like
          <!-- MOD CF 22.07.11 Festen Titel durch Label ersetzt -->
          in your patch
        Show
        Jacques Le Roux added a comment - Christian, No worries You can forget about those 2 patches, see below My point is that you use some labels in you patches which are not in OFBiz OOBT, like OrderAllReferrer OrderSaleChannel OrderAllDiscount OrderSalesReport OrderNetBeforeOverheadReport OrderProductDemandReport OrderSaleOrdersByReferrerReport .... So if you want these 2 patches to be applied, we need the corresponding labels (check your patches for the complete list) Also you should remove comments like <!-- MOD CF 22.07.11 Festen Titel durch Label ersetzt --> in your patch
        Hide
        Christian Fischer added a comment -

        3. I see, I will deal with it later and upload the updated labels.
        4. Yeah, beginner's mistake

        Show
        Christian Fischer added a comment - 3. I see, I will deal with it later and upload the updated labels. 4. Yeah, beginner's mistake
        Hide
        Jacques Le Roux added a comment -

        Ping (before closing)

        Show
        Jacques Le Roux added a comment - Ping (before closing)
        Hide
        Jacques Le Roux added a comment -

        All this has been implemented otherwise since

        Show
        Jacques Le Roux added a comment - All this has been implemented otherwise since

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Christian Fischer
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development