OFBiz
  1. OFBiz
  2. OFBIZ-4344

createItemIssuanceRole and deleteItemIssuanceRole require Shipment PK parameter

    Details

      Description

      createItemIssuanceRole and deleteItemIssuanceRole both call checkCanChangeShipmentStatusPacked, which checks the current status of a shipment to see if anything about it can be modified.
      Therefore, these services require a shipmentId parameter, but at present their service definitions don't say so.
      At high logging levels, this bug causes log entries to say there's a missing PK value on a FindOne.
      This is not a major problem at present. create... is only called in the midst of another service and the test has already been done, but a direct call to create... might cause incorrect behaviour. delete... is not called within Ofbiz at present.

        Activity

        Paul Foxworthy created issue -
        Paul Foxworthy made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Paul Foxworthy made changes -
        Paul Foxworthy made changes -
        Environment rev 1147752
        Description createItemIssuanceRole and deleteItemIssuanceRole both call checkCanChangeShipmentStatusPacked, which checks the current status of a shipment to see if anything about it can be modified.
        Therefore, these services require a shipmentId parameter, but at present their service definitions don't say so.
        This is not a major problem at present. create... is only called in the midst of another service and the test has already been done, but a direct call to create... might cause incorrect behaviour. delete... is not called within Ofbiz at present.
        createItemIssuanceRole and deleteItemIssuanceRole both call checkCanChangeShipmentStatusPacked, which checks the current status of a shipment to see if anything about it can be modified.
        Therefore, these services require a shipmentId parameter, but at present their service definitions don't say so.
        At high logging levels, this bug causes log entries to say there's a missing PK value on a FindOne.
        This is not a major problem at present. create... is only called in the midst of another service and the test has already been done, but a direct call to create... might cause incorrect behaviour. delete... is not called within Ofbiz at present.
        Hide
        Paul Foxworthy added a comment -

        A minor problem, but easy to review and cross off the list

        Show
        Paul Foxworthy added a comment - A minor problem, but easy to review and cross off the list
        Paul Foxworthy made changes -
        Original Estimate 1h [ 3600 ]
        Remaining Estimate 1h [ 3600 ]
        Hide
        Jacques Le Roux added a comment -

        Thanks Paul,

        Your patch is in
        trunk r1167517
        R11.04 r1167549
        R10.04 r1167548
        R09.04 r1167547

        Show
        Jacques Le Roux added a comment - Thanks Paul, Your patch is in trunk r1167517 R11.04 r1167549 R10.04 r1167548 R09.04 r1167547
        Jacques Le Roux made changes -
        Status Patch Available [ 10002 ] Closed [ 6 ]
        Assignee Jacques Le Roux [ jacques.le.roux ]
        Fix Version/s Release Branch 09.04 [ 12313602 ]
        Fix Version/s Release Branch 10.04 [ 12314832 ]
        Fix Version/s Release Branch 11.04 [ 12316420 ]
        Fix Version/s SVN trunk [ 12311928 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        31m 9s 1 Paul Foxworthy 18/Jul/11 08:01
        Patch Available Patch Available Closed Closed
        54d 9h 5m 1 Jacques Le Roux 10/Sep/11 17:07

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Paul Foxworthy
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development