Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-4344

createItemIssuanceRole and deleteItemIssuanceRole require Shipment PK parameter

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      createItemIssuanceRole and deleteItemIssuanceRole both call checkCanChangeShipmentStatusPacked, which checks the current status of a shipment to see if anything about it can be modified.
      Therefore, these services require a shipmentId parameter, but at present their service definitions don't say so.
      At high logging levels, this bug causes log entries to say there's a missing PK value on a FindOne.
      This is not a major problem at present. create... is only called in the midst of another service and the test has already been done, but a direct call to create... might cause incorrect behaviour. delete... is not called within Ofbiz at present.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jleroux Jacques Le Roux
            paulfoxworthy Paul Foxworthy
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                Issue deployment