[OFBIZ-4344] createItemIssuanceRole and deleteItemIssuanceRole require Shipment PK parameter

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, Trunk
• Component/s: product

Environment

rev 1147752

• Assignee: Jacques Le Roux
• Reporter: Paul Foxworthy
• Created: 18/Jul/11 06:30
• Updated: 10/Sep/11 16:07
• Resolved: 10/Sep/11 16:07

Description

createItemIssuanceRole and deleteItemIssuanceRole both call checkCanChangeShipmentStatusPacked, which checks the current status of a shipment to see if anything about it can be modified.
Therefore, these services require a shipmentId parameter, but at present their service definitions don't say so.
At high logging levels, this bug causes log entries to say there's a missing PK value on a FindOne.
This is not a major problem at present. create... is only called in the midst of another service and the test has already been done, but a direct call to create... might cause incorrect behaviour. delete... is not called within Ofbiz at present.