OFBiz
  1. OFBiz
  2. OFBIZ-4282 TransactionUtil performance optimisations
  3. OFBIZ-4293

Set TransactionUtil#debugResources default value to false and make it configurable

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: SVN trunk
    • Fix Version/s: SVN trunk
    • Component/s: framework
    • Labels:

      Description

      As asked by David and Jacques:
      "I didn't say I'm against a configurable setting, like a properties file setting. I said I'm against changing the default in the code for all of OFBiz without making it configurable.
      On the topic of configuration: I'm against business-level configuration in properties files (that should go in the DB), I'm not against technical or system configuration in properties files, in fact that's just where it belongs."
      "About debugResources (debug stack)
      We could easily create a properties for that"

        Activity

        Jacques Le Roux made changes -
        Status Patch Available [ 10002 ] Closed [ 6 ]
        Assignee Jacques Le Roux [ jacques.le.roux ]
        Fix Version/s SVN trunk [ 12311928 ]
        Resolution Fixed [ 1 ]
        Hide
        Jacques Le Roux added a comment -

        Thanks Philippe,

        Your patch is in trunk at r1226234

        Minor points: please don't use tabs in your patch (entityengine.xml), follow the standard formatting way (no new lines for else, EntityConfigUtil.java), avoid to put changes from another patch in a patch (internalBegin)

        Show
        Jacques Le Roux added a comment - Thanks Philippe, Your patch is in trunk at r1226234 Minor points: please don't use tabs in your patch (entityengine.xml), follow the standard formatting way (no new lines for else, EntityConfigUtil.java), avoid to put changes from another patch in a patch (internalBegin)
        Jan le Roux committed 1226234 (4 files)
        Reviews: none

        A patch from Philippe Mouawad "Set TransactionUtil#debugResources default value to false and make it configurable" https://issues.apache.org/jira/browse/OFBIZ-4293

        debugResources is true which creates a DebugXAResource (that creates an Exception) , it should be false and made an option for debuging

        jleroux: see comments in Jira 4282 for more

        Philippe Mouawad made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Philippe Mouawad made changes -
        Field Original Value New Value
        Attachment patch-OFBIZ-4293.patch [ 12480167 ]
        Hide
        Philippe Mouawad added a comment -

        The patch, sorry it also contains removal of synchronized in internalBegin.

        Philippe
        http://www.ubik-ingenierie.com

        Show
        Philippe Mouawad added a comment - The patch, sorry it also contains removal of synchronized in internalBegin. Philippe http://www.ubik-ingenierie.com
        Hide
        Philippe Mouawad added a comment -

        Hello,
        I plan to add this configuration in entityengine.xml and call it:
        <debug-xa-resources value="false" />

        Are you OK with this ?

        Thank you
        Regards
        Philippe

        Show
        Philippe Mouawad added a comment - Hello, I plan to add this configuration in entityengine.xml and call it: <debug-xa-resources value="false" /> Are you OK with this ? Thank you Regards Philippe
        Philippe Mouawad created issue -

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Philippe Mouawad
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development