OFBiz
  1. OFBiz
  2. OFBIZ-4278

ModelScreen does not rollback transaction when ScreenRenderException occurs

    Details

    • Type: Bug Bug
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: SVN trunk
    • Fix Version/s: None
    • Component/s: framework
    • Labels:
      None

      Description

      Hello,
      Is there any reason why ModelScreen#renderScreenString() does not call TransactionUtil#rollback when ScreenRenderException occurs.
      It does so when Exception or RuntimeException occur.
      Furthermore, what's the point in duplicating code for Exception and RuntimeException ?

      As I am not sure if there is a reason , I ask, if you confirm it is useless I will provide a patch.
      Regards
      Philippe

        Activity

        Philippe Mouawad created issue -
        Hide
        Scott Gray added a comment -

        I don't see a reason why it doesn't and the commit makes no mention of it: http://svn.apache.org/viewvc?view=revision&revision=561025

        And yeah I agree the duplicated code doesn't seem to serve any purpose.

        Show
        Scott Gray added a comment - I don't see a reason why it doesn't and the commit makes no mention of it: http://svn.apache.org/viewvc?view=revision&revision=561025 And yeah I agree the duplicated code doesn't seem to serve any purpose.
        Hide
        Philippe Mouawad added a comment -

        The patch that fixes the issue.
        Philippe Mouawad
        http://www.ubik-ingenierie.com

        Show
        Philippe Mouawad added a comment - The patch that fixes the issue. Philippe Mouawad http://www.ubik-ingenierie.com
        Philippe Mouawad made changes -
        Field Original Value New Value
        Attachment patch-OFBIZ-4278.patch [ 12479220 ]
        Philippe Mouawad made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Philippe Mouawad
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development