OFBiz
  1. OFBiz
  2. OFBIZ-4225

Lookup target-parameter in form widget is not working.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: Release Branch 10.04, Trunk
    • Fix Version/s: Release Branch 10.04, Trunk
    • Component/s: framework
    • Labels:
      None

      Description

      There is a target-parameter for lookup, Currently its not working.
      We can test it over at https://localhost:8443/ordermgr/control/request page.

      1. OFBIZ-4225_BRANCH_IMPROVE.patch
        4 kB
        Deepak Dixit
      2. OFBIZ-4225_FOR_BRANCH10.04.patch
        1 kB
        Deepak Dixit
      3. OFBIZ-4225_FOR_TRUNK.patch
        0.7 kB
        Deepak Dixit
      4. OFBIZ-4225_TRUNK_IMPROVE.patch
        4 kB
        Deepak Dixit

        Issue Links

          Activity

          Hide
          Leon added a comment -

          What a long story ^^. Since the .xsd has been updated, I think this time parm0 would nevever change to parm1 again. I can apply the patch comfortablely.

          Thank you all.

          Show
          Leon added a comment - What a long story ^^. Since the .xsd has been updated, I think this time parm0 would nevever change to parm1 again. I can apply the patch comfortablely. Thank you all.
          Hide
          Deepak Dixit added a comment -

          Thanks Jacques.

          Show
          Deepak Dixit added a comment - Thanks Jacques.
          Hide
          Jacques Le Roux added a comment -

          Thanks Deepak,

          Your patch is in trunk at r1085671, R10.04 at r1085670.

          I have updated the XSD to tell it must begin at 0

          Show
          Jacques Le Roux added a comment - Thanks Deepak, Your patch is in trunk at r1085671, R10.04 at r1085670. I have updated the XSD to tell it must begin at 0
          Hide
          Deepak Dixit added a comment -

          Here is the improved patch for target-parameter functionality, now pam indexing start with 0 instead of 1.

          Show
          Deepak Dixit added a comment - Here is the improved patch for target-parameter functionality, now pam indexing start with 0 instead of 1.
          Hide
          Deepak Dixit added a comment -

          Now its working fine, Thanks Jaques and Leon.

          Show
          Deepak Dixit added a comment - Now its working fine, Thanks Jaques and Leon.
          Hide
          Deepak Dixit added a comment -

          For trunk its correct Jacques, We can start indexing with 0 and then its works fine. Sorry for the confusion.
          If we using index 0 then we have to fix the LookupPreferredContactMech screen to get parameter with parameters.parm0 instead of parameters.parm1.

          Show
          Deepak Dixit added a comment - For trunk its correct Jacques, We can start indexing with 0 and then its works fine. Sorry for the confusion. If we using index 0 then we have to fix the LookupPreferredContactMech screen to get parameter with parameters.parm0 instead of parameters.parm1.
          Hide
          Deepak Dixit added a comment - - edited

          Thanks Jacques for looking into this,

          But IMO its not working without this fix, because it can't it can't passed the correct value form the lookup/ lookup constructor. I'll cross ones again.

          And I did not change the view name, I only change the if condition;
          For 10.04
          Earlier it checks for args.lenght > 7 for adding target-parameter to parameters. If we check for args.lenght then its 6 and if we add target-parameter then its length is 7 so 7 th is the first target value for lookup.

          For Trunk:
          The indexing is wrong for paam, as i test it for https://localhost:8443/ordermgr/control/request , In EditRequest then it get the partyId form parameters.parm1 so I corrected the indexing.

          IMO it is a bug so we have to fix it and the patch will fix the problem.
          Please let me know it the fix is wrong and there is some improvement needed in patch.

          Show
          Deepak Dixit added a comment - - edited Thanks Jacques for looking into this, But IMO its not working without this fix, because it can't it can't passed the correct value form the lookup/ lookup constructor. I'll cross ones again. And I did not change the view name, I only change the if condition; For 10.04 Earlier it checks for args.lenght > 7 for adding target-parameter to parameters. If we check for args.lenght then its 6 and if we add target-parameter then its length is 7 so 7 th is the first target value for lookup. For Trunk: The indexing is wrong for paam, as i test it for https://localhost:8443/ordermgr/control/request , In EditRequest then it get the partyId form parameters.parm1 so I corrected the indexing. IMO it is a bug so we have to fix it and the patch will fix the problem. Please let me know it the fix is wrong and there is some improvement needed in patch.
          Hide
          Jacques Le Roux added a comment -

          Hi Deepak,

          Thinking more about it I have changed my mine. I will rather revert and use 0 as origin because some custom applications are certainly using it.

          I noticed you changed also for viewName in R10.04. So it was another mixed problem isn'it?

          Show
          Jacques Le Roux added a comment - Hi Deepak, Thinking more about it I have changed my mine. I will rather revert and use 0 as origin because some custom applications are certainly using it. I noticed you changed also for viewName in R10.04. So it was another mixed problem isn'it?
          Hide
          Deepak Dixit added a comment -

          Thanks Jacques.

          Show
          Deepak Dixit added a comment - Thanks Jacques.
          Hide
          Jacques Le Roux added a comment -

          Thanks a bunch Deepak,

          I did not get a chance to look at it, great!

          Your patches are respectively in trunk at r1084574, R10.04 at r1084572

          I have added a small change in the XSD to tell it should begin at 1

          Show
          Jacques Le Roux added a comment - Thanks a bunch Deepak, I did not get a chance to look at it, great! Your patches are respectively in trunk at r1084574, R10.04 at r1084572 I have added a small change in the XSD to tell it should begin at 1
          Hide
          Deepak Dixit added a comment -

          Here I am attaching patch for fix the current workflow of target-parameter.

          Show
          Deepak Dixit added a comment - Here I am attaching patch for fix the current workflow of target-parameter.

            People

            • Assignee:
              Jacques Le Roux
              Reporter:
              Deepak Dixit
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development