Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: Trunk
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      One for the maven practices is to separate code and test code source. We are not using maven with OFBiz, but this separation can be beneficial.

      src/main/java	Application/Library sources
      src/test/java	Test sources
      

      http://stackoverflow.com/questions/2388253/separation-of-junit-classes-into-special-test-package

      1. specialpurpose.out
        75 kB
        Ganath Rathnayake
      2. trees-tructures.zip
        5 kB
        Ganath Rathnayake
      3. treeview.txt
        731 kB
        Ganath Rathnayake

        Activity

        Hide
        Adrian Crum added a comment -

        This has been discussed on the dev mailing list and there seems to be some disagreement about its benefits. Maybe this should be discussed on the dev mailing list before any work is done.

        Show
        Adrian Crum added a comment - This has been discussed on the dev mailing list and there seems to be some disagreement about its benefits. Maybe this should be discussed on the dev mailing list before any work is done.
        Hide
        Erwan de FERRIERES added a comment -

        no problem, I'm starting a thread right now.

        Show
        Erwan de FERRIERES added a comment - no problem, I'm starting a thread right now.
        Hide
        Adrian Crum added a comment -

        GSOC participants should check out the latest code from the repository:

        https://cwiki.apache.org/OFBADMIN/ofbiz-source-repository-and-access.html

        You will notice that OFBiz is divided up into modules or "components" and each component is kept in its own folder. Within each folder there is a single Java source tree. The goal is to have two separate Java source trees within each component - one for deployment and one for testing. The deployment jars should not have test classes in them.

        Create patches for your changes and attach them here - being sure to grant the ASF permission to include your work.For information on creating patches, read the "How to Send in Your Contributions" section here:

        https://cwiki.apache.org/OFBADMIN/ofbiz-contributors-best-practices.html

        Please keep discussions about this GSOC project in this Jira issue - that will make it easier for others to participate.

        Show
        Adrian Crum added a comment - GSOC participants should check out the latest code from the repository: https://cwiki.apache.org/OFBADMIN/ofbiz-source-repository-and-access.html You will notice that OFBiz is divided up into modules or "components" and each component is kept in its own folder. Within each folder there is a single Java source tree. The goal is to have two separate Java source trees within each component - one for deployment and one for testing. The deployment jars should not have test classes in them. Create patches for your changes and attach them here - being sure to grant the ASF permission to include your work.For information on creating patches, read the "How to Send in Your Contributions" section here: https://cwiki.apache.org/OFBADMIN/ofbiz-contributors-best-practices.html Please keep discussions about this GSOC project in this Jira issue - that will make it easier for others to participate.
        Hide
        Ganath Rathnayake added a comment -

        Here am attaching the tree view of the current code and now we can discuss what need to be separated.

        Show
        Ganath Rathnayake added a comment - Here am attaching the tree view of the current code and now we can discuss what need to be separated.
        Hide
        Ganath Rathnayake added a comment -

        This is the folder structure after I edit the git-repo I did not commit this to the git-repo since this cannot be build using existing build.xml. I will commit after I have edit the build.xml.
        thanks

        Show
        Ganath Rathnayake added a comment - This is the folder structure after I edit the git-repo I did not commit this to the git-repo since this cannot be build using existing build.xml. I will commit after I have edit the build.xml. thanks
        Hide
        Adrian Crum added a comment -

        In the accounting folder, the test branch is missing the "org" folder.

        Show
        Adrian Crum added a comment - In the accounting folder, the test branch is missing the "org" folder.
        Hide
        Erwan de FERRIERES added a comment -

        Ganath,

        you may commit directly in your git repo. These way we could also track your changes.
        Adding new messages to this issue is a good practice, keep it this way !

        Show
        Erwan de FERRIERES added a comment - Ganath, you may commit directly in your git repo. These way we could also track your changes. Adding new messages to this issue is a good practice, keep it this way !
        Hide
        Ganath Rathnayake added a comment -

        Thanks Adrian, I'll fixed it.
        Erwan,
        I will commit the changes to the git-repo. Still I didn't figure how to set the public key and I am following your link on git hub to do it.
        thanks

        Show
        Ganath Rathnayake added a comment - Thanks Adrian, I'll fixed it. Erwan, I will commit the changes to the git-repo. Still I didn't figure how to set the public key and I am following your link on git hub to do it. thanks
        Hide
        Erwan de FERRIERES added a comment -

        Hi Ganath,

        everything is here : http://help.github.com/linux-set-up-git/ and http://help.github.com/troubleshooting-ssh/

        I found it well explained, it should help you !

        Show
        Erwan de FERRIERES added a comment - Hi Ganath, everything is here : http://help.github.com/linux-set-up-git/ and http://help.github.com/troubleshooting-ssh/ I found it well explained, it should help you !
        Hide
        Ganath Rathnayake added a comment -

        Here is the new folder structure of the specialpurpose folder after test/code separation.

        Show
        Ganath Rathnayake added a comment - Here is the new folder structure of the specialpurpose folder after test/code separation.

          People

          • Assignee:
            Unassigned
            Reporter:
            Erwan de FERRIERES
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development