Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: SVN trunk
    • Fix Version/s: SVN trunk
    • Component/s: framework
    • Labels:
      None

      Description

      add anchor /cmssite/cms/APACHE_OFBIZ_HTML#CASLDAP so can use it permanent link.

      1. OFBIZ-4174singlesingon.patch
        1.0 kB
        BJ Freeman
      2. OFBIZ-4174singlesingon.patch
        0.9 kB
        BJ Freeman

        Activity

        Hide
        Jacques Le Roux added a comment -

        Feel free to create an issue immediatly if you fear to lose the context

        Show
        Jacques Le Roux added a comment - Feel free to create an issue immediatly if you fear to lose the context
        Hide
        Jacques Le Roux added a comment -

        BJ,

        Finally, at r1069565. I have commited your patch modified with the only anchor in chapter. I close this issue and we should open (a) new one(s) for other anchors if neede

        Thanks

        Show
        Jacques Le Roux added a comment - BJ, Finally, at r1069565. I have commited your patch modified with the only anchor in chapter. I close this issue and we should open (a) new one(s) for other anchors if neede Thanks
        Hide
        Jacques Le Roux added a comment -

        OK, thanks BJ!

        Show
        Jacques Le Roux added a comment - OK, thanks BJ!
        Hide
        BJ Freeman added a comment -

        yeah sorry the docbook.xsd will give an error but will render correctly.
        anchors go before what you want to display.
        the conversion to books I estimate is about 24 manhours including testing, so will not be done for a while.
        need to create a Set at toplevel which means updateding the content resources.
        then redefine all the chapters in documentation folders to books and put them in the set.
        as far as anchors
        use

        <chapter xml:id="ProductCatalogComponent" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"......
        this will show the chapter header with table contents for chapter
        <section xml:id="Standardfeatures">
        this also puts them in the table contents as well as an anchor.

        I will submit a patch for all you listed by tomorrow.

        Show
        BJ Freeman added a comment - yeah sorry the docbook.xsd will give an error but will render correctly. anchors go before what you want to display. the conversion to books I estimate is about 24 manhours including testing, so will not be done for a while. need to create a Set at toplevel which means updateding the content resources. then redefine all the chapters in documentation folders to books and put them in the set. as far as anchors use <chapter xml:id="ProductCatalogComponent" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"...... this will show the chapter header with table contents for chapter <section xml:id="Standardfeatures"> this also puts them in the table contents as well as an anchor. I will submit a patch for all you listed by tomorrow.
        Hide
        Jacques Le Roux added a comment -

        BJ,

        I think we don't need as much answers at the same place. I think one is sufficient, and in chapter has you suggested seems the better way.

        Could you please do the same (without the anchors in title, I mean) for the other anchors? I see it's not possible to put in section, then should be in titles (HELP_PRODUCT_Features.xml) because else it's not rendered (error as shown above)

        I will wait your complete patch to commit them all. If you think/find it's not needed, I will simply commit the current patch, without the anchors in title

        Thanks
        PS: to have an idea of the changes I needed to do, have a look at http://svn.apache.org/viewvc?rev=1069368&view=rev

        Show
        Jacques Le Roux added a comment - BJ, I think we don't need as much answers at the same place. I think one is sufficient, and in chapter has you suggested seems the better way. Could you please do the same (without the anchors in title, I mean) for the other anchors? I see it's not possible to put in section, then should be in titles (HELP_PRODUCT_Features.xml) because else it's not rendered (error as shown above) I will wait your complete patch to commit them all. If you think/find it's not needed, I will simply commit the current patch, without the anchors in title Thanks PS: to have an idea of the changes I needed to do, have a look at http://svn.apache.org/viewvc?rev=1069368&view=rev
        Hide
        BJ Freeman added a comment -

        updated patch

        Show
        BJ Freeman added a comment - updated patch
        Hide
        BJ Freeman added a comment -

        yes I did a quick and dirty.
        anchors can be multiple so I use the Html standard, since putting them in title makes it messy, IHmO
        in reality anything below the anchor will be displayed.
        so I did an ID in the section for CASLDAP which will be an anchor for the chapter.
        seperate anchors for CAS and LDAP for the title.

        I have a hard time with the new layout of the Jira the grey is hard to see for my old eyes. so could not make out you comment with code.

        Show
        BJ Freeman added a comment - yes I did a quick and dirty. anchors can be multiple so I use the Html standard, since putting them in title makes it messy, IHmO in reality anything below the anchor will be displayed. so I did an ID in the section for CASLDAP which will be an anchor for the chapter. seperate anchors for CAS and LDAP for the title. I have a hard time with the new layout of the Jira the grey is hard to see for my old eyes. so could not make out you comment with code.
        Hide
        Jacques Le Roux added a comment -

        Forgot to say that your patch has been applied to trunk at r1069229

        Show
        Jacques Le Roux added a comment - Forgot to say that your patch has been applied to trunk at r1069229
        Hide
        Jacques Le Roux added a comment -

        I updated the trunk at r1069372 and the demo (for the LDAP anchor only)

        Show
        Jacques Le Roux added a comment - I updated the trunk at r1069372 and the demo (for the LDAP anchor only)
        Hide
        Jacques Le Roux added a comment -

        Ha yes, you can put it in the anchor, like
        <title><anchor xml:id="CASLDAP"/>OFBiz Single Sign On using CAS and LDAP</title>

        Could you please handle that and submit a patch?

        TIA

        Show
        Jacques Le Roux added a comment - Ha yes, you can put it in the anchor, like <title><anchor xml:id="CASLDAP"/>OFBiz Single Sign On using CAS and LDAP</title> Could you please handle that and submit a patch? TIA
        Hide
        Jacques Le Roux added a comment -

        Mmm, Maybe there is a better place for anchors (than just below title), because it's a bit lower than the dynamic one, not a big deal, just less clear

        Show
        Jacques Le Roux added a comment - Mmm, Maybe there is a better place for anchors (than just below title), because it's a bit lower than the dynamic one, not a big deal, just less clear
        Hide
        Jacques Le Roux added a comment - - edited

        BTW,I think you can now resonnably use this help feature in trunk. I believe, we have enough resources for that

        =====TYPO=====

        Show
        Jacques Le Roux added a comment - - edited BTW,I think you can now resonnably use this help feature in trunk. I believe, we have enough resources for that =====TYPO=====
        Hide
        Jacques Le Roux added a comment -

        Actually there were some errors in

        • anchors
        • section with id
        • note misplaced
        • > and < chars

        I fixed those that were blocking me, there are still some (minor?) to fix

        before

        [java] 2011-02-10 13:15:54,000 (http-0.0.0.0-8080-1) [          CmsEvents.java:145:INFO ] Path INFO for Alias: APACHE_OFBIZ_HTML
        [java] file:///D:/WorkspaceNew/sparta/applications/commonext/documents/ApacheOfbiz.xml; Line #59; Column #45; Error attempting to parse XML file (href='ApacheOfbizUser.xml').
        

        after

        2011-02-10 13:38:11,843 (http-0.0.0.0-8080-2) [     ControlServlet.java:141:INFO ] [[[APACHE_OFBIZ_HTML] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
        2011-02-10 13:38:11,843 (http-0.0.0.0-8080-2) [          CmsEvents.java:145:INFO ] Path INFO for Alias: APACHE_OFBIZ_HTML
        file:///D:/workspacenew/sparta/applications/content/template/docbook/common/utility.xsl; Line #189; Column #16; Note: namesp. cut : stripped namespace before processing           Apache OFBiz official documentation.
        file:///D:/workspacenew/sparta/applications/content/template/docbook/common/utility.xsl; Line #189; Column #16; Note: namesp. cut : processing stripped document                   Apache OFBiz official documentation.
        file:///D:/workspacenew/sparta/applications/content/template/docbook/html/docbook.xsl; Line #89; Column #16; Element br in namespace '' encountered in para, but no template matches.
        2011-02-10 13:38:31,359 (http-0.0.0.0-8080-2) [     RequestHandler.java:638:INFO ] Ran Event [java:org.ofbiz.content.cms.CmsEvents#cms] from [request], result is [success]
        2011-02-10 13:38:31,375 (http-0.0.0.0-8080-2) [    ConfigXMLReader.java:120:INFO ] controller loaded: 0.0s, 1 requests, 0 views in jndi:/0.0.0.0/cmssite/WEB-INF/controller.xml
        2011-02-10 13:38:31,375 (http-0.0.0.0-8080-2) [    ConfigXMLReader.java:120:INFO ] controller loaded: 0.0s, 31 requests, 17 views in file:/D:/WorkspaceNew/sparta/framework/common/webcommon/WEB-INF/common-controller.xml
        2011-02-10 13:38:31,375 (http-0.0.0.0-8080-2) [     ControlServlet.java:324:INFO ] [[[APACHE_OFBIZ_HTML] Request Done- total:19.532,since last([APACHE_OFBIZ_HTM...):19.532]]
        

        It's committed at r1069368 in trunk. The trunk demo and the FAQ are updated

        Thanks for your help!

        Show
        Jacques Le Roux added a comment - Actually there were some errors in anchors section with id note misplaced > and < chars I fixed those that were blocking me, there are still some (minor?) to fix before [java] 2011-02-10 13:15:54,000 (http-0.0.0.0-8080-1) [ CmsEvents.java:145:INFO ] Path INFO for Alias: APACHE_OFBIZ_HTML [java] file: ///D:/WorkspaceNew/sparta/applications/commonext/documents/ApacheOfbiz.xml; Line #59; Column #45; Error attempting to parse XML file (href='ApacheOfbizUser.xml'). after 2011-02-10 13:38:11,843 (http-0.0.0.0-8080-2) [ ControlServlet.java:141:INFO ] [[[APACHE_OFBIZ_HTML] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]] 2011-02-10 13:38:11,843 (http-0.0.0.0-8080-2) [ CmsEvents.java:145:INFO ] Path INFO for Alias: APACHE_OFBIZ_HTML file: ///D:/workspacenew/sparta/applications/content/template/docbook/common/utility.xsl; Line #189; Column #16; Note: namesp. cut : stripped namespace before processing Apache OFBiz official documentation. file: ///D:/workspacenew/sparta/applications/content/template/docbook/common/utility.xsl; Line #189; Column #16; Note: namesp. cut : processing stripped document Apache OFBiz official documentation. file: ///D:/workspacenew/sparta/applications/content/template/docbook/html/docbook.xsl; Line #89; Column #16; Element br in namespace '' encountered in para, but no template matches. 2011-02-10 13:38:31,359 (http-0.0.0.0-8080-2) [ RequestHandler.java:638:INFO ] Ran Event [java:org.ofbiz.content.cms.CmsEvents#cms] from [request], result is [success] 2011-02-10 13:38:31,375 (http-0.0.0.0-8080-2) [ ConfigXMLReader.java:120:INFO ] controller loaded: 0.0s, 1 requests, 0 views in jndi:/0.0.0.0/cmssite/WEB-INF/controller.xml 2011-02-10 13:38:31,375 (http-0.0.0.0-8080-2) [ ConfigXMLReader.java:120:INFO ] controller loaded: 0.0s, 31 requests, 17 views in file:/D:/WorkspaceNew/sparta/framework/common/webcommon/WEB-INF/common-controller.xml 2011-02-10 13:38:31,375 (http-0.0.0.0-8080-2) [ ControlServlet.java:324:INFO ] [[[APACHE_OFBIZ_HTML] Request Done- total:19.532,since last([APACHE_OFBIZ_HTM...):19.532]] It's committed at r1069368 in trunk. The trunk demo and the FAQ are updated Thanks for your help!
        Hide
        BJ Freeman added a comment -

        updated http://demo-trunk.businessesnetwork.com/cmssite/cms/APACHE_OFBIZ_HTML#CASLDAP
        possibly you did not refresh(reload) the page after adding the patch.

        Show
        BJ Freeman added a comment - updated http://demo-trunk.businessesnetwork.com/cmssite/cms/APACHE_OFBIZ_HTML#CASLDAP possibly you did not refresh(reload) the page after adding the patch.
        Hide
        Jacques Le Roux added a comment -

        Great, thanks BJ!

        I see it works well on your site at http://demo-trunk.businessesnetwork.com/cmssite/cms/APACHE_OFBIZ_HTML#N23A7F (not yet CASLDAP BTW)
        But, after applying patch, I can't access locally to http://localhost:8080/cmssite/cms/APACHE_OFBIZ_HTML#CASLDAP, rather I get a blank page.
        Same for http://localhost:8080/cmssite/cms/APACHE_OFBIZ_HTML#N23A7F BTW
        Same also on trunk demo for http://demo-trunk.ofbiz.apache.org/cmssite/cms/APACHE_OFBIZ_HTML#N23A7F

        What I'm missing?

        Thanks

        Show
        Jacques Le Roux added a comment - Great, thanks BJ! I see it works well on your site at http://demo-trunk.businessesnetwork.com/cmssite/cms/APACHE_OFBIZ_HTML#N23A7F (not yet CASLDAP BTW) But, after applying patch, I can't access locally to http://localhost:8080/cmssite/cms/APACHE_OFBIZ_HTML#CASLDAP , rather I get a blank page. Same for http://localhost:8080/cmssite/cms/APACHE_OFBIZ_HTML#N23A7F BTW Same also on trunk demo for http://demo-trunk.ofbiz.apache.org/cmssite/cms/APACHE_OFBIZ_HTML#N23A7F What I'm missing? Thanks

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            BJ Freeman
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development