OFBiz
  1. OFBiz
  2. OFBIZ-4132

Not all pdf rendering links render to a new (_blank) target_window

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: SVN trunk
    • Fix Version/s: SVN trunk
    • Component/s: ALL APPLICATIONS
    • Labels:
      None

      Description

      In various application pdf files can be rendered. However, not all statements include a target-window="_BLANK" instruction. Without this instruction te pdf's are rendered in the browser window where the user accessing the ofbiz environment. This is an undesirable situation as it lessens the user experience

      There are no Sub-Tasks for this issue.

        Activity

        Pierre Smits created issue -
        Hide
        Scott Gray added a comment -

        This issue isn't of much use unless you point us to the actual links...

        Show
        Scott Gray added a comment - This issue isn't of much use unless you point us to the actual links...
        Hide
        Pierre Smits added a comment -

        What were your expectations, Scot?

        Show
        Pierre Smits added a comment - What were your expectations, Scot?
        Hide
        BJ Freeman added a comment -

        steps reproduce

        Show
        BJ Freeman added a comment - steps reproduce
        Hide
        Jacques Le Roux added a comment -

        I guess we have to look for where PDF files are generated and from there check that they are generated in a new window. There are 83 content-type="application/pdf" in controllers (birt and fop). I'd suggest to look for 5 each day, if Pierre, Scott BJ and I do it it will be no more than 5 days...We have just to choose where each work...

        Show
        Jacques Le Roux added a comment - I guess we have to look for where PDF files are generated and from there check that they are generated in a new window. There are 83 content-type="application/pdf" in controllers (birt and fop). I'd suggest to look for 5 each day, if Pierre, Scott BJ and I do it it will be no more than 5 days...We have just to choose where each work...
        Hide
        Jacques Le Roux added a comment -

        BTW, we could use the same technic to replace javascript calls by submit where it's possible. By and large if we could agree to use a such strategy on large and repetitive tasks we could be more successful. All we need is a bit of good wills and exchanges in dev ML (maybe even a page on wiki for larger enrolment). Is that really impossible?

        Show
        Jacques Le Roux added a comment - BTW, we could use the same technic to replace javascript calls by submit where it's possible. By and large if we could agree to use a such strategy on large and repetitive tasks we could be more successful. All we need is a bit of good wills and exchanges in dev ML (maybe even a page on wiki for larger enrolment). Is that really impossible?
        Hide
        Pierre Smits added a comment -

        I will do some analysis on the pdf issue. And will create per application a sub task. From there on we could split up the effort.

        Show
        Pierre Smits added a comment - I will do some analysis on the pdf issue. And will create per application a sub task. From there on we could split up the effort.
        Hide
        Jacques Le Roux added a comment -

        Done!

        Show
        Jacques Le Roux added a comment - Done!
        Jacques Le Roux made changes -
        Field Original Value New Value
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Jacques Le Roux [ jacques.le.roux ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Pierre Smits
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development