OFBiz
  1. OFBiz
  2. OFBIZ-4118

Some misc issues in ebay and ebayStore component.

    Details

      Description

      Following issues are exists in ebay and ebayStore component

      1. Not getting ebay sub category from parent category on Export Product Listing screen of ebayStore component.

      2. Error in getting category lookup form on Export Product Listing screen of ebayStore component..

      3. JS is blocking during Export Product to ebay from ebay component.

      1. ofbiz-4118-ebay.patch
        2 kB
        Arun Patidar
      2. ofbiz-4118-ebayStore.patch
        8 kB
        Arun Patidar
      3. ofbiz-4118-ebayStore.patch
        5 kB
        Arun Patidar
      4. ExportToEbay.patch
        1 kB
        Arun Patidar
      5. ExportProductToEbay-ofbiz-4118.patch
        7 kB
        Arun Patidar
      6. import-order-ofbiz-4118.patch
        2 kB
        Arun Patidar
      7. setShipmentMethod-ebay-ofbiz-4118.patch
        1 kB
        Arun Patidar
      8. Set-Complete-Status-ofbiz-4118.patch
        17 kB
        Arun Patidar
      9. Set-Complete-Status-ofbiz-4118.patch
        17 kB
        Arun Patidar
      10. 10.04-ofbiz-4118.patch
        10 kB
        Arun Patidar
      11. export-multiple-products-ofbiz-4118.patch
        8 kB
        Arun Patidar
      12. OFBIZ-4118.patch
        5 kB
        Ankit Jain
      13. OFBIZ-4118.patch
        8 kB
        Ankit Jain
      14. Store-Category-Ofbiz-4118.patch
        19 kB
        Arun Patidar

        Activity

        Hide
        Arun Patidar added a comment -

        Hi Jacques,

        For now you can close this issue. I will create new task if required.

        Show
        Arun Patidar added a comment - Hi Jacques, For now you can close this issue. I will create new task if required.
        Hide
        Jacques Le Roux added a comment -

        Hi Arun, Ankit, Anil,

        I'd like to close this issue if nothing is still pending, do you agree?

        Show
        Jacques Le Roux added a comment - Hi Arun, Ankit, Anil, I'd like to close this issue if nothing is still pending, do you agree?
        Hide
        Jacques Le Roux added a comment -

        Thanks Arun,

        Your patch is in trunk at r1095024 (only reviewed did not find time to test)

        Show
        Jacques Le Roux added a comment - Thanks Arun, Your patch is in trunk at r1095024 (only reviewed did not find time to test)
        Hide
        Ankit Jain added a comment -

        Thanks Jacques

        Show
        Ankit Jain added a comment - Thanks Jacques
        Hide
        Arun Patidar added a comment -

        Hi Jacques,

        Attached a patch to fix issue of getting store categories in ebay store component during product export functionality. Added a new method to get store categories and made fixes in existing code.


        Arun

        Show
        Arun Patidar added a comment - Hi Jacques, Attached a patch to fix issue of getting store categories in ebay store component during product export functionality. Added a new method to get store categories and made fixes in existing code. — Arun
        Hide
        Jacques Le Roux added a comment -

        Thanks Ankit,

        Well done, I only reviewed (not tested) but I'm confident: very orthodox. Your patch is in trunk at r1094868

        Show
        Jacques Le Roux added a comment - Thanks Ankit, Well done, I only reviewed (not tested) but I'm confident: very orthodox. Your patch is in trunk at r1094868
        Hide
        Ankit Jain added a comment -

        I have done a minor improvement in ebay store.

        In the ebay account added a screen to add catalog to store , so one can add the catalogs to ebay store.

        After selecting an account, it redirect us to ebay account page, and here is the screen https://localhost:8443/ebaystore/control/AssociateCatalog?productStoreId=90101
        so one can add the catalog to ebay store.

        Show
        Ankit Jain added a comment - I have done a minor improvement in ebay store. In the ebay account added a screen to add catalog to store , so one can add the catalogs to ebay store. After selecting an account, it redirect us to ebay account page, and here is the screen https://localhost:8443/ebaystore/control/AssociateCatalog?productStoreId=90101 so one can add the catalog to ebay store.
        Hide
        Ankit Jain added a comment -

        Thanks Jacques.

        Show
        Ankit Jain added a comment - Thanks Jacques.
        Hide
        Jacques Le Roux added a comment -

        Ankit,

        OK I can't see a better way anyway, your patch si in trunk at r1094281

        Thanks

        Show
        Jacques Le Roux added a comment - Ankit, OK I can't see a better way anyway, your patch si in trunk at r1094281 Thanks
        Hide
        Ankit Jain added a comment -

        Hi Jacques,

        I have just changed the siteName because there are two website having the same name, its not necessary to commit as its a demo data. I made changes to avoid confusion between the two websites showing in the website dropdown.

        Show
        Ankit Jain added a comment - Hi Jacques, I have just changed the siteName because there are two website having the same name, its not necessary to commit as its a demo data. I made changes to avoid confusion between the two websites showing in the website dropdown.
        Hide
        Jacques Le Roux added a comment -

        Hi Ankit,

        I was ready to commit your patch but suddenly I wondered: does "http://demo.ofbiz.org" make any sense in data?

        Show
        Jacques Le Roux added a comment - Hi Ankit, I was ready to commit your patch but suddenly I wondered: does "http://demo.ofbiz.org" make any sense in data?
        Hide
        Ankit Jain added a comment -

        On the Ebay Configuration search page (https://localhost:8443/ebaystore/control/FindEbayConfigurations) a default value "EBAY_STORE" is shown selected and after search the same value is shown instead of the value we selected before clicking on find and same case on on Edit Ebay Configuration page (https://localhost:8443/ebaystore/control/EditEbayConfiguration?productStoreId=9000).

        The attached patch fixed this problem also fixed the website data.

        Show
        Ankit Jain added a comment - On the Ebay Configuration search page ( https://localhost:8443/ebaystore/control/FindEbayConfigurations ) a default value "EBAY_STORE" is shown selected and after search the same value is shown instead of the value we selected before clicking on find and same case on on Edit Ebay Configuration page ( https://localhost:8443/ebaystore/control/EditEbayConfiguration?productStoreId=9000 ). The attached patch fixed this problem also fixed the website data.
        Hide
        Jacques Le Roux added a comment -

        Thanks Arun,

        Your patch is trunk at r1064751

        Show
        Jacques Le Roux added a comment - Thanks Arun, Your patch is trunk at r1064751
        Hide
        Jacques Le Roux added a comment -

        Thanks Arun,

        10.04-ofbiz-4118.patch is in R10.04 at r1064662

        Show
        Jacques Le Roux added a comment - Thanks Arun, 10.04-ofbiz-4118.patch is in R10.04 at r1064662
        Hide
        Arun Patidar added a comment -

        Hi Jacques,

        Attaching patch to fix following issues in ebayStore component

        1. Now user can export more than one product to ebay by selecting more than one product and processing them one by one.

        2 Show error messages to user in case of any exception.

        Thanks

        Show
        Arun Patidar added a comment - Hi Jacques, Attaching patch to fix following issues in ebayStore component 1. Now user can export more than one product to ebay by selecting more than one product and processing them one by one. 2 Show error messages to user in case of any exception. Thanks
        Hide
        Arun Patidar added a comment -

        Hi Jacques,

        Ofbiz order always shows payment in NOT_RECEIVED status while payment has been received by ebay, So I think its a fix.

        Thanks.

        Show
        Arun Patidar added a comment - Hi Jacques, Ofbiz order always shows payment in NOT_RECEIVED status while payment has been received by ebay, So I think its a fix. Thanks.
        Hide
        Jacques Le Roux added a comment -

        Hi Arun,

        Are you sure the paid stuff is a fix?

        Show
        Jacques Le Roux added a comment - Hi Arun, Are you sure the paid stuff is a fix?
        Hide
        Arun Patidar added a comment -

        Hi Jacques,

        I am attaching a patch for bug fixes in 10.04, which are already fixed in trunk at r1063265. This patch does not include any missing functionality.

        Thanks

        Show
        Arun Patidar added a comment - Hi Jacques, I am attaching a patch for bug fixes in 10.04, which are already fixed in trunk at r1063265. This patch does not include any missing functionality. Thanks
        Hide
        Jacques Le Roux added a comment -

        Hi Arun,

        I'd be ok with it, but it must be discussed in dev ML 1st

        Thanks

        Show
        Jacques Le Roux added a comment - Hi Arun, I'd be ok with it, but it must be discussed in dev ML 1st Thanks
        Hide
        Arun Patidar added a comment -

        Hi Jacques,

        Some ebayStore functionalities are missing in 10.04 such as functionality of import order from ebay. So should we back port that missing functionality in 10.04 release. Because without that functionality I think ebayStore is worthless in 10.04. WDYT?

        Thanks & Regards

        Arun Patidar

        Show
        Arun Patidar added a comment - Hi Jacques, Some ebayStore functionalities are missing in 10.04 such as functionality of import order from ebay. So should we back port that missing functionality in 10.04 release. Because without that functionality I think ebayStore is worthless in 10.04. WDYT? Thanks & Regards — Arun Patidar
        Hide
        Jacques Le Roux added a comment -

        Thanks Arun,

        Your patch is in trunk at r1063265

        Show
        Jacques Le Roux added a comment - Thanks Arun, Your patch is in trunk at r1063265
        Hide
        Arun Patidar added a comment -

        Hi Jacques,

        Yes, you are right. I am uploading new updated patch for same.

        Thanks.

        Show
        Arun Patidar added a comment - Hi Jacques, Yes, you are right. I am uploading new updated patch for same. Thanks.
        Hide
        Jacques Le Roux added a comment -

        Hi Arun,

        I just wonder why you added " if (previousIndex != -1) {" in this snippet:

        +        if (previouslyAddedItemInCart != null) {
        +            previousIndex = cart.getItemIndex(previouslyAddedItemInCart);
        +            if (previousIndex != -1) {
        

        Is it not superfluous?

        Show
        Jacques Le Roux added a comment - Hi Arun, I just wonder why you added " if (previousIndex != -1) {" in this snippet: + if (previouslyAddedItemInCart != null ) { + previousIndex = cart.getItemIndex(previouslyAddedItemInCart); + if (previousIndex != -1) { Is it not superfluous?
        Hide
        Arun Patidar added a comment -

        Hi Jacques,

        Thanks for committing patches. Attaching one more patch to fix following issues in ebay and ebayStore component

        1 Fixed issue of set complete order status in ebay when we complete order in ofbiz.

        2 Created record of OrderPaymentPreference in PAYMENT_RECEIVED status.

        3 Updated qty of cart item, if same product is adding again in cart during import order from ebay.

        4 Set transactionId in cart.

        Thanks.

        Show
        Arun Patidar added a comment - Hi Jacques, Thanks for committing patches. Attaching one more patch to fix following issues in ebay and ebayStore component 1 Fixed issue of set complete order status in ebay when we complete order in ofbiz. 2 Created record of OrderPaymentPreference in PAYMENT_RECEIVED status. 3 Updated qty of cart item, if same product is adding again in cart during import order from ebay. 4 Set transactionId in cart. Thanks.
        Hide
        Jacques Le Roux added a comment - - edited

        Patches backported to R10.04 (in respective order) at r1062176, r1062215, r1062217, r1062219, r1062223, r1062226

        I had to handle conflicts by hand for most of them

        Show
        Jacques Le Roux added a comment - - edited Patches backported to R10.04 (in respective order) at r1062176, r1062215, r1062217, r1062219, r1062223, r1062226 I had to handle conflicts by hand for most of them
        Hide
        Jacques Le Roux added a comment -

        Anil,

        Yes you are right, I will do...

        Show
        Jacques Le Roux added a comment - Anil, Yes you are right, I will do...
        Hide
        Anil K Patel added a comment -

        Jacques,
        All the patches provided by Arun are fixing some issue in ebaystore application, Should we not apply them to 10.04 branch as well?

        Show
        Anil K Patel added a comment - Jacques, All the patches provided by Arun are fixing some issue in ebaystore application, Should we not apply them to 10.04 branch as well?
        Hide
        Jacques Le Roux added a comment -

        Thans for the information Arun,

        I think we should extract the needed from ebay to ebaystore and then from ebay, hopefully it's not too much work.

        But it's not the only dependency, EbayShippingMethod entity is also set in DemoEbayData.xml and used in EbayHelpData.xml.

        Your patch is in trunk at r1062152

        Show
        Jacques Le Roux added a comment - Thans for the information Arun, I think we should extract the needed from ebay to ebaystore and then from ebay, hopefully it's not too much work. But it's not the only dependency, EbayShippingMethod entity is also set in DemoEbayData.xml and used in EbayHelpData.xml. Your patch is in trunk at r1062152
        Hide
        Arun Patidar added a comment -

        Hi Jacques,

        I am attaching one more patch for setting shipping method in ofbiz order during import order by ebayStore component.
        FYI here ebayStore component is using EbayHelper class of ebay component, so there is dependency of ebayStore component on ebay component.

        Thanks

        Show
        Arun Patidar added a comment - Hi Jacques, I am attaching one more patch for setting shipping method in ofbiz order during import order by ebayStore component. FYI here ebayStore component is using EbayHelper class of ebay component, so there is dependency of ebayStore component on ebay component. Thanks
        Hide
        Jacques Le Roux added a comment -

        Thanks Arun,

        Your patch is in trunk at r1062144

        Show
        Jacques Le Roux added a comment - Thanks Arun, Your patch is in trunk at r1062144
        Hide
        Arun Patidar added a comment -

        Hi Jacques,

        Attaching a patch to fix issue of import ebay orders.
        Thanks.

        Show
        Arun Patidar added a comment - Hi Jacques, Attaching a patch to fix issue of import ebay orders. Thanks.
        Hide
        Jacques Le Roux added a comment -

        Arun,

        Your patch is in trunk at r1061939. I let you close the issue when you are done. BTW, do you know what the key diffs between ebay and ebay store components and why we have both?

        Thanks

        Show
        Jacques Le Roux added a comment - Arun, Your patch is in trunk at r1061939. I let you close the issue when you are done. BTW, do you know what the key diffs between ebay and ebay store components and why we have both? Thanks
        Hide
        Arun Patidar added a comment -

        Attaching patch to export single product to ebay in ebay store component. Added require attributes in item and call request of export product to ebay after successfully verify item.

        Show
        Arun Patidar added a comment - Attaching patch to export single product to ebay in ebay store component. Added require attributes in item and call request of export product to ebay after successfully verify item.
        Hide
        Arun Patidar added a comment -

        I am still working on some issues. I will provide a patch soon.

        Show
        Arun Patidar added a comment - I am still working on some issues. I will provide a patch soon.
        Hide
        Jacques Le Roux added a comment -

        Thanks Arun,

        Your patch is in trunk at r1061346

        Show
        Jacques Le Roux added a comment - Thanks Arun, Your patch is in trunk at r1061346
        Hide
        Jacques Le Roux added a comment -

        Hi Arun,

        Thanks for the use case.

        I 1st got caught by the surprising behaviour of the eBay Category drop down (you have to select sub-categs one after the others in the same drop drow), but yes it works.
        Who defined this behaviour? Did you find this original way somewhere or was it created from scratch? It's really misleading when you 1st come to it...

        Anyway your patch is in trunk at r1061307

        Show
        Jacques Le Roux added a comment - Hi Arun, Thanks for the use case. I 1st got caught by the surprising behaviour of the eBay Category drop down (you have to select sub-categs one after the others in the same drop drow), but yes it works. Who defined this behaviour? Did you find this original way somewhere or was it created from scratch? It's really misleading when you 1st come to it... Anyway your patch is in trunk at r1061307
        Hide
        Arun Patidar added a comment -


        I am attaching one more patch for an issue in ebay component. Ebay category code may have more than 3 character so removed condition of ebay category code length.

        Show
        Arun Patidar added a comment - I am attaching one more patch for an issue in ebay component. Ebay category code may have more than 3 character so removed condition of ebay category code length.
        Hide
        Arun Patidar added a comment -

        Hi Jacques,

        I have uploaded updated patch for ebay store component issues and provided steps to test. Please have a look and let me know if there is any issues.
        Thanks in advance.

        Show
        Arun Patidar added a comment - Hi Jacques, I have uploaded updated patch for ebay store component issues and provided steps to test. Please have a look and let me know if there is any issues. Thanks in advance.
        Hide
        Arun Patidar added a comment -

        Hi Jacques,

        Thanks for committing ebay component patch and pointing this. Functionality is working fine without changes of EbayStoreOptions.java file. So I am uploading new updated patch.

        Steps to test issue:

        #1. Go to ebayStore -> main

        #2 Select any demo user account and click on submit

        #3 Click on Export Product Listing tab in menu

        #4 Search any product from find screen

        #5 Select product from list and click on Export To Ebay button

        #6 Select any ebay category from drop down

        #7 Change event of this select box is not working properly due to blocking of JS.


        Thanks

        Show
        Arun Patidar added a comment - Hi Jacques, Thanks for committing ebay component patch and pointing this. Functionality is working fine without changes of EbayStoreOptions.java file. So I am uploading new updated patch. Steps to test issue: #1. Go to ebayStore -> main #2 Select any demo user account and click on submit #3 Click on Export Product Listing tab in menu #4 Search any product from find screen #5 Select product from list and click on Export To Ebay button #6 Select any ebay category from drop down #7 Change event of this select box is not working properly due to blocking of JS. – Thanks
        Hide
        Jacques Le Roux added a comment -

        Hi Arun,

        I have commited the ebay component patch in trunk at r1060236

        About the abasy store component I have a question about a trivial detail, I see it's not a problem to apply

        -                    if (categories.size() > 0) {
        -                        toJsonObjectList(categories,response);
        -                    }
        +                    toJsonObjectList(categories,response);
        

        But I'd prefer to keep it, since it avoids an useless call

        Also are you sure it's safe to apply this snippet?

        -        if (list != null) {
        -            for (Map<String,Object> val : list) {
        -                json = new JSONObject();
        -                for (String rowKey: val.keySet()) {
        -                    json.put(rowKey, val.get(rowKey));
        -                }
        -                jsonList.add(json);
        +        String jsonStr = null;
        +        for (Map<String,Object> val : list) {
        

        What if list is null, the enhanced foor loop does not guarantee no NPE in this case

        Else your patch sounds good to me, but I'm not quite sure how to test it as I have never used this component. Could you give some hints please?

        Thanks

        Show
        Jacques Le Roux added a comment - Hi Arun, I have commited the ebay component patch in trunk at r1060236 About the abasy store component I have a question about a trivial detail, I see it's not a problem to apply - if (categories.size() > 0) { - toJsonObjectList(categories,response); - } + toJsonObjectList(categories,response); But I'd prefer to keep it, since it avoids an useless call Also are you sure it's safe to apply this snippet? - if (list != null ) { - for (Map< String , Object > val : list) { - json = new JSONObject(); - for ( String rowKey: val.keySet()) { - json.put(rowKey, val.get(rowKey)); - } - jsonList.add(json); + String jsonStr = null ; + for (Map< String , Object > val : list) { What if list is null, the enhanced foor loop does not guarantee no NPE in this case Else your patch sounds good to me, but I'm not quite sure how to test it as I have never used this component. Could you give some hints please? Thanks
        Hide
        Arun Patidar added a comment -

        Here is patches for same.

        Show
        Arun Patidar added a comment - Here is patches for same.

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Arun Patidar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development