[OFBIZ-4114] ServiceUtil.returnError called but its result not returned

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: Release Branch 09.04, Release Branch 10.04, Trunk
• Component/s: accounting

Environment

rev 1058379

• Assignee: Jacques Le Roux
• Reporter: Paul Foxworthy
• Created: 13/Jan/11 04:23
• Updated: 25/Jan/11 13:21
• Resolved: 18/Jan/11 14:10

Description

In applications/accounting/src/org/ofbiz/accounting/Invoice/InvoiceServices.java, there are numerous calls to ServiceUtil.returnError where nothing is done with the result of the call. Surely a

return ServiceUtil.returnError

was intended?

A grep turned up one other place with a similar problem, PosTransaction.java .

Patches attached.