OFBiz
  1. OFBiz
  2. OFBIZ-4104

add taxPercentage and taxTotal member variables to ShoppingCartItem to ease tax calculation and display

    Details

    • Type: Improvement Improvement
    • Status: Reopened
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: Trunk
    • Fix Version/s: None
    • Component/s: order
    • Labels:
      None
    • Sprint:
      Bug Crush Event - 21/2/2015

      Description

      Legal requirements in Germany mandate that tax-information is displayed for each shopping cart item. This is supported by the proposed improvement.

        Activity

        Hide
        Jacques Le Roux added a comment -

        Thanks Jonas,

        This is a nice improvement. But please in the future provide patches with no absolute pathes. Your patch did not apply until I removed the a/ and b/...

        Your patch is in trunk at r1057571

        Show
        Jacques Le Roux added a comment - Thanks Jonas, This is a nice improvement. But please in the future provide patches with no absolute pathes. Your patch did not apply until I removed the a/ and b/... Your patch is in trunk at r1057571
        Hide
        Jacques Le Roux added a comment -

        Finally I revert, here is message from David E. Jones in dev ML : http://markmail.org/message/dod2fbvmi7tsoi2t

        I hate seeing stuff like this committed in this way.

        Was there any review and discussion of where tax data is currently stored in the cart item? What about more complex tax cases (like multiple tax authorities, happens with VAT too...) where these simple numbers are not so useful and my be misleading? What about cases where tax values change and the price doesn't (yep, it's in the code...).

        This code is already full of stuff that is unused, or that if used will cause problems. Why add more without review?

        These methods could very well exist, but the data shouldn't come from there... it should come from the tax adjustments associated with the item.

        -David

        Show
        Jacques Le Roux added a comment - Finally I revert, here is message from David E. Jones in dev ML : http://markmail.org/message/dod2fbvmi7tsoi2t I hate seeing stuff like this committed in this way. Was there any review and discussion of where tax data is currently stored in the cart item? What about more complex tax cases (like multiple tax authorities, happens with VAT too...) where these simple numbers are not so useful and my be misleading? What about cases where tax values change and the price doesn't (yep, it's in the code...). This code is already full of stuff that is unused, or that if used will cause problems. Why add more without review? These methods could very well exist, but the data shouldn't come from there... it should come from the tax adjustments associated with the item. -David
        Hide
        Jacques Le Roux added a comment -

        Reverted at r1057580

        Show
        Jacques Le Roux added a comment - Reverted at r1057580
        Hide
        Jacques Le Roux added a comment -

        Jonas,

        I must say I did not thought much about it. Now David gave you a clue...

        Show
        Jacques Le Roux added a comment - Jonas, I must say I did not thought much about it. Now David gave you a clue...

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Jonas Hoef
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development

                Agile