Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: Trunk
    • Labels:
      None

      Description

      Rohit reported a bug in the jQuery implementation (ecommerce)

      hi..
      with the jQuery branch being merged into the trunk, 2 new issues have been identified in the onepagecheckout, and they are:

      1) the remove item link does not work in the shoppingcart panel, and
      2) the cart is not updated if cart quantity is changed or promo codes are entered.

      Rohit

      Thanks Rhoit, i fix this next week.

      Cheers
      Sascha

      1. OFBIZ-4067_FixOnePageCheckout.patch
        4 kB
        Sascha Rodekamp
      2. OFBIZ-4067_FixOnePageCheckout.patch
        2 kB
        Sascha Rodekamp

        Activity

        Sascha Rodekamp created issue -
        Sascha Rodekamp made changes -
        Field Original Value New Value
        Attachment OFBIZ-4067_FixOnePageCheckout.patch [ 12466625 ]
        Hide
        Sascha Rodekamp added a comment -

        And here is the patch file.

        Cheers
        Sascha

        Show
        Sascha Rodekamp added a comment - And here is the patch file. Cheers Sascha
        Hide
        Jacques Le Roux added a comment -

        Hi Sascha,

        i just tried your patch...although it fixes the errors for removing the item
        and for applying the promo code...i think it still does not fully solve the
        problem when the quantities in the shopping cart are changed.

        it works, when the quantity is changed for the first time...but if you
        change it again it does not work.

        for eg..if you add 4 of products X to the cart..and then change the quantity
        to 6...the shopping cart is correctly updated. However..if you change the
        quantity again to any number..the cart is not updated. you have to move to
        step 2 and then back to the cart to edit the quantity...if effect you can
        change the cart only once..

        i think a customer should be able to change the quantity any number of
        times, before moving to the next step.

        thanks,

        rohit

        Show
        Jacques Le Roux added a comment - Hi Sascha, i just tried your patch...although it fixes the errors for removing the item and for applying the promo code...i think it still does not fully solve the problem when the quantities in the shopping cart are changed. it works, when the quantity is changed for the first time...but if you change it again it does not work. for eg..if you add 4 of products X to the cart..and then change the quantity to 6...the shopping cart is correctly updated. However..if you change the quantity again to any number..the cart is not updated. you have to move to step 2 and then back to the cart to edit the quantity...if effect you can change the cart only once.. i think a customer should be able to change the quantity any number of times, before moving to the next step. thanks, rohit
        Hide
        Jacques Le Roux added a comment -

        Hi Sascha,

        i just found that the onepagecheckout does not work at all with 'internet
        explorer'. i tried with IE & and their is no response at all. the cart in
        not updated and neither does it move to the next step.

        thanks

        Rohit

        Show
        Jacques Le Roux added a comment - Hi Sascha, i just found that the onepagecheckout does not work at all with 'internet explorer'. i tried with IE & and their is no response at all. the cart in not updated and neither does it move to the next step. thanks Rohit
        Hide
        Sascha Rodekamp added a comment -

        Hi guys,
        ok i will check today and to fix the issues.

        Thanks for reporting.
        Sascha

        Show
        Sascha Rodekamp added a comment - Hi guys, ok i will check today and to fix the issues. Thanks for reporting. Sascha
        Hide
        Sascha Rodekamp added a comment -

        There was a caching problem in the IE, that's way the second change doesn't work. I also fix an issue for the IE7

        Works now in IE 7 & 8 and FF as well

        Cheers
        Sascha

        Show
        Sascha Rodekamp added a comment - There was a caching problem in the IE, that's way the second change doesn't work. I also fix an issue for the IE7 Works now in IE 7 & 8 and FF as well Cheers Sascha
        Sascha Rodekamp made changes -
        Attachment OFBIZ-4067_FixOnePageCheckout.patch [ 12466699 ]
        Hide
        Rohit Sureka added a comment -

        HI Sascha,

        i tried your latest patch and it works really fine. The issues reported in this Jira, have now been addressed.

        There however needs some more work to be done in onePageCheckout, like showing multiple addresses as options to a returning customer and also supporting multiple payment options supported by ofbiz and not just credit card. I am not sure, if these features requests should be enlisted in this Jira, as they were never part of the original onepagecheckout, in the first place.

        Thanks for the great work.

        Rohit

        Show
        Rohit Sureka added a comment - HI Sascha, i tried your latest patch and it works really fine. The issues reported in this Jira, have now been addressed. There however needs some more work to be done in onePageCheckout, like showing multiple addresses as options to a returning customer and also supporting multiple payment options supported by ofbiz and not just credit card. I am not sure, if these features requests should be enlisted in this Jira, as they were never part of the original onepagecheckout, in the first place. Thanks for the great work. Rohit
        Hide
        Sascha Rodekamp added a comment -

        Hi Rohit,
        thanks for your testing. I think this patch can be commited and the task can be closed.

        For the other things we can open a new task, because the describes function are not related to this bug .. that keeps things clear.

        Have a good day
        Sascha

        Show
        Sascha Rodekamp added a comment - Hi Rohit, thanks for your testing. I think this patch can be commited and the task can be closed. For the other things we can open a new task, because the describes function are not related to this bug .. that keeps things clear. Have a good day Sascha
        Jan le Roux committed 1056672 (1 file)
        Reviews: none

        A patch from Sascha Rodekamp "jQuery ecommerce onepagecheckout issue" (https://issues.apache.org/jira/browse/OFBIZ-4067) - OFBIZ-4067

        Rohit reported a bug in the jQuery implementation (ecommerce):
        With the jQuery branch being merged into the trunk, 2 new issues have been identified in the onepagecheckout, and they are:
            1) the remove item link does not work in the shoppingcart panel, and
            2) the cart is not updated if cart quantity is changed or promo codes are entered.

        There was also a caching problem in IE.

        Hide
        Jacques Le Roux added a comment -

        Thanks Sascha and Rohit,

        Sascha your patch is in trunk at r1056672

        Thanks Rohit for testing!

        Show
        Jacques Le Roux added a comment - Thanks Sascha and Rohit, Sascha your patch is in trunk at r1056672 Thanks Rohit for testing!
        Jacques Le Roux made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Jacques Le Roux [ jacques.le.roux ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Sascha Rodekamp
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development