[OFBIZ-4038] Rounding error in prorating returned adjustments

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Release Branch 09.04, Release 09.04, Release Branch 10.04
• Fix Version/s: Release Branch 09.04, Release Branch 10.04, Trunk
• Assignee: Jacques Le Roux
• Reporter: Wickersheimer Jeremy
• Created: 29/Nov/10 10:55
• Updated: 04/Dec/10 10:40
• Resolved: 03/Dec/10 22:42

Description

The error is in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java the getAdjustmentAmount method is prorating using this code:

newAmount = returnTotal.divide(originalTotal, decimals, rounding).multiply(amount).setScale(decimals, rounding);

it should be:

newAmount = returnTotal.multiply(amount).divide(originalTotal, decimals, rounding);

else by dividing first what should be for example 1/3 of the adjustment ends up being 0.33