OFBiz
  1. OFBiz
  2. OFBIZ-4037

Moving the user SignUp feature from MyPortal to the Framework

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Incomplete
    • Affects Version/s: Trunk
    • Fix Version/s: None
    • Component/s: framework
    • Labels:
      None

      Description

      Hi Devs!
      In the attached patch I have reworked the feature that allows a new user to SignUp for an account.
      This feature is actually only available when logging in at the MyPortal application.
      Well, IMO it should be centrally available so that the login screen is exactly the same regardless of the application.
      The Captcha feature is already implemented (captcha.java) partially in the framework and so this patch should be seen as a clean up also.

      I added full internationalization of all labels and created some labels in the CommonUiLabels.xml file.

      I would like some review so that I could then commit if nobody finds something wrong.

      By the way, there is for sure some improvement that could be done at a later stage:

      • Eliminate the labels that have been created in the CommonUiLabels from Party and MyPortal
      • Add an encription of the Captcha code so that it will not be easily broken by robots.

      Thank you for any comment you could provide.

        Activity

        Hide
        Bruno Busco added a comment -

        Hi,
        I would like to commit this patch.
        Does somebody see any issue?

        I would set the OOTB values for the configuration parameters so that the SignUp feature is enabled with Captcha code check.
        Are you OK with this setting or do you think that by default the feature should be disabled?
        Right now we have that it is disabled on all application but MyPortal.
        After the patch the feature will be enabled/disabled for all applications.

        Show
        Bruno Busco added a comment - Hi, I would like to commit this patch. Does somebody see any issue? I would set the OOTB values for the configuration parameters so that the SignUp feature is enabled with Captcha code check. Are you OK with this setting or do you think that by default the feature should be disabled? Right now we have that it is disabled on all application but MyPortal. After the patch the feature will be enabled/disabled for all applications.
        Hide
        Bruno Busco added a comment -

        As Hans suggests on the dev ML having the feature enabled would be better to show OOTB the feature.
        Thank you Hans.

        Show
        Bruno Busco added a comment - As Hans suggests on the dev ML having the feature enabled would be better to show OOTB the feature. Thank you Hans.
        Hide
        Bruno Busco added a comment -

        Committed to the trunk At revision: 1042196

        Show
        Bruno Busco added a comment - Committed to the trunk At revision: 1042196
        Hide
        Bruno Busco added a comment -

        The commit has been reverted as suggested by Adam.
        The reason was that the patch adds in the framework several dependencies from the applications (mainly Party).
        A rework must be done.
        A possible solution could be to move the register stuff to the commonext component instead of common.
        What do you think?

        Show
        Bruno Busco added a comment - The commit has been reverted as suggested by Adam. The reason was that the patch adds in the framework several dependencies from the applications (mainly Party). A rework must be done. A possible solution could be to move the register stuff to the commonext component instead of common. What do you think?

          People

          • Assignee:
            Bruno Busco
            Reporter:
            Bruno Busco
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development