[OFBIZ-4023] Wrong product displayed as associated product

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: Release Branch 09.04, Release Branch 10.04, Trunk
• Component/s: ecommerce

Environment

Rev 1035845

• Assignee: Jacques Le Roux
• Reporter: Anne Jessel
• Created: 18/Nov/10 00:53
• Updated: 05/Dec/10 19:22
• Resolved: 05/Dec/10 19:22

Description

To reproduce:

• add two associated products to a main product, both with "Complementary or Cross-Sell" association type

• view the main product in ecommerce

Expected behaviour: the two associated products are listed near the bottom of the page

Actual behaviour: two products are listed at the bottom of the page, but only one of them is an associated product. The other is the main product.

The problem is caused by the value of a freemarker variable changing at a point where other freemarker code assumes the variable does not change. The execution path is complicated.

I will attach a patch which does fix the problem, by saving the value of the key variable into another variable, and restoring it later. However I do wonder if there is a better solution.