[OFBIZ-4022] Collapse all broken if hyperlink in pane

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: jQuery, Release Branch 09.04, Release Branch 10.04, Trunk
• Component/s: framework

Environment

Rev 1035845

• Assignee: Jacques Le Roux
• Reporter: Anne Jessel
• Created: 18/Nov/10 03:05
• Updated: 01/Feb/11 05:15
• Resolved: 05/Dec/10 17:13

Description

To reproduce the bug:

• edit the EditProduct form in applications/product/widget/catalog/ProductForms.xml

• add a new field with a hyperlink sub-element.

• refer to this new field in the first, non-collapsible field-group in the sort-order

• go to this page in the UI (edit a product in the catalog)

• the Expand All and Collapse All buttons do not work properly

The problem is caused by the javascript finding the added hyperlink field in the first field-group, and incorrectly assuming it is
the expand/collapse link for the field-group. This causes the javascript to crash when it gets a null reference to an enclosing li element.

It is not specific to the EditProduct form, but applies to any group of collapsible panes where one contains a hyperlink.

The attached patch simply checks that the li element actually exists.

Issue Links

• is duplicated by: OFBIZ-2413 The search servlet (up part of lookup screens) is any longer collapsable