OFBiz
  1. OFBiz
  2. OFBIZ-3814 jQuery Implementtion - Umbrella Main Task
  3. OFBIZ-4015

The time part (cursors) of the Date Time picker is not internationalized

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Release Branch 11.04, Trunk
    • Component/s: None
    • Labels:
      None

      Activity

      Hide
      Sascha Rodekamp added a comment -

      Another issue i faced at the timepicker stuff is the loading of the i18n files for the timepicker, once we had in our CommonScreen.xml this line:

      <set field="initialLocale" type="String" value="${groovy:parameters?.userLogin?.lastLocale?.substring(0,2)}" default-value="${groovy:locale?.toString()?.substring(0,2)?:'en'}"/>
      

      now it has been changed to

      <set field="initialLocale" type="String" value="${parameters.userLogin.lastLocale}" default-value="${groovy:locale.toString()}"/>
      

      I miss the

      ?.substring(0,2)?:'en'
      

      Because the framework tries to load a jquery.ui.datepicker-de_DE.js but the the file is called jquery.ui.datepicker-de.js.

      Should we readd the substring stuff?

      Show
      Sascha Rodekamp added a comment - Another issue i faced at the timepicker stuff is the loading of the i18n files for the timepicker, once we had in our CommonScreen.xml this line: <set field= "initialLocale" type= " String " value= "${groovy:parameters?.userLogin?.lastLocale?.substring(0,2)}" default -value= "${groovy:locale?.toString()?.substring(0,2)?:'en'}" /> now it has been changed to <set field= "initialLocale" type= " String " value= "${parameters.userLogin.lastLocale}" default -value= "${groovy:locale.toString()}" /> I miss the ?.substring(0,2)?:'en' Because the framework tries to load a jquery.ui.datepicker-de_DE.js but the the file is called jquery.ui.datepicker-de.js. Should we readd the substring stuff?
      Hide
      Jacques Le Roux added a comment -

      Hi Sascha,

      Yes, great that you found that too. I think we need to do the same I did for prototype. I'm off today, but you may have a look at how it's done in trunk

      Show
      Jacques Le Roux added a comment - Hi Sascha, Yes, great that you found that too. I think we need to do the same I did for prototype. I'm off today, but you may have a look at how it's done in trunk
      Hide
      Sascha Rodekamp added a comment -

      Jep Jacques,

      here is the patch

      Have a good day off!!

      Cheers
      Sascha

      Show
      Sascha Rodekamp added a comment - Jep Jacques, here is the patch Have a good day off!! Cheers Sascha
      Hide
      Jacques Le Roux added a comment - - edited

      Hi Sascha,

      Finally I decided to enhance the previous code in order to handle correctly the language_country case (like jquery.ui.datepicker-de-CH.js or jquery.ui.datepicker-fr-CH.js). BTW, for those interested, I found more localized files, notably jquery.ui.datepicker-fr-CH.js, in the last revision at http://jquery-ui.googlecode.com/svn/trunk/ui/i18n/ than in the zipped file we used (I used jquery-ui-1.8.6.custom.zip)

      It's commited at r1037428

      Show
      Jacques Le Roux added a comment - - edited Hi Sascha, Finally I decided to enhance the previous code in order to handle correctly the language_country case (like jquery.ui.datepicker-de-CH.js or jquery.ui.datepicker-fr-CH.js). BTW, for those interested, I found more localized files, notably jquery.ui.datepicker-fr-CH.js, in the last revision at http://jquery-ui.googlecode.com/svn/trunk/ui/i18n/ than in the zipped file we used (I used jquery-ui-1.8.6.custom.zip) It's commited at r1037428
      Show
      Jacques Le Roux added a comment - I put a request at https://github.com/trentrichardson/jQuery-Timepicker-Addon/issues/issue/80/#comment_669870
      Hide
      Jacques Le Roux added a comment -

      Fixed in
      trunk r1178199
      R11.04 r1178203

      Show
      Jacques Le Roux added a comment - Fixed in trunk r1178199 R11.04 r1178203

        People

        • Assignee:
          Jacques Le Roux
          Reporter:
          Jacques Le Roux
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development