Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6321 Widget form skip-start umbrella issue
  3. OFBIZ-3920

HtmlFormRenderer : with attribute skip-start, lookup fields are broken

    Details

      Description

      When you want to merge to form and use skip-start="true" on the second form, all contained lookup are broken. In this case, the javascript used to call Lookup screen are using the form name eg : '<a href="javascript:call_fieldlookupLayer( document.form2.lookupfield, 'Tagert', ...)', but with skip-start, the form name isn't present.
      A possible solution is to force lookup field id, but it's not managed on htmlFormMacroLibrary.ftl. I will submit a patch to make this possible.

      I don't manage problem on descriptionField, this would need to change ModelFormRender and it's a little bit more complicated
      Nicolas

        Issue Links

          Activity

          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          I think we should use the same for calendar, reported some time ago by Chris Howe at OFBIZ-2282

          Show
          jacques.le.roux Jacques Le Roux added a comment - I think we should use the same for calendar, reported some time ago by Chris Howe at OFBIZ-2282
          Hide
          soledad Nicolas Malin added a comment -

          Ho sorry for duplication jira.
          I think you right, it's the same problem, I recreate my patcch to correct both issue.

          thx

          Nicolas

          Show
          soledad Nicolas Malin added a comment - Ho sorry for duplication jira. I think you right, it's the same problem, I recreate my patcch to correct both issue. thx Nicolas
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Cool, thanks Nicolas!

          Show
          jacques.le.roux Jacques Le Roux added a comment - Cool, thanks Nicolas!
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Actually we had a discussion with Nicolas, and it's not exactly the same problem, OFBIZ -2282 seems harder to fix... but still doable...

          Show
          jacques.le.roux Jacques Le Roux added a comment - Actually we had a discussion with Nicolas, and it's not exactly the same problem, OFBIZ -2282 seems harder to fix... but still doable...
          Hide
          soledad Nicolas Malin added a comment -

          Jacques, I haven't time to fixed it now, but I promise , ASAP

          Nicolas

          Show
          soledad Nicolas Malin added a comment - Jacques, I haven't time to fixed it now, but I promise , ASAP Nicolas
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          No worries Nicolas, there is no hurry.

          Thanks

          Show
          jacques.le.roux Jacques Le Roux added a comment - No worries Nicolas, there is no hurry. Thanks
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          ping?

          Show
          jacques.le.roux Jacques Le Roux added a comment - ping?
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Hi Nicolas,

          I wanted to apply your patch and close this issue, OFBIZ-2282 being another task. But it's outdated. I guess on your side you merged, could you please create a new patch?

          Show
          jacques.le.roux Jacques Le Roux added a comment - Hi Nicolas, I wanted to apply your patch and close this issue, OFBIZ-2282 being another task. But it's outdated. I guess on your side you merged, could you please create a new patch?
          Hide
          deepak.dixit Deepak Dixit added a comment - - edited

          Hi Jacques,

          IMO we can close this task, as call_ pattern is deprecated for lookup, and as per new pattern its working as expected.

          Show
          deepak.dixit Deepak Dixit added a comment - - edited Hi Jacques, IMO we can close this task, as call_ pattern is deprecated for lookup, and as per new pattern its working as expected.
          Hide
          deepak.dixit Deepak Dixit added a comment -

          We need to look into layered lookup, its showing js error for skip-start.

          Show
          deepak.dixit Deepak Dixit added a comment - We need to look into layered lookup, its showing js error for skip-start.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks to Deepak for the reminder, this is a duplicate of OFBIZ-6139

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks to Deepak for the reminder, this is a duplicate of OFBIZ-6139
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Wait no, I have to check from FTL side... reopening

          Show
          jacques.le.roux Jacques Le Roux added a comment - Wait no, I have to check from FTL side... reopening
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          OK, my last comment makes no sense, there is no skip-start on the FTL side!

          Nevertheless I had a look at what it could entail regarding HtmlFormRenderer. he HtmlFormRenderer is no longer used to render lookup fields in forms widgets . It has been replaced by MacroFormRenderer class + htmlMenuMacroLibrary.ftl. Apart maybe indirectly in multi forms (renderMultiFormClose), but there are currently any lookups in a multi form, moreover one using skip-start!

          So we can indeed safely close this issue as a duplicate of OFBIZ-6139.

          In case of same issue elsewhere a new Jira should be created

          Show
          jacques.le.roux Jacques Le Roux added a comment - OK, my last comment makes no sense, there is no skip-start on the FTL side! Nevertheless I had a look at what it could entail regarding HtmlFormRenderer. he HtmlFormRenderer is no longer used to render lookup fields in forms widgets . It has been replaced by MacroFormRenderer class + htmlMenuMacroLibrary.ftl. Apart maybe indirectly in multi forms (renderMultiFormClose), but there are currently any lookups in a multi form, moreover one using skip-start! So we can indeed safely close this issue as a duplicate of OFBIZ-6139 . In case of same issue elsewhere a new Jira should be created

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              soledad Nicolas Malin
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development