OFBiz
  1. OFBiz
  2. OFBIZ-3907

Product Promo Worker description patch

    Details

    • Type: Improvement Improvement
    • Status: Reopened
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: Trunk
    • Fix Version/s: None
    • Component/s: order
    • Labels:
      None

      Description

      This patch extend the order adjustment creation. If an order adjustment is created from a product promo the promo text will stores in the order adjustment description. This helps identifying the order adjustment and later on the invoice item type : ITM_PROMOTION_ADJ.

      So long
      Sascha

        Activity

        Hide
        Scott Gray added a comment -

        Hi Sascha,

        You've written the exact same 13 lines of code in two places, instead please consider supplying a new patch with a separate method: something like getProductPromoDescription() which is called from the two other methods to retrieve the adjustment description.

        Thanks
        Scott

        Show
        Scott Gray added a comment - Hi Sascha, You've written the exact same 13 lines of code in two places, instead please consider supplying a new patch with a separate method: something like getProductPromoDescription() which is called from the two other methods to retrieve the adjustment description. Thanks Scott
        Hide
        Sascha Rodekamp added a comment -

        Hi Scott,
        yes that was necessary, here is the refactored code.

        Thanks
        Sascha

        Show
        Sascha Rodekamp added a comment - Hi Scott, yes that was necessary, here is the refactored code. Thanks Sascha
        Hide
        Sascha Rodekamp added a comment -

        Anything new here?

        Show
        Sascha Rodekamp added a comment - Anything new here?
        Hide
        Jacques Le Roux added a comment -

        Thanks Sascha,

        Your patch is in trunk at r1024177

        Show
        Jacques Le Roux added a comment - Thanks Sascha, Your patch is in trunk at r1024177
        Hide
        Scott Gray added a comment -

        InvoiceItem.description doesn't allow html but a number of demo promotions have html (links) in the promo text. This prevents invoices from being created for any orders containing those promotions.

        Why are we preferring the promo text over the promo name when supplying the order adjustment description?

        Show
        Scott Gray added a comment - InvoiceItem.description doesn't allow html but a number of demo promotions have html (links) in the promo text. This prevents invoices from being created for any orders containing those promotions. Why are we preferring the promo text over the promo name when supplying the order adjustment description?
        Hide
        Jacques Le Roux added a comment -

        Then it should be done in reversed order I guess, Sascha?

        Show
        Jacques Le Roux added a comment - Then it should be done in reversed order I guess, Sascha?
        Hide
        Sascha Rodekamp added a comment -

        Yes good point. I'll check tonight. Thanks Scott for the hint

        Show
        Sascha Rodekamp added a comment - Yes good point. I'll check tonight. Thanks Scott for the hint
        Hide
        Jacques Le Roux added a comment -

        Ping

        Show
        Jacques Le Roux added a comment - Ping

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Sascha Rodekamp
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development