OFBiz
  1. OFBiz
  2. OFBIZ-3904

Bug in calling methods defined in Usps Services

    Details

      Description

      Calling "getPackageSplit" & "calcPackageWeight" methods from outside of the class causes compilation error, as their access modifiers are private.
      So fixing this bug, following points are covered in this commit.

      1) Moving "getPackageSplit" and "calcPackageWeight" from UspsServices.java to ShipmentWorker.java. They are not Usps third party related methods.
      2) Changing access modifiers of these methods to public.

      1. OFBIZ-3904.patch
        18 kB
        Vivek Mishra

        Activity

        Vivek Mishra created issue -
        Vivek Mishra made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Vivek Mishra added a comment -

        Here is the patch for the same.

        Show
        Vivek Mishra added a comment - Here is the patch for the same.
        Vivek Mishra made changes -
        Attachment OFBIZ-3904.patch [ 12453230 ]
        Ashish Vijaywargiya made changes -
        Assignee Ashish Vijaywargiya [ toashishvijay ]
        Ashish Pareek committed 990127 (2 files)
        Reviews: none

        Applied patch from jira issue OFBIZ-3904 - Bug in calling methods defined in Usps Services.
        Calling "getPackageSplit" & "calcPackageWeight" methods from outside of the class causes compilation error, as their access modifiers are private.
        So fixing this bug, following points are covered in this commit.
        1) Moving "getPackageSplit" and "calcPackageWeight" from UspsServices.java to ShipmentWorker.java. They are not Usps third party related methods.
        2) Changing access modifiers of these methods to public.

        Thanks Vivek for the contribution.

        Ashish Pareek committed 990130 (3 files)
        Reviews: none

        Applied fix from trunk for revision: 990127
        ===

        Applied patch from jira issue OFBIZ-3904 - Bug in calling methods defined in Usps Services.
        Calling "getPackageSplit" & "calcPackageWeight" methods from outside of the class causes compilation error, as their access modifiers are private.
        So fixing this bug, following points are covered in this commit.
        1) Moving "getPackageSplit" and "calcPackageWeight" from UspsServices.java to ShipmentWorker.java. They are not Usps third party related methods.
        2) Changing access modifiers of these methods to public.

        Hide
        Ashish Vijaywargiya added a comment -

        Thanks Vivek for the contribution - committed in trunk at r990127 & ReleaseBranch 10.04 at r990130.


        Ashish

        Show
        Ashish Vijaywargiya added a comment - Thanks Vivek for the contribution - committed in trunk at r990127 & ReleaseBranch 10.04 at r990130. – Ashish
        Ashish Vijaywargiya made changes -
        Status Patch Available [ 10002 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Hide
        Vivek Mishra added a comment -

        Thanks Ashish.

        Show
        Vivek Mishra added a comment - Thanks Ashish.

          People

          • Assignee:
            Ashish Vijaywargiya
            Reporter:
            Vivek Mishra
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development