Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-3904

Bug in calling methods defined in Usps Services

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Release Branch 10.04, Trunk
    • Component/s: product
    • Labels:
      None

      Description

      Calling "getPackageSplit" & "calcPackageWeight" methods from outside of the class causes compilation error, as their access modifiers are private.
      So fixing this bug, following points are covered in this commit.

      1) Moving "getPackageSplit" and "calcPackageWeight" from UspsServices.java to ShipmentWorker.java. They are not Usps third party related methods.
      2) Changing access modifiers of these methods to public.

      1. OFBIZ-3904.patch
        18 kB
        Vivek Mishra

        Activity

        Hide
        ofbizmaniac Vivek Mishra added a comment -

        Thanks Ashish.

        Show
        ofbizmaniac Vivek Mishra added a comment - Thanks Ashish.
        Hide
        toashishvijay Ashish Vijaywargiya added a comment -

        Thanks Vivek for the contribution - committed in trunk at r990127 & ReleaseBranch 10.04 at r990130.


        Ashish

        Show
        toashishvijay Ashish Vijaywargiya added a comment - Thanks Vivek for the contribution - committed in trunk at r990127 & ReleaseBranch 10.04 at r990130. – Ashish
        Hide
        ofbizmaniac Vivek Mishra added a comment -

        Here is the patch for the same.

        Show
        ofbizmaniac Vivek Mishra added a comment - Here is the patch for the same.

          People

          • Assignee:
            toashishvijay Ashish Vijaywargiya
            Reporter:
            ofbizmaniac Vivek Mishra
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development