OFBiz
  1. OFBiz
  2. OFBIZ-3844

Splitting CommonRate and CommonProductRating

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: Release 09.04
    • Fix Version/s: Release Branch 09.04
    • Component/s: framework, product
    • Labels:
      None
    • Environment:

      irrelevant, only XML and FTL changes

      Description

      The CommonRate label is currently not used coherently throughout the application stack. The existing translations suggest that the commonly understood meaning of CommonRate is a rate as a tariff or day rate. However, in the product management GUI, the CommonRate label is used to demark the section where ProductRating setting are made.

      The provided fix splits CommonRate into two labels, CommonRate and CommonProductRating. Also, the application/product/webapp/ form definition now references the CommonProductRating label.

      Unfortunately, the patches have to be provided per affected file, i.e. two patches make this imporvement.

        Issue Links

          Activity

          Hide
          Carsten Schinzer added a comment -

          Uploading both patches

          Show
          Carsten Schinzer added a comment - Uploading both patches
          Hide
          Jacques Le Roux added a comment - - edited

          Hi Carsten,

          I can see only one patch... Also why should this go only in R9.04?

          Show
          Jacques Le Roux added a comment - - edited Hi Carsten, I can see only one patch... Also why should this go only in R9.04?
          Hide
          Carsten Schinzer added a comment -

          I removed the second patch, because more updates to CommonUiLabels.xml (including the minor changes required here) have been submitted in OFBIZ-3868. Apologies for the confusion.

          Show
          Carsten Schinzer added a comment - I removed the second patch, because more updates to CommonUiLabels.xml (including the minor changes required here) have been submitted in OFBIZ-3868 . Apologies for the confusion.
          Hide
          Carsten Schinzer added a comment -

          as indicated in the earlier comment.

          Show
          Carsten Schinzer added a comment - as indicated in the earlier comment.
          Hide
          Markus M. May added a comment -

          Both patches are required to resolve this issue. One is for the UiLabels, the other fixes the productForm.

          Show
          Markus M. May added a comment - Both patches are required to resolve this issue. One is for the UiLabels, the other fixes the productForm.
          Hide
          Markus M. May added a comment -

          The attached patches will most probably only work if issue OFBIZ-3868 is already resolved.

          Show
          Markus M. May added a comment - The attached patches will most probably only work if issue OFBIZ-3868 is already resolved.
          Hide
          Adrian Crum added a comment - - edited

          For English words that have multiple meanings (like "rate") it would be nice to include a hint in the key that indicates which meaning is intended. In this case, something like CommonRelationRate or CommonRatioRate (money per hour, etc) and CommonValueRate or CommonAssessRate (product rating). We could also include notes in the label file to provide a complete description of the label's meaning. Those descriptions could be kept in a <description> element inside the <property> element.

          Show
          Adrian Crum added a comment - - edited For English words that have multiple meanings (like "rate") it would be nice to include a hint in the key that indicates which meaning is intended. In this case, something like CommonRelationRate or CommonRatioRate (money per hour, etc) and CommonValueRate or CommonAssessRate (product rating). We could also include notes in the label file to provide a complete description of the label's meaning. Those descriptions could be kept in a <description> element inside the <property> element.
          Hide
          Markus M. May added a comment -

          +1 for Adrians Suggestion

          Show
          Markus M. May added a comment - +1 for Adrians Suggestion

            People

            • Assignee:
              Jacques Le Roux
              Reporter:
              Carsten Schinzer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development