Details

      Description

      When we open a layered lookup inside layered lookup, if we perform any action like click on "find", minimize/enlarge button, or calendar, then the first layered lookup disappears and the faded background turns to normal. So the lookup become of no-use.

      Here is the link https://localhost:8443/content/control/FindSurvey . For the effects you have to change second lookup's presentation into layer or remove it.

      1. lookup_issue.patch
        7 kB
        Ankit Jain
      2. lookup.patch
        4 kB
        Ankit Jain
      3. OFBIZ-3768_setValueWindowLayerLookup.patch
        6 kB
        Sascha Rodekamp

        Issue Links

          Activity

          Hide
          Ankit Jain added a comment -

          Thanks Sascha

          np, because one issue is still open, so we'll work on it.

          HTH

          Show
          Ankit Jain added a comment - Thanks Sascha np, because one issue is still open, so we'll work on it. HTH
          Hide
          Sascha Rodekamp added a comment -

          Awesome, good work Ankit thanks for your help and sorry that i didn't found enough time to work with you on this issue.

          Have a good day.

          Show
          Sascha Rodekamp added a comment - Awesome, good work Ankit thanks for your help and sorry that i didn't found enough time to work with you on this issue. Have a good day.
          Hide
          Jacques Le Roux added a comment - - edited

          Mmm, we have still an issue with the recursive case also, I will document it there: OFBIZ-3693

          Show
          Jacques Le Roux added a comment - - edited Mmm, we have still an issue with the recursive case also, I will document it there: OFBIZ-3693
          Hide
          Jacques Le Roux added a comment -

          Ankit,

          Yes, I have also to understand why when I call recursively a layered lookup inside another layered lookup the 1st call works well but after it's blocked. Not a big deal as it does not make much sense in the real life, but I will have a look. So yes only the ugly screens issue OFBIZ-3450, when we got disconnected from a layered lookups still stands.

          At r944623 in trunk and r944625 in R10.04 I have removed all the remaining superfluous presentation="window"

          Show
          Jacques Le Roux added a comment - Ankit, Yes, I have also to understand why when I call recursively a layered lookup inside another layered lookup the 1st call works well but after it's blocked. Not a big deal as it does not make much sense in the real life, but I will have a look. So yes only the ugly screens issue OFBIZ-3450 , when we got disconnected from a layered lookups still stands. At r944623 in trunk and r944625 in R10.04 I have removed all the remaining superfluous presentation="window"
          Hide
          Ankit Jain added a comment -

          Thanx Jacques,

          So just one issue left

          Show
          Ankit Jain added a comment - Thanx Jacques, So just one issue left
          Hide
          Jacques Le Roux added a comment -

          Ankit,

          Your patch is in trunk at r944614, R10.04 at r944618

          Show
          Jacques Le Roux added a comment - Ankit, Your patch is in trunk at r944614, R10.04 at r944618
          Hide
          Ankit Jain added a comment -

          Thanks Jacques

          Show
          Ankit Jain added a comment - Thanks Jacques
          Hide
          Ankit Jain added a comment -

          Thanks Jacques

          Show
          Ankit Jain added a comment - Thanks Jacques
          Hide
          Jacques Le Roux added a comment -

          Thanks Ankit,

          It seems to work well indeed. I will commit it soon with a bunch of other things. Still testing but should be ok, good job!

          Show
          Jacques Le Roux added a comment - Thanks Ankit, It seems to work well indeed. I will commit it soon with a bunch of other things. Still testing but should be ok, good job!
          Hide
          Ankit Jain added a comment -

          Hi all,

          Here is the patch which resolves the layered inside the simple lookup issue, and here i am using same function(set_value) for both types of lookup and comment the set_value & set_values functions in lookup.ftl. And if not needed we can also remove them.

          And Jacques, this patch also have previous patch fixes, So this only patch fixes the above issue and the layered inside the window lookup issue.

          Thanx

          Show
          Ankit Jain added a comment - Hi all, Here is the patch which resolves the layered inside the simple lookup issue, and here i am using same function(set_value) for both types of lookup and comment the set_value & set_values functions in lookup.ftl. And if not needed we can also remove them. And Jacques, this patch also have previous patch fixes, So this only patch fixes the above issue and the layered inside the window lookup issue. Thanx
          Hide
          Ankit Jain added a comment -

          Hi Sascha,

          i found issue in the your patch the value is not reaching to its target field in the main form from where the simple lookup called,
          it is because the window lookup target is replaced by the layered lookup target....

          Thanx

          Show
          Ankit Jain added a comment - Hi Sascha, i found issue in the your patch the value is not reaching to its target field in the main form from where the simple lookup called, it is because the window lookup target is replaced by the layered lookup target.... Thanx
          Hide
          Sascha Rodekamp added a comment -

          Hm Jacques, i found a bug when i try to call the Work Effort Parent Id Lookup Field in the LookupWorkEffort. The LookupFacility and LookupFixedAsset works after the patch.

          I noticed also that the Layered Lookup takes the whole window space when i click the find button (but only in IE).

          I will face this issues this evening or tomorrow.
          For now my last patch should help to fix the basic issus when you call a layered lookup from the window lookup.

          Show
          Sascha Rodekamp added a comment - Hm Jacques, i found a bug when i try to call the Work Effort Parent Id Lookup Field in the LookupWorkEffort. The LookupFacility and LookupFixedAsset works after the patch. I noticed also that the Layered Lookup takes the whole window space when i click the find button (but only in IE). I will face this issues this evening or tomorrow. For now my last patch should help to fix the basic issus when you call a layered lookup from the window lookup.
          Hide
          Jacques Le Roux added a comment -

          Sascha,

          I just made a quick try and found an issue with LookupWorkeffort. I don't speak about the recursive aspect which is another issue. But if you remove the window presentation for LookupFacility and LookupFixedAsset inside lookupWorkEffort (in applications/workeffort/widget/LookupForms.xml) you get issues:

          1. the LookupFacility take all the space when you click on its find button
          2. when you come back to the page from where the LookupWorkEffort is called (I used agreement workeffort in accouting: https://localhost:8443/accounting/control/EditAgreementWorkEffortApplics) the lookups for facility and fixeasset have dissapeared

          At least it what I found so far... I will try on another instance later...

          Show
          Jacques Le Roux added a comment - Sascha, I just made a quick try and found an issue with LookupWorkeffort. I don't speak about the recursive aspect which is another issue. But if you remove the window presentation for LookupFacility and LookupFixedAsset inside lookupWorkEffort (in applications/workeffort/widget/LookupForms.xml) you get issues: the LookupFacility take all the space when you click on its find button when you come back to the page from where the LookupWorkEffort is called (I used agreement workeffort in accouting: https://localhost:8443/accounting/control/EditAgreementWorkEffortApplics ) the lookups for facility and fixeasset have dissapeared At least it what I found so far... I will try on another instance later...
          Hide
          Sascha Rodekamp added a comment -

          Hey guys,

          i fixed the issue. When you now open a layered lookup from a window lookup the variabels will be set in the right field and only the layered lookup will be closed.

          BTW: I fixed the issue with the faded Background. The background will only be removed when no layered lookup is open.

          Have a nice day and many thanks Ankit for your help.

          Sascha

          Show
          Sascha Rodekamp added a comment - Hey guys, i fixed the issue. When you now open a layered lookup from a window lookup the variabels will be set in the right field and only the layered lookup will be closed. BTW: I fixed the issue with the faded Background. The background will only be removed when no layered lookup is open. Have a nice day and many thanks Ankit for your help. Sascha
          Hide
          Ankit Jain added a comment -

          HI jacques, Sascha, Atul

          i found that when we open a layered lookup from the simple lookup, at the time when when we select the value from the find list of the layered lookup the value get set in the main screen field from where the simple lookup called instead of simple lookup field & both the lookup get closed.

          It is because the simple lookup uses the set value function of the lookup.ftl not of the fieldlookup.js & then the same function is used by the layered lookup which is inside the simple lookup, when we select the value from layered lookup its target got replaced by the simple lookup target and both the lookup get closed.

          If we use the js function then its giving error and i am working on it.....

          Thanks

          Show
          Ankit Jain added a comment - HI jacques, Sascha, Atul i found that when we open a layered lookup from the simple lookup, at the time when when we select the value from the find list of the layered lookup the value get set in the main screen field from where the simple lookup called instead of simple lookup field & both the lookup get closed. It is because the simple lookup uses the set value function of the lookup.ftl not of the fieldlookup.js & then the same function is used by the layered lookup which is inside the simple lookup, when we select the value from layered lookup its target got replaced by the simple lookup target and both the lookup get closed. If we use the js function then its giving error and i am working on it..... Thanks
          Hide
          Ankit Jain added a comment -

          Hi Jacques,

          I am using Ubuntu 8.04 OS & Firefox 3.0.13 , Chrome. And i tested it in both the browsers.

          Thanks

          Show
          Ankit Jain added a comment - Hi Jacques, I am using Ubuntu 8.04 OS & Firefox 3.0.13 , Chrome. And i tested it in both the browsers. Thanks
          Hide
          Jacques Le Roux added a comment -

          Hi Ankit,

          On which OS and browser(s)? BTW I have not time today to look at that, but as I will get a chance I will continue

          Thanks

          Show
          Jacques Le Roux added a comment - Hi Ankit, On which OS and browser(s)? BTW I have not time today to look at that, but as I will get a chance I will continue Thanks
          Hide
          Ankit Jain added a comment -

          Hi Jacques ,

          I checked the above mentioned links i couldn't find any issue, at my end its working & i also checked the demo server its working there too no collapse button hangs .

          I dont know whats the problem at your end , i dont think its due to my patch because i checked both links and its working fine...

          Thanks

          Show
          Ankit Jain added a comment - Hi Jacques , I checked the above mentioned links i couldn't find any issue, at my end its working & i also checked the demo server its working there too no collapse button hangs . I dont know whats the problem at your end , i dont think its due to my patch because i checked both links and its working fine... Thanks
          Hide
          Jacques Le Roux added a comment -

          Ankit,

          Please could you check the collapse button when layering current windowed lookups?
          For instance https://localhost:28443/accounting/control/EditAgreementWorkEffortApplics?agreementId=8000

          • windowed = collapse button does not always work but does not hang (it expands but does not collapse, but when you re-enter, ie re-call it, I checked same on trunk demo, so your patch is not implied)
          • layered = collapse button always hangs (actually show a not bad layered lookup screen)
            I guess it's the same for all LookupWorkEfforts (21 at all)

          We have the same problem at https://localhost:28443/accounting/control/findPayments without your patch or not (I reproduce on trunk demo). The collapse button hangs the already layered 2 LookupPartyNames (FindPayments form in PaymentForms.xml)

          That's all I did for the moment

          HTH

          Show
          Jacques Le Roux added a comment - Ankit, Please could you check the collapse button when layering current windowed lookups? For instance https://localhost:28443/accounting/control/EditAgreementWorkEffortApplics?agreementId=8000 windowed = collapse button does not always work but does not hang (it expands but does not collapse, but when you re-enter, ie re-call it, I checked same on trunk demo, so your patch is not implied) layered = collapse button always hangs (actually show a not bad layered lookup screen) I guess it's the same for all LookupWorkEfforts (21 at all) We have the same problem at https://localhost:28443/accounting/control/findPayments without your patch or not (I reproduce on trunk demo). The collapse button hangs the already layered 2 LookupPartyNames (FindPayments form in PaymentForms.xml) That's all I did for the moment HTH
          Hide
          Jacques Le Roux added a comment -

          Also you are maybe right about opening a layered lookup from a simple lookup(window) since we still need for the moment to keep window(popup) lookups for recursive calls (typically content and workeffort, actually maybe category also and all cases where a tree exists). I will try to simply alreay what we have, ie when there are no recursive calls from the lookup, we should remove the window presentation and commit with your changes...

          Show
          Jacques Le Roux added a comment - Also you are maybe right about opening a layered lookup from a simple lookup(window) since we still need for the moment to keep window(popup) lookups for recursive calls (typically content and workeffort, actually maybe category also and all cases where a tree exists). I will try to simply alreay what we have, ie when there are no recursive calls from the lookup, we should remove the window presentation and commit with your changes...
          Hide
          Jacques Le Roux added a comment -

          My fix for recursive calls at OFBIZ-3693 does not work now. It's because of the Find action and I have not worked on this yet. I will continue...

          Thanks

          Show
          Jacques Le Roux added a comment - My fix for recursive calls at OFBIZ-3693 does not work now. It's because of the Find action and I have not worked on this yet. I will continue... Thanks
          Hide
          Jacques Le Roux added a comment -

          Oops, I just realize that it's the specific recursive case. So I will commit your changes and will try also the fix I have for the recursive case. We have never been so near to the end

          Show
          Jacques Le Roux added a comment - Oops, I just realize that it's the specific recursive case. So I will commit your changes and will try also the fix I have for the recursive case. We have never been so near to the end
          Hide
          Jacques Le Roux added a comment -

          To test I remove all the presentation="window", and that's what we are aiming for at the end... So I guess if you do so you should not have to worry about the issue you raised above.
          I wonder why you don't get the issue with Content from FindSurvey though. I will retry in case a browser cache issue is behind...

          Show
          Jacques Le Roux added a comment - To test I remove all the presentation="window", and that's what we are aiming for at the end... So I guess if you do so you should not have to worry about the issue you raised above. I wonder why you don't get the issue with Content from FindSurvey though. I will retry in case a browser cache issue is behind...
          Hide
          Ankit Jain added a comment -

          Hi Jacques,

          I want to tell you that on my side things are working fine , one kind of error i found is that when we are trying to open a layered lookup from a simple lookup(window) then the screen got trapped , & it is because the display is none for the layered lookup, i will get back to you after fixing it. And i also tested my recent patch it didn't broked any fuctionality.

          And i also tested at many places where the lookup is used things are working great.

          Thanks

          Show
          Ankit Jain added a comment - Hi Jacques, I want to tell you that on my side things are working fine , one kind of error i found is that when we are trying to open a layered lookup from a simple lookup(window) then the screen got trapped , & it is because the display is none for the layered lookup, i will get back to you after fixing it. And i also tested my recent patch it didn't broked any fuctionality. And i also tested at many places where the lookup is used things are working great. Thanks
          Hide
          Jacques Le Roux added a comment -

          Hi Ankit, Atul,

          It looks good and is really a great improvement. But there is still a little problem. Using the link you provided (FindSurvey), if you look for content values you get trapped because the form takes all the screen and stays like that (you can't select a content an get back). It seems that most of the other cases works but I only tested some. There are actually 76 presentation="window", could you help me on that last aspect (where hand testing is safer)?

          Thanks

          Show
          Jacques Le Roux added a comment - Hi Ankit, Atul, It looks good and is really a great improvement. But there is still a little problem. Using the link you provided (FindSurvey), if you look for content values you get trapped because the form takes all the screen and stays like that (you can't select a content an get back). It seems that most of the other cases works but I only tested some. There are actually 76 presentation="window", could you help me on that last aspect (where hand testing is safer)? Thanks
          Hide
          Ankit Jain added a comment -

          Hi Jacques,

          I found that the cause of the problem was event observer
          Event.observe(document, "mousedown", this.close_on_click=this.close_on_click.bindAsEventListener(this));

          so when any click on second lookup the first one disappears, here is the patch for it

          i also resolved the problem of fadedbackground previously the fadedbackground disappears as the second lookup closed but now we have separate fadedbackground for every lookup.

          Also Thanks to "Atul" for helping me out...

          Show
          Ankit Jain added a comment - Hi Jacques, I found that the cause of the problem was event observer Event.observe(document, "mousedown", this.close_on_click=this.close_on_click.bindAsEventListener(this)); so when any click on second lookup the first one disappears, here is the patch for it i also resolved the problem of fadedbackground previously the fadedbackground disappears as the second lookup closed but now we have separate fadedbackground for every lookup. Also Thanks to "Atul" for helping me out...
          Hide
          Jacques Le Roux added a comment -

          Thanks Ankit, this is already known and is actually a duplicate of OFBIZ-3446 and OFBIZ-3693 (the last being the specific case of recursive calls). I did close OFBIZ-3446 because it's now hard to read (a lot of unrelated things there) but keep OFBIZ-3693 as it's very specific.

          Show
          Jacques Le Roux added a comment - Thanks Ankit, this is already known and is actually a duplicate of OFBIZ-3446 and OFBIZ-3693 (the last being the specific case of recursive calls). I did close OFBIZ-3446 because it's now hard to read (a lot of unrelated things there) but keep OFBIZ-3693 as it's very specific.

            People

            • Assignee:
              Jacques Le Roux
              Reporter:
              Ankit Jain
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development