OFBiz
  1. OFBiz
  2. OFBIZ-3765

Use CustomMethod for select order, quote and invoice hook to resolve id

    Details

      Description

      Currently the invoiceId resolve process is define on PartyAcctgPreference by a enumeration. The service getNextInvoiceId analyse enumeration to active code correponding to enumeration.

      I propose pass enumeration to CustumMethod that permit to add more easier a new resolve process. Just define a new CusthomMethod and associate to PartyAcctgPreference. It's possible to add this by hot-deploy compenents without change accounting code or add many unreadable function.

      The patch contains :

      • Entity modiication : pass enumeration to deprecated and add custumMethod attribute/relation
      • Add service enforced ans restart define previously by enumeration
      • Implement getNextSeqId service by origin call service to permet analyse and resolve new id by all information present in context
      • Add error message if PartyAcctgPreference not define.
      • Apply on invoice, quote an order

      To test just ant clean-all && ant run-install and create quote, order and invoice

      Thanks to Leila Mekika for the help

      Nicolas

      1. hookByPartyAcctgPreference.patch
        46 kB
        Nicolas Malin
      2. OFBIZ-3765.patch
        46 kB
        Nicolas Malin
      3. OFBIZ-3765-Missed.patch
        9 kB
        Nicolas Malin

        Activity

        Jacques Le Roux made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Nicolas Malin made changes -
        Attachment OFBIZ-3765-Missed.patch [ 12466992 ]
        Nicolas Malin made changes -
        Attachment OFBIZ-3765-Missed.patch [ 12466993 ]
        Nicolas Malin made changes -
        Attachment OFBIZ-3765-Missed.patch [ 12466992 ]
        Jacques Le Roux made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Erwan de FERRIERES made changes -
        Assignee Erwan de FERRIERES [ erwan ]
        Nicolas Malin made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Nicolas Malin made changes -
        Attachment OFBIZ-3765.patch [ 12446687 ]
        Jacopo Cappellato made changes -
        Summary Use CustumMethod for select order, quote and invoice hook to resolve id Use CustomMethod for select order, quote and invoice hook to resolve id
        Nicolas Malin made changes -
        Labels invoice nextSeqId order quote
        Nicolas Malin made changes -
        Field Original Value New Value
        Attachment hookByPartyAcctgPreference.patch [ 12443952 ]
        Nicolas Malin created issue -

          People

          • Assignee:
            Erwan de FERRIERES
            Reporter:
            Nicolas Malin
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development