OFBiz
  1. OFBiz
  2. OFBIZ-3724

Copying WorkEffortCostCalc as part of a ProductionRun

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: Trunk
    • Component/s: manufacturing
    • Labels:
      None

      Description

      Currently when a ProductionRun is created the WorkEffortCostCalc relations are not cloned from the routing tasks. This results in not being able to change the CostCalc as part of a ProductionRun unless you were to change the routing task template for all production runs. As part of reviewing this patch I would like two things to be considered –

      I created this patch which includes an enhancement to the production run unit tests to test for the creation of these newly cloned relationships.

      1) createWorkEffortCostCalc service requires ACCOUNTING_CREATE permission; this does not feel right – it caused me to add that permission into the sample user/security group to execute the services. I wonder if these services should be in the WorkEffort component with appropriate work effort permission.

      2) migration concerns – if people have existing production runs in place, the new createProductionRunTaskCosts will not pickup the cost calcs that were not copied. Rather than put "backwards compatible" code in, I would prefer (if we want to handle this) to create a service that performs this clone on non-completed/closed production runs that is executed as part of a migration. Would like community discussion on this.

        Activity

          People

          • Assignee:
            Jacopo Cappellato
            Reporter:
            Bob Morley
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development