OFBiz
  1. OFBiz
  2. OFBIZ-3724

Copying WorkEffortCostCalc as part of a ProductionRun

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: SVN trunk
    • Fix Version/s: SVN trunk
    • Component/s: manufacturing
    • Labels:
      None

      Description

      Currently when a ProductionRun is created the WorkEffortCostCalc relations are not cloned from the routing tasks. This results in not being able to change the CostCalc as part of a ProductionRun unless you were to change the routing task template for all production runs. As part of reviewing this patch I would like two things to be considered –

      I created this patch which includes an enhancement to the production run unit tests to test for the creation of these newly cloned relationships.

      1) createWorkEffortCostCalc service requires ACCOUNTING_CREATE permission; this does not feel right – it caused me to add that permission into the sample user/security group to execute the services. I wonder if these services should be in the WorkEffort component with appropriate work effort permission.

      2) migration concerns – if people have existing production runs in place, the new createProductionRunTaskCosts will not pickup the cost calcs that were not copied. Rather than put "backwards compatible" code in, I would prefer (if we want to handle this) to create a service that performs this clone on non-completed/closed production runs that is executed as part of a migration. Would like community discussion on this.

        Activity

        Bob Morley created issue -
        Bob Morley made changes -
        Field Original Value New Value
        Attachment OFBIZ-3724_CloneWorkEffortCostCalc.patch [ 12442206 ]
        Bob Morley made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        BJ Freeman added a comment -

        #1` I believe Jacopo talked about changing process that did not have user interaction to system permissions.
        #2 I agree

        Show
        BJ Freeman added a comment - #1` I believe Jacopo talked about changing process that did not have user interaction to system permissions. #2 I agree
        Hide
        Jacopo Cappellato added a comment -

        I am going to review (and commit) your patch today but in the meantime here are my comments for your two points:
        1) the change you did is fine; btw the accounting permissions will be no more required as soon as the accounting secas will be executed using the run-as-user="system" permission (change that is in my todo list)
        2) it would be ideal to write this migration script; I agree with you it is a better solution than a "backward (but awkward) compatible" solution

        Show
        Jacopo Cappellato added a comment - I am going to review (and commit) your patch today but in the meantime here are my comments for your two points: 1) the change you did is fine; btw the accounting permissions will be no more required as soon as the accounting secas will be executed using the run-as-user="system" permission (change that is in my todo list) 2) it would be ideal to write this migration script; I agree with you it is a better solution than a "backward (but awkward) compatible" solution
        Jacopo Cappellato made changes -
        Assignee Jacopo Cappellato [ jacopoc ]
        Hide
        Jacopo Cappellato added a comment -

        Bob,

        your patch is in rev.935969
        I have also added some comments for upgrading in https://cwiki.apache.org/confluence/display/OFBTECH/Revisions+Requiring+Data+Migration
        It should be enough for now, but if you will create a migration service that would be great and I will commit it as well.
        Thank you.

        Show
        Jacopo Cappellato added a comment - Bob, your patch is in rev.935969 I have also added some comments for upgrading in https://cwiki.apache.org/confluence/display/OFBTECH/Revisions+Requiring+Data+Migration It should be enough for now, but if you will create a migration service that would be great and I will commit it as well. Thank you.
        Hide
        Bob Morley added a comment -

        Will do – I have created a new ticket that will ultimately have that patch – OFBIZ-3727.

        Show
        Bob Morley added a comment - Will do – I have created a new ticket that will ultimately have that patch – OFBIZ-3727 .
        Jacopo Cappellato made changes -
        Status Patch Available [ 10002 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Jacopo Cappellato
            Reporter:
            Bob Morley
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development